Skip to contentSkip to conversation

mnl: Fix -Wimplicit-function-declaration warnings

PATCH Applied Michal Rostecki 3 participants 3 messages Nov 21, 2019 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mnl: Fix -Wimplicit-function-declaration warnings

This change fixes the following warnings:

mnl.c: In function ‘mnl_nft_flowtable_add’:
mnl.c:1442:14: warning: implicit declaration of function ‘calloc’ [-Wimplicit-function-declaration]

  dev_array = calloc(len, sizeof(char *));
              ^~~~~~

mnl.c:1442:14: warning: incompatible implicit declaration of built-in function ‘calloc’ mnl.c:1442:14: note: include ‘<stdlib.h>’ or provide a declaration of ‘calloc’ mnl.c:1449:2: warning: implicit declaration of function ‘free’ [-Wimplicit-function-declaration]
free(dev_array);
^~~~
mnl.c:1449:2: warning: incompatible implicit declaration of built-in function ‘free’ mnl.c:1449:2: note: include ‘<stdlib.h>’ or provide a declaration of ‘free’

---
 src/mnl.c | 1 +
 1 file changed, 1 insertion(+)
src/mnl.c +1 -0
index fdba0af8..aa5b0b46 100644
@@ -30,6 +30,7 @@
 #include <arpa/inet.h>
 #include <fcntl.h>
 #include <errno.h>
+#include <stdlib.h>
 #include <utils.h>
 #include <nftables.h>
 
Signature · 1 line
2.16.4
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Michal Rostecki

This change fixes the following warnings:

mnl.c: In function ‘mnl_nft_flowtable_add’:
mnl.c:1442:14: warning: implicit declaration of function ‘calloc’ [-Wimplicit-function-declaration]

  dev_array = calloc(len, sizeof(char *));
              ^~~~~~

mnl.c:1442:14: warning: incompatible implicit declaration of built-in function ‘calloc’ mnl.c:1442:14: note: include ‘<stdlib.h>’ or provide a declaration of ‘calloc’ mnl.c:1449:2: warning: implicit declaration of function ‘free’ [-Wimplicit-function-declaration]
free(dev_array);
^~~~
mnl.c:1449:2: warning: incompatible implicit declaration of built-in function ‘free’ mnl.c:1449:2: note: include ‘<stdlib.h>’ or provide a declaration of ‘free’

Quoted 1 line
Fixes 1698fca7d49ff ("mnl: remove artifical cap on 8 devices per flowtable")
maintainer Applied
#2 lore raw
In reply to Michal Rostecki
Quoted 6 lines · Michal Rostecki

This change fixes the following warnings:

mnl.c: In function ‘mnl_nft_flowtable_add’:
mnl.c:1442:14: warning: implicit declaration of function ‘calloc’ [-Wimplicit-function-declaration]

  dev_array = calloc(len, sizeof(char *));
              ^~~~~~
Quoted 7 lines

mnl.c:1442:14: warning: incompatible implicit declaration of built-in function ‘calloc’ mnl.c:1442:14: note: include ‘<stdlib.h>’ or provide a declaration of ‘calloc’ mnl.c:1449:2: warning: implicit declaration of function ‘free’ [-Wimplicit-function-declaration]
free(dev_array);
^~~~
mnl.c:1449:2: warning: incompatible implicit declaration of built-in function ‘free’ mnl.c:1449:2: note: include ‘<stdlib.h>’ or provide a declaration of ‘free’

Applied, thanks.