Skip to contentSkip to conversation

nodejs: libatomic patch should be target specific

PATCH In review Khem Raj 3 participants 3 messages Nov 21, 2019 – Nov 22, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 nodejs: libatomic patch should be target specific

host usually are using gcc/x86_64/aarch64 and all of them have gcc which can support atomic intrinsics, but not all of them install libatomic by default e.g. centos-7, so asking for libatomic unconditionally may not work always

---
 meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb +1 -1
index 8c690ae7dc..e36995c258 100644
@@ -18,10 +18,10 @@ COMPATIBLE_HOST_riscv32 = "null"
 SRC_URI = "http://nodejs.org/dist/v${PV}/node-v${PV}.tar.xz \
            file://0001-Disable-running-gyp-files-for-bundled-deps.patch \
            file://0004-Make-compatibility-with-gcc-4.8.patch \
-           file://0005-Link-atomic-library.patch \
            file://0007-v8-don-t-override-ARM-CFLAGS.patch \
            "
 SRC_URI_append_class-target = " \
+           file://0005-Link-atomic-library.patch \
            file://0002-Using-native-torque.patch \
            "
 
Signature · 1 line
2.24.0
#1 lore raw
Quoted 7 lines · Khem Raj

host usually are using gcc/x86_64/aarch64 and all of them have gcc which can support atomic intrinsics, but not all of them install libatomic by default e.g. centos-7, so asking for libatomic unconditionally may not work always

Fell over this today on Fedora and had to install libatomic. So

Acked-by
#2 lore raw
Quoted 11 lines · Andreas Müller
Quoted 7 lines · Khem Raj

host usually are using gcc/x86_64/aarch64 and all of them have gcc which can support atomic intrinsics, but not all of them install libatomic by default e.g. centos-7, so asking for libatomic unconditionally may not work always

Fell over this today on Fedora and had to install libatomic. So

I think the same on Fedora-29

Quoted 7 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel