Skip to contentSkip to conversation

mbuf: display more fields in dump

PATCH Superseded Stephen Hemminger 5 participants 13 messages Nov 20, 2019 – Feb 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mbuf: display more fields in dump

The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging.

---
 lib/librte_mbuf/rte_mbuf.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
lib/librte_mbuf/rte_mbuf.c +8 -5
index 35df1c4c38a5..a964464bd598 100644
@@ -473,11 +473,14 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)
 
 	__rte_mbuf_sanity_check(m, 1);
 
-	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
-	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
-	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u, "
-	       "in_port=%u\n", m->pkt_len, m->ol_flags,
-	       (unsigned)m->nb_segs, (unsigned)m->port);
+	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u,"
+		" offs=%u, refcnt=%u\n",
+		m, (uint64_t)m->buf_iova, (unsigned)m->buf_len,
+		(unsigned)m->data_off, (unsigned)rte_mbuf_refcnt_read(m));
+	fprintf(f, "  pkt_len=%u, ol_flags=%#"PRIx64","
+		" nb_segs=%u, in_port=%u, vlan_tci=%#x\n",
+		(unsigned)m->pkt_len, m->ol_flags,
+		(unsigned)m->nb_segs, (unsigned)m->port, (unsigned)m->vlan_tci);
 	nb_segs = m->nb_segs;
 
 	while (m && nb_segs != 0) {
Signature · 1 line
2.20.1
#1 lore raw
Quoted 35 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Stephen Hemminger
Sent: Wednesday, November 20, 2019 6:41 PM

The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging.

---
 lib/librte_mbuf/rte_mbuf.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
lib/librte_mbuf/rte_mbuf.c +0 -3
index 35df1c4c38a5..a964464bd598 100644
@@ -473,11 +473,14 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf
 *m, unsigned dump_len)
 
 	__rte_mbuf_sanity_check(m, 1);
 
-	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
-	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
-	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u,

"

lib/librte_mbuf/rte_mbuf.c +8 -2
-	       "in_port=%u\n", m->pkt_len, m->ol_flags,
-	       (unsigned)m->nb_segs, (unsigned)m->port);
+	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u,"
+		" offs=%u, refcnt=%u\n",
+		m, (uint64_t)m->buf_iova, (unsigned)m->buf_len,
+		(unsigned)m->data_off, (unsigned)rte_mbuf_refcnt_read(m));
+	fprintf(f, "  pkt_len=%u, ol_flags=%#"PRIx64","
+		" nb_segs=%u, in_port=%u, vlan_tci=%#x\n",
+		(unsigned)m->pkt_len, m->ol_flags,
+		(unsigned)m->nb_segs, (unsigned)m->port, (unsigned)m-
Quoted 1 line
Quoted 1 line

vlan_tci);

Are all these explicit type casts really needed? buf_iova is already uint64_t, buflen is uint16_t, data_off is uint16_t, rte_mbuf_refcnt_read() returns uint16_t, pkt_len is uint32_t, nb_segs is uint16_t, port is uint16_t, vlan_tci is uint16_t.

m->port is not only the input port anymore (ref. the mbuf documentation), so please change in_port=%u to port=%u.

For consistency with ol_flags and vlan_tci format, consider changing iova=% to iova=%#.

Quoted 6 lines
lib/librte_mbuf/rte_mbuf.c +0 -1
 	nb_segs = m->nb_segs;
 
 	while (m && nb_segs != 0) {
--

2.20.1

#2 lore raw
Quoted 1 line · On Thu, 21 Nov 2019 17:16:42 +0100 Morten Brørup <[email protected]>…

Are all these explicit type casts really needed? buf_iova is already uint64_t, buflen is uint16_t, data_off is uint16_t, rte_mbuf_refcnt_read() returns uint16_t, pkt_len is uint32_t, nb_segs is uint16_t, port is uint16_t, vlan_tci is uint16_t.

Normally, they are not needed.
If you turn up some of the warning levels in Gcc, then yes.

Quoted 2 lines

m->port is not only the input port anymore (ref. the mbuf documentation), so please change in_port=%u to port=%u.

Makes sense, but since this in internal would rather keep existing
to print the name of the field.

Quoted 2 lines

For consistency with ol_flags and vlan_tci format, consider changing iova=% to iova=%#.

good idea, personal preference is to always use %#x over %x

#3 lore raw

PATCH v2 1/1 mbuf: display more fields in dump

In reply to Stephen Hemminger

The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging.

---
v2 - remove casts, change in_port to port
the refcount and offset are property of per-segment

 lib/librte_mbuf/rte_mbuf.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
lib/librte_mbuf/rte_mbuf.c +10 -7
index 35df1c4c38a5..4894d46628e3 100644
@@ -473,18 +473,21 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)
 
 	__rte_mbuf_sanity_check(m, 1);
 
-	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
-	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
-	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u, "
-	       "in_port=%u\n", m->pkt_len, m->ol_flags,
-	       (unsigned)m->nb_segs, (unsigned)m->port);
+	fprintf(f, "dump mbuf at %p, iova=%#"PRIx64", buf_len=%u\n",
+		m, m->buf_iova, m->buf_len);
+	fprintf(f,
+		"  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u, vlan_tci=%#x\n",
+		m->pkt_len, m->ol_flags, m->nb_segs, m->port, m->vlan_tci);
+
 	nb_segs = m->nb_segs;
 
 	while (m && nb_segs != 0) {
 		__rte_mbuf_sanity_check(m, 0);
 
-		fprintf(f, "  segment at %p, data=%p, data_len=%u\n",
-			m, rte_pktmbuf_mtod(m, void *), (unsigned)m->data_len);
+		fprintf(f, "  segment at %p, data=%p, len=%u, off=%u, refcnt=%u\n",
+			m, rte_pktmbuf_mtod(m, void *),
+			m->data_len, m->data_off, rte_mbuf_refcnt_read(m));
+
 		len = dump_len;
 		if (len > m->data_len)
 			len = m->data_len;
Signature · 1 line
2.20.1
#5 lore raw
In reply to Stephen Hemminger

Hi,

Quoted 47 lines · Stephen Hemminger

The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging.

---
v2 - remove casts, change in_port to port
the refcount and offset are property of per-segment

 lib/librte_mbuf/rte_mbuf.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
lib/librte_mbuf/rte_mbuf.c +10 -7
index 35df1c4c38a5..4894d46628e3 100644
@@ -473,18 +473,21 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)
 
 	__rte_mbuf_sanity_check(m, 1);
 
-	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
-	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
-	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u, "
-	       "in_port=%u\n", m->pkt_len, m->ol_flags,
-	       (unsigned)m->nb_segs, (unsigned)m->port);
+	fprintf(f, "dump mbuf at %p, iova=%#"PRIx64", buf_len=%u\n",
+		m, m->buf_iova, m->buf_len);
+	fprintf(f,
+		"  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u, vlan_tci=%#x\n",
+		m->pkt_len, m->ol_flags, m->nb_segs, m->port, m->vlan_tci);
+
 	nb_segs = m->nb_segs;
 
 	while (m && nb_segs != 0) {
 		__rte_mbuf_sanity_check(m, 0);
 
-		fprintf(f, "  segment at %p, data=%p, data_len=%u\n",
-			m, rte_pktmbuf_mtod(m, void *), (unsigned)m->data_len);
+		fprintf(f, "  segment at %p, data=%p, len=%u, off=%u, refcnt=%u\n",
+			m, rte_pktmbuf_mtod(m, void *),
+			m->data_len, m->data_off, rte_mbuf_refcnt_read(m));
+
 		len = dump_len;
 		if (len > m->data_len)
 			len = m->data_len;
Signature · 1 line
2.20.1

Thanks for this enhancement.

One comment however: I don't see why vlan_tci would be important than packet type or rss tag. It is also a bit confusing to display a field which can have a random value (if the vlan flag is not set in ol_flags).

I'd prefer to dump vlan_tci only if the flag is present. Later we could add more fields with the same logic. What do you think?

Olivier

#6 lore raw
Quoted 53 lines · On Thu, 26 Dec 2019 17:15:39 +0100 Olivier Matz <[email protected]> wrote:

Hi,

Quoted 47 lines · Stephen Hemminger

The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging.

---
v2 - remove casts, change in_port to port
the refcount and offset are property of per-segment

 lib/librte_mbuf/rte_mbuf.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
lib/librte_mbuf/rte_mbuf.c +10 -7
index 35df1c4c38a5..4894d46628e3 100644
@@ -473,18 +473,21 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)
 
 	__rte_mbuf_sanity_check(m, 1);
 
-	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
-	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
-	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u, "
-	       "in_port=%u\n", m->pkt_len, m->ol_flags,
-	       (unsigned)m->nb_segs, (unsigned)m->port);
+	fprintf(f, "dump mbuf at %p, iova=%#"PRIx64", buf_len=%u\n",
+		m, m->buf_iova, m->buf_len);
+	fprintf(f,
+		"  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u, vlan_tci=%#x\n",
+		m->pkt_len, m->ol_flags, m->nb_segs, m->port, m->vlan_tci);
+
 	nb_segs = m->nb_segs;
 
 	while (m && nb_segs != 0) {
 		__rte_mbuf_sanity_check(m, 0);
 
-		fprintf(f, "  segment at %p, data=%p, data_len=%u\n",
-			m, rte_pktmbuf_mtod(m, void *), (unsigned)m->data_len);
+		fprintf(f, "  segment at %p, data=%p, len=%u, off=%u, refcnt=%u\n",
+			m, rte_pktmbuf_mtod(m, void *),
+			m->data_len, m->data_off, rte_mbuf_refcnt_read(m));
+
 		len = dump_len;
 		if (len > m->data_len)
 			len = m->data_len;
Signature · 1 line
2.20.1

Thanks for this enhancement.

Quoted 6 lines

One comment however: I don't see why vlan_tci would be important than packet type or rss tag. It is also a bit confusing to display a field which can have a random value (if the vlan flag is not set in ol_flags).

I'd prefer to dump vlan_tci only if the flag is present. Later we could add more fields with the same logic. What do you think?

Because this is a debugging hook and easier to always display the value. Thats all.

#7 lore raw

Hi,

Quoted 60 lines · Stephen Hemminger
Quoted 57 lines · On Thu, 26 Dec 2019 17:15:39 +0100 Olivier Matz <[email protected]> wrote:

Hi,

Quoted 47 lines · Stephen Hemminger

The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging.

---
v2 - remove casts, change in_port to port
the refcount and offset are property of per-segment

 lib/librte_mbuf/rte_mbuf.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
lib/librte_mbuf/rte_mbuf.c +10 -7
index 35df1c4c38a5..4894d46628e3 100644
@@ -473,18 +473,21 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)
 
 	__rte_mbuf_sanity_check(m, 1);
 
-	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
-	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
-	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u, "
-	       "in_port=%u\n", m->pkt_len, m->ol_flags,
-	       (unsigned)m->nb_segs, (unsigned)m->port);
+	fprintf(f, "dump mbuf at %p, iova=%#"PRIx64", buf_len=%u\n",
+		m, m->buf_iova, m->buf_len);
+	fprintf(f,
+		"  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u, vlan_tci=%#x\n",
+		m->pkt_len, m->ol_flags, m->nb_segs, m->port, m->vlan_tci);
+
 	nb_segs = m->nb_segs;
 
 	while (m && nb_segs != 0) {
 		__rte_mbuf_sanity_check(m, 0);
 
-		fprintf(f, "  segment at %p, data=%p, data_len=%u\n",
-			m, rte_pktmbuf_mtod(m, void *), (unsigned)m->data_len);
+		fprintf(f, "  segment at %p, data=%p, len=%u, off=%u, refcnt=%u\n",
+			m, rte_pktmbuf_mtod(m, void *),
+			m->data_len, m->data_off, rte_mbuf_refcnt_read(m));
+
 		len = dump_len;
 		if (len > m->data_len)
 			len = m->data_len;
Signature · 1 line
2.20.1

Thanks for this enhancement.

One comment however: I don't see why vlan_tci would be important than packet type or rss tag. It is also a bit confusing to display a field which can have a random value (if the vlan flag is not set in ol_flags).

Quoted 5 lines
Quoted 2 lines

I'd prefer to dump vlan_tci only if the flag is present. Later we could add more fields with the same logic. What do you think?

Because this is a debugging hook and easier to always display the value. Thats all.

This is precisely because it is a debug hook that I find dangerous to display a wrong value. As the mbuf are recycled, a mbuf that does not have a vlan_tci can display its previous value, which may look valid.

What about simply doing this?

	fprintf(f,
		"  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u",
		m->pkt_len, m->ol_flags, m->nb_segs, m->port);
	if (m->ol_flags & PKT_RX_VLAN)
		fprintf(f, ", vlan_tci=%#x", m->vlan_tci);
	fprintf(f, "\n");

If you want I can submit an updated version of your patch.

#8 lore raw
Quoted 75 lines · On Fri, 27 Dec 2019 10:10:18 +0100 Olivier Matz <[email protected]> wrote:

Hi,

Quoted 60 lines · Stephen Hemminger
Quoted 57 lines · On Thu, 26 Dec 2019 17:15:39 +0100 Olivier Matz <[email protected]> wrote:

Hi,

Quoted 47 lines · Stephen Hemminger

The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging.

---
v2 - remove casts, change in_port to port
the refcount and offset are property of per-segment

 lib/librte_mbuf/rte_mbuf.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
lib/librte_mbuf/rte_mbuf.c +10 -7
index 35df1c4c38a5..4894d46628e3 100644
@@ -473,18 +473,21 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)
 
 	__rte_mbuf_sanity_check(m, 1);
 
-	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
-	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
-	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u, "
-	       "in_port=%u\n", m->pkt_len, m->ol_flags,
-	       (unsigned)m->nb_segs, (unsigned)m->port);
+	fprintf(f, "dump mbuf at %p, iova=%#"PRIx64", buf_len=%u\n",
+		m, m->buf_iova, m->buf_len);
+	fprintf(f,
+		"  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u, vlan_tci=%#x\n",
+		m->pkt_len, m->ol_flags, m->nb_segs, m->port, m->vlan_tci);
+
 	nb_segs = m->nb_segs;
 
 	while (m && nb_segs != 0) {
 		__rte_mbuf_sanity_check(m, 0);
 
-		fprintf(f, "  segment at %p, data=%p, data_len=%u\n",
-			m, rte_pktmbuf_mtod(m, void *), (unsigned)m->data_len);
+		fprintf(f, "  segment at %p, data=%p, len=%u, off=%u, refcnt=%u\n",
+			m, rte_pktmbuf_mtod(m, void *),
+			m->data_len, m->data_off, rte_mbuf_refcnt_read(m));
+
 		len = dump_len;
 		if (len > m->data_len)
 			len = m->data_len;
Signature · 1 line
2.20.1

Thanks for this enhancement.

One comment however: I don't see why vlan_tci would be important than packet type or rss tag. It is also a bit confusing to display a field which can have a random value (if the vlan flag is not set in ol_flags).

Quoted 5 lines
Quoted 2 lines

I'd prefer to dump vlan_tci only if the flag is present. Later we could add more fields with the same logic. What do you think?

Because this is a debugging hook and easier to always display the value. Thats all.

This is precisely because it is a debug hook that I find dangerous to display a wrong value. As the mbuf are recycled, a mbuf that does not have a vlan_tci can display its previous value, which may look valid.

What about simply doing this?

Quoted 8 lines
	fprintf(f,
		"  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u",
		m->pkt_len, m->ol_flags, m->nb_segs, m->port);
	if (m->ol_flags & PKT_RX_VLAN)
		fprintf(f, ", vlan_tci=%#x", m->vlan_tci);
	fprintf(f, "\n");

If you want I can submit an updated version of your patch

The right flags are more complex, you need to deal with TX vlan. And PKT_RX_VLAN means "this is a vlan packet" it doesn't mean vlan tag is stripped into TCI. That is PKT_RX_VLAN_STRIPPED

#9 lore raw
Quoted 85 lines · Stephen Hemminger
Quoted 82 lines · On Fri, 27 Dec 2019 10:10:18 +0100 Olivier Matz <[email protected]> wrote:

Hi,

Quoted 60 lines · Stephen Hemminger
Quoted 57 lines · On Thu, 26 Dec 2019 17:15:39 +0100 Olivier Matz <[email protected]> wrote:

Hi,

Quoted 47 lines · Stephen Hemminger

The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging.

---
v2 - remove casts, change in_port to port
the refcount and offset are property of per-segment

 lib/librte_mbuf/rte_mbuf.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
lib/librte_mbuf/rte_mbuf.c +10 -7
index 35df1c4c38a5..4894d46628e3 100644
@@ -473,18 +473,21 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)
 
 	__rte_mbuf_sanity_check(m, 1);
 
-	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
-	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
-	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u, "
-	       "in_port=%u\n", m->pkt_len, m->ol_flags,
-	       (unsigned)m->nb_segs, (unsigned)m->port);
+	fprintf(f, "dump mbuf at %p, iova=%#"PRIx64", buf_len=%u\n",
+		m, m->buf_iova, m->buf_len);
+	fprintf(f,
+		"  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u, vlan_tci=%#x\n",
+		m->pkt_len, m->ol_flags, m->nb_segs, m->port, m->vlan_tci);
+
 	nb_segs = m->nb_segs;
 
 	while (m && nb_segs != 0) {
 		__rte_mbuf_sanity_check(m, 0);
 
-		fprintf(f, "  segment at %p, data=%p, data_len=%u\n",
-			m, rte_pktmbuf_mtod(m, void *), (unsigned)m->data_len);
+		fprintf(f, "  segment at %p, data=%p, len=%u, off=%u, refcnt=%u\n",
+			m, rte_pktmbuf_mtod(m, void *),
+			m->data_len, m->data_off, rte_mbuf_refcnt_read(m));
+
 		len = dump_len;
 		if (len > m->data_len)
 			len = m->data_len;
Signature · 1 line
2.20.1

Thanks for this enhancement.

One comment however: I don't see why vlan_tci would be important than packet type or rss tag. It is also a bit confusing to display a field which can have a random value (if the vlan flag is not set in ol_flags).

Quoted 5 lines
Quoted 2 lines

I'd prefer to dump vlan_tci only if the flag is present. Later we could add more fields with the same logic. What do you think?

Because this is a debugging hook and easier to always display the value. Thats all.

This is precisely because it is a debug hook that I find dangerous to display a wrong value. As the mbuf are recycled, a mbuf that does not have a vlan_tci can display its previous value, which may look valid.

What about simply doing this?

	fprintf(f,
		"  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u",
		m->pkt_len, m->ol_flags, m->nb_segs, m->port);
	if (m->ol_flags & PKT_RX_VLAN)
		fprintf(f, ", vlan_tci=%#x", m->vlan_tci);
	fprintf(f, "\n");
Quoted 5 lines
Quoted 1 line

If you want I can submit an updated version of your patch

The right flags are more complex, you need to deal with TX vlan. And PKT_RX_VLAN means "this is a vlan packet" it doesn't mean vlan tag is stripped into TCI. That is PKT_RX_VLAN_STRIPPED

PKT_RX_VLAN means that m->vlan_tci is valid, and this is what we want here.

#10 lore raw

PATCH v3 1/1 mbuf: display more fields in dump

In reply to Stephen Hemminger

The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging.

---
v3 - only display vlan tci if offload flags say it is there
display packet type
v2 - remove casts, change in_port to port
the refcount and offset are property of per-segment

 lib/librte_mbuf/rte_mbuf.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)
lib/librte_mbuf/rte_mbuf.c +14 -7
index 25eea1db259d..56a1a98a6c0c 100644
@@ -675,18 +675,25 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)
 
 	__rte_mbuf_sanity_check(m, 1);
 
-	fprintf(f, "dump mbuf at %p, iova=%"PRIx64", buf_len=%u\n",
-	       m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);
-	fprintf(f, "  pkt_len=%"PRIu32", ol_flags=%"PRIx64", nb_segs=%u, "
-	       "in_port=%u\n", m->pkt_len, m->ol_flags,
-	       (unsigned)m->nb_segs, (unsigned)m->port);
+	fprintf(f, "dump mbuf at %p, iova=%#"PRIx64", buf_len=%u\n",
+		m, m->buf_iova, m->buf_len);
+	fprintf(f, "  pkt_len=%u, ol_flags=%#"PRIx64", nb_segs=%u, port=%u",
+		m->pkt_len, m->ol_flags, m->nb_segs, m->port);
+
+	if (m->ol_flags & (PKT_RX_VLAN | PKT_TX_VLAN))
+		fprintf(f, ", vlan_tci=%u", m->vlan_tci);
+
+	fprintf(f, ", ptype=%#"PRIx32"\n", m->packet_type);
+
 	nb_segs = m->nb_segs;
 
 	while (m && nb_segs != 0) {
 		__rte_mbuf_sanity_check(m, 0);
 
-		fprintf(f, "  segment at %p, data=%p, data_len=%u\n",
-			m, rte_pktmbuf_mtod(m, void *), (unsigned)m->data_len);
+		fprintf(f, "  segment at %p, data=%p, len=%u, off=%u, refcnt=%u\n",
+			m, rte_pktmbuf_mtod(m, void *),
+			m->data_len, m->data_off, rte_mbuf_refcnt_read(m));
+
 		len = dump_len;
 		if (len > m->data_len)
 			len = m->data_len;
Signature · 1 line
2.20.1