drm/i915: Use intel_gt_pm_put_async in GuC submission path
Subsystems (2)
PATCH 1/1 drm/i915: Use intel_gt_pm_put_async in GuC submission path
GuC submission path can be called from an interrupt context and so should use a worker to avoid holding a mutex.
References: 07779a76ee1f ("drm/i915: Mark up the calling context for intel_wakeref_put()")
--- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 -1
@@ -537,7 +537,7 @@ static void schedule_out(struct i915_request *rq) {trace_i915_request_out (rq); -intel_gt_pm_put (rq->engine->gt); +intel_gt_pm_put_async (rq->engine->gt);i915_request_put (rq); }
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Stuart Summers (2019-11-20 21:13:21)
Quoted 2 lines
GuC submission path can be called from an interrupt context and so should use a worker to avoid holding a mutex.
I completely forgot there was still the vestigial GuC submission code... Ah, I was looking more carefully for engine_put in the wrong context.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: Use intel_gt_pm_put_async in GuC submission path
In reply to Stuart Summers== Series Details ==
== Series Details ==
Series: drm/i915: Use intel_gt_pm_put_async in GuC submission path
URL : https://patchwork.freedesktop.org/series/69781/
State : failure
== Summary ==
Applying: drm/i915: Use intel_gt_pm_put_async in GuC submission path Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botThank you for the patch! Yet something to improve:
Hi Stuart,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.4-rc8 next-20191120]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Stuart-Summers/drm-i915-Use-intel_gt_pm_put_async-in-GuC-submission-path/20191121-203257 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-defconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386
If you fix the issue, kindly add following tag
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c: In function 'schedule_out':
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:540:2: error: implicit declaration of function 'intel_gt_pm_put_async'; did you mean 'intel_gt_pm_put'? [-Werror=implicit-function-declaration]
intel_gt_pm_put_async(rq->engine->gt);
^~~~~~~~~~~~~~~~~~~~~
intel_gt_pm_putcc1: some warnings being treated as errors
vim +540 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
535
536 static void schedule_out(struct i915_request *rq)
537 {
538 trace_i915_request_out(rq);
539
> 540 intel_gt_pm_put_async(rq->engine->gt);
541 i915_request_put(rq);
542 }
543
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation