Skip to contentSkip to conversation

drm: mmap fixups

PATCH Superseded Gerd Hoffmann 6 participants 10 messages Nov 22, 2019 – Nov 26, 2019

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover drm: mmap fixups

Tested on qemu, with bochs (vram helpers) and cirrus (shmem helpers). Cc'ing intel-gfx for CI coverage.

Gerd Hoffmann (2):
drm: call drm_gem_object_funcs.mmap with fake offset
drm: share address space for dma bufs

 include/drm/drm_gem.h                       | 4 +---
 drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 +---
 drivers/gpu/drm/drm_gem.c                   | 3 ---
 drivers/gpu/drm/drm_gem_shmem_helper.c      | 3 +++
 drivers/gpu/drm/drm_prime.c                 | 7 ++++++-
 drivers/gpu/drm/ttm/ttm_bo_vm.c             | 7 -------
 6 files changed, 11 insertions(+), 17 deletions(-)
Signature · 6 lines
2.18.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH v2 1/2 drm: call drm_gem_object_funcs.mmap with fake offset

The fake offset is going to stay, so change the calling convention for drm_gem_object_funcs.mmap to include the fake offset. Update all users accordingly.

Note that this reverts 83b8a6f242ea ("drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap") and on top then adds the fake offset to drm_gem_prime_mmap to make sure all paths leading to obj->funcs->mmap are consistent.

Fixes 83b8a6f242ea ("drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap")
Cc Daniel Vetter <[email protected]>
Cc Rob Herring <[email protected]>
---
 include/drm/drm_gem.h                  | 4 +---
 drivers/gpu/drm/drm_gem.c              | 3 ---
 drivers/gpu/drm/drm_gem_shmem_helper.c | 3 +++
 drivers/gpu/drm/drm_prime.c            | 3 +++
 drivers/gpu/drm/ttm/ttm_bo_vm.c        | 7 -------
 5 files changed, 7 insertions(+), 13 deletions(-)
include/drm/drm_gem.h +1 -3
index 97a48165642c..0b375069cd48 100644
@@ -159,9 +159,7 @@ struct drm_gem_object_funcs {
 	 *
 	 * The callback is used by by both drm_gem_mmap_obj() and
 	 * drm_gem_prime_mmap().  When @mmap is present @vm_ops is not
-	 * used, the @mmap callback must set vma->vm_ops instead. The @mmap
-	 * callback is always called with a 0 offset. The caller will remove
-	 * the fake offset as necessary.
+	 * used, the @mmap callback must set vma->vm_ops instead.
 	 */
 	int (*mmap)(struct drm_gem_object *obj, struct vm_area_struct *vma);
 
drivers/gpu/drm/drm_gem.c +0 -3
index 2f2b889096b0..56f42e0f2584 100644
@@ -1106,9 +1106,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
 		return -EINVAL;
 
 	if (obj->funcs && obj->funcs->mmap) {
-		/* Remove the fake offset */
-		vma->vm_pgoff -= drm_vma_node_start(&obj->vma_node);
-
 		ret = obj->funcs->mmap(obj, vma);
 		if (ret)
 			return ret;
drivers/gpu/drm/drm_gem_shmem_helper.c +3 -0
index 0810d3ef6961..a421a2eed48a 100644
@@ -528,6 +528,9 @@ int drm_gem_shmem_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma)
 	struct drm_gem_shmem_object *shmem;
 	int ret;
 
+	/* Remove the fake offset */
+	vma->vm_pgoff -= drm_vma_node_start(&obj->vma_node);
+
 	shmem = to_drm_gem_shmem_obj(obj);
 
 	ret = drm_gem_shmem_get_pages(shmem);
drivers/gpu/drm/drm_prime.c +3 -0
index 0814211b0f3f..a9633bd241bb 100644
@@ -714,6 +714,9 @@ int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma)
 	int ret;
 
 	if (obj->funcs && obj->funcs->mmap) {
+		/* Add the fake offset */
+		vma->vm_pgoff += drm_vma_node_start(&obj->vma_node);
+
 		ret = obj->funcs->mmap(obj, vma);
 		if (ret)
 			return ret;
drivers/gpu/drm/ttm/ttm_bo_vm.c +0 -7
index e6495ca2630b..3e8c3de91ae4 100644
@@ -514,13 +514,6 @@ EXPORT_SYMBOL(ttm_bo_mmap);
 int ttm_bo_mmap_obj(struct vm_area_struct *vma, struct ttm_buffer_object *bo)
 {
 	ttm_bo_get(bo);
-
-	/*
-	 * FIXME: &drm_gem_object_funcs.mmap is called with the fake offset
-	 * removed. Add it back here until the rest of TTM works without it.
-	 */
-	vma->vm_pgoff += drm_vma_node_start(&bo->base.vma_node);
-
 	ttm_bo_mmap_vma_setup(bo, vma);
 	return 0;
 }
Signature · 1 line
2.18.1
#2 lore raw

Re: [PATCH v2 1/2] drm: call drm_gem_object_funcs.mmap with fake offset

Quoted 9 lines · Gerd Hoffmann

The fake offset is going to stay, so change the calling convention for drm_gem_object_funcs.mmap to include the fake offset. Update all users accordingly.

Note that this reverts 83b8a6f242ea ("drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap") and on top then adds the fake offset to drm_gem_prime_mmap to make sure all paths leading to obj->funcs->mmap are consistent.

IOW, v1 of my original fix. :) Though you did it a little differently:

drivers/gpu/drm/drm_prime.c int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma) · line 719

Quoted 11 lines
drivers/gpu/drm/drm_prime.c +3 -0
index 0814211b0f3f..a9633bd241bb 100644
@@ -714,6 +714,9 @@ int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma)
        int ret;
 
        if (obj->funcs && obj->funcs->mmap) {
+               /* Add the fake offset */
+               vma->vm_pgoff += drm_vma_node_start(&obj->vma_node);
+

Can't this be moved out of the if and then the same thing later down removed? Unless there's some requirement that drm_vma_node_allow() be called before drm_vma_node_start() in that case. Doesn't look like it to me, but I'm not really sure.

Quoted 3 lines
drivers/gpu/drm/drm_prime.c +0 -0
                ret = obj->funcs->mmap(obj, vma);
                if (ret)
                        return ret;
#3 lore raw

PATCH v2 2/2 drm: share address space for dma bufs

In reply to Gerd Hoffmann

Use the shared address space of the drm device (see drm_open() in drm_file.c) for dma-bufs too. That removes a difference betweem drm device mmap vmas and dma-buf mmap vmas and fixes corner cases like dropping ptes (using madvise(DONTNEED) for example) not working properly.

Also remove amdgpu driver's private dmabuf update. It is not needed any more now that we are doing this for everybody.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 +---
 drivers/gpu/drm/drm_prime.c                 | 4 +++-
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c +1 -3
index d5bcdfefbad6..586db4fb46bd 100644
@@ -361,10 +361,8 @@ struct dma_buf *amdgpu_gem_prime_export(struct drm_gem_object *gobj,
 		return ERR_PTR(-EPERM);
 
 	buf = drm_gem_prime_export(gobj, flags);
-	if (!IS_ERR(buf)) {
-		buf->file->f_mapping = gobj->dev->anon_inode->i_mapping;
+	if (!IS_ERR(buf))
 		buf->ops = &amdgpu_dmabuf_ops;
-	}
 
 	return buf;
 }
drivers/gpu/drm/drm_prime.c +3 -1
index a9633bd241bb..c3fc341453c0 100644
@@ -240,6 +240,7 @@ void drm_prime_destroy_file_private(struct drm_prime_file_private *prime_fpriv)
 struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev,
 				      struct dma_buf_export_info *exp_info)
 {
+	struct drm_gem_object *obj = exp_info->priv;
 	struct dma_buf *dma_buf;
 
 	dma_buf = dma_buf_export(exp_info);
@@ -247,7 +248,8 @@ struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev,
 		return dma_buf;
 
 	drm_dev_get(dev);
-	drm_gem_object_get(exp_info->priv);
+	drm_gem_object_get(obj);
+	dma_buf->file->f_mapping = obj->dev->anon_inode->i_mapping;
 
 	return dma_buf;
 }
Signature · 1 line
2.18.1
Reviewed-by on v2 2/2
#4 lore raw

Re: [PATCH v2 2/2] drm: share address space for dma bufs

Quoted 11 lines · Gerd Hoffmann

Use the shared address space of the drm device (see drm_open() in drm_file.c) for dma-bufs too. That removes a difference betweem drm device mmap vmas and dma-buf mmap vmas and fixes corner cases like dropping ptes (using madvise(DONTNEED) for example) not working properly.

Also remove amdgpu driver's private dmabuf update. It is not needed any more now that we are doing this for everybody.

But I think you want at least an ack from amd guys for double checking here. -Daniel

Quoted 46 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 +---
 drivers/gpu/drm/drm_prime.c                 | 4 +++-
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c +1 -3
index d5bcdfefbad6..586db4fb46bd 100644
@@ -361,10 +361,8 @@ struct dma_buf *amdgpu_gem_prime_export(struct drm_gem_object *gobj,
                return ERR_PTR(-EPERM);
 
        buf = drm_gem_prime_export(gobj, flags);
-       if (!IS_ERR(buf)) {
-               buf->file->f_mapping = gobj->dev->anon_inode->i_mapping;
+       if (!IS_ERR(buf))
                buf->ops = &amdgpu_dmabuf_ops;
-       }
 
        return buf;
 }
drivers/gpu/drm/drm_prime.c +3 -2
index a9633bd241bb..c3fc341453c0 100644
@@ -240,6 +240,7 @@ void drm_prime_destroy_file_private(struct drm_prime_file_private *prime_fpriv)
 struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev,
                                      struct dma_buf_export_info *exp_info)
 {
+       struct drm_gem_object *obj = exp_info->priv;
        struct dma_buf *dma_buf;
 
        dma_buf = dma_buf_export(exp_info);
@@ -247,7 +248,8 @@ struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev,
                return dma_buf;
 
        drm_dev_get(dev);
-       drm_gem_object_get(exp_info->priv);
+       drm_gem_object_get(obj);
+       dma_buf->file->f_mapping = obj->dev->anon_inode->i_mapping;
 
        return dma_buf;
 }
--

2.18.1

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
Reviewed-by
#5 lore raw

Re: [PATCH v2 2/2] drm: share address space for dma bufs

Quoted 12 lines · Daniel Vetter
Quoted 10 lines · Gerd Hoffmann

Use the shared address space of the drm device (see drm_open() in drm_file.c) for dma-bufs too. That removes a difference betweem drm device mmap vmas and dma-buf mmap vmas and fixes corner cases like dropping ptes (using madvise(DONTNEED) for example) not working properly.

Also remove amdgpu driver's private dmabuf update. It is not needed any more now that we are doing this for everybody.

Quoted 6 lines
Quoted 1 line

But I think you want at least an ack from amd guys for double checking here. -Daniel

Looks correct to me.

Quoted 41 lines
Quoted 41 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 +---
 drivers/gpu/drm/drm_prime.c                 | 4 +++-
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c +1 -3
index d5bcdfefbad6..586db4fb46bd 100644
@@ -361,10 +361,8 @@ struct dma_buf *amdgpu_gem_prime_export(struct drm_gem_object *gobj,
                return ERR_PTR(-EPERM);
 
        buf = drm_gem_prime_export(gobj, flags);
-       if (!IS_ERR(buf)) {
-               buf->file->f_mapping = gobj->dev->anon_inode->i_mapping;
+       if (!IS_ERR(buf))
                buf->ops = &amdgpu_dmabuf_ops;
-       }
 
        return buf;
 }
drivers/gpu/drm/drm_prime.c +3 -1
index a9633bd241bb..c3fc341453c0 100644
@@ -240,6 +240,7 @@ void drm_prime_destroy_file_private(struct drm_prime_file_private *prime_fpriv)
 struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev,
                                      struct dma_buf_export_info *exp_info)
 {
+       struct drm_gem_object *obj = exp_info->priv;
        struct dma_buf *dma_buf;
 
        dma_buf = dma_buf_export(exp_info);
@@ -247,7 +248,8 @@ struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev,
                return dma_buf;
 
        drm_dev_get(dev);
-       drm_gem_object_get(exp_info->priv);
+       drm_gem_object_get(obj);
+       dma_buf->file->f_mapping = obj->dev->anon_inode->i_mapping;
 
Quoted 15 lines
Quoted 5 lines
drivers/gpu/drm/drm_prime.c +0 -1
        return dma_buf;
 }
--

2.18.1

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#6 lore raw

Re: [PATCH v2 2/2] drm: share address space for dma bufs

Am 22.11.19 um 19:21 schrieb Alex Deucher:

Quoted 11 lines · Daniel Vetter
Quoted 10 lines · Gerd Hoffmann
Quoted 9 lines

Use the shared address space of the drm device (see drm_open() in drm_file.c) for dma-bufs too. That removes a difference betweem drm device mmap vmas and dma-buf mmap vmas and fixes corner cases like dropping ptes (using madvise(DONTNEED) for example) not working properly.

Also remove amdgpu driver's private dmabuf update. It is not needed any more now that we are doing this for everybody.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

But I think you want at least an ack from amd guys for double checking here. -Daniel

Looks correct to me.

Quoted 61 lines
Quoted 43 lines
Quoted 43 lines

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 +---
  drivers/gpu/drm/drm_prime.c                 | 4 +++-
  2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c +1 -3
index d5bcdfefbad6..586db4fb46bd 100644
@@ -361,10 +361,8 @@ struct dma_buf *amdgpu_gem_prime_export(struct drm_gem_object *gobj,
                 return ERR_PTR(-EPERM);
 
         buf = drm_gem_prime_export(gobj, flags);
-       if (!IS_ERR(buf)) {
-               buf->file->f_mapping = gobj->dev->anon_inode->i_mapping;
+       if (!IS_ERR(buf))
                 buf->ops = &amdgpu_dmabuf_ops;
-       }
 
         return buf;
  }
drivers/gpu/drm/drm_prime.c +3 -1
index a9633bd241bb..c3fc341453c0 100644
@@ -240,6 +240,7 @@ void drm_prime_destroy_file_private(struct drm_prime_file_private *prime_fpriv)
  struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev,
                                       struct dma_buf_export_info *exp_info)
  {
+       struct drm_gem_object *obj = exp_info->priv;
         struct dma_buf *dma_buf;
 
         dma_buf = dma_buf_export(exp_info);
@@ -247,7 +248,8 @@ struct dma_buf *drm_gem_dmabuf_export(struct drm_device *dev,
                 return dma_buf;
 
         drm_dev_get(dev);
-       drm_gem_object_get(exp_info->priv);
+       drm_gem_object_get(obj);
+       dma_buf->file->f_mapping = obj->dev->anon_inode->i_mapping;
 
Quoted 14 lines
Quoted 5 lines
drivers/gpu/drm/drm_prime.c +0 -1
         return dma_buf;
  }
--

2.18.1

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#7 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm: mmap fixups (rev2)

In reply to Gerd Hoffmann
== Series Details ==

== Series Details ==

Series: drm: mmap fixups (rev2)
URL : https://patchwork.freedesktop.org/series/69820/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d9012f9c233a drm: call drm_gem_object_funcs.mmap with fake offset
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 83b8a6f242ea ("drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap")'
#10: 
Note that this reverts 83b8a6f242ea ("drm/gem: Fix mmap fake offset

total: 1 errors, 0 warnings, 0 checks, 50 lines checked 6e7b4a87a8cf drm: share address space for dma bufs

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

✓ Fi.CI.BAT: success for drm: mmap fixups (rev2)

In reply to Gerd Hoffmann
== Series Details ==

== Series Details ==

Series: drm: mmap fixups (rev2)
URL : https://patchwork.freedesktop.org/series/69820/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7402 -> Patchwork_15388
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/index.html

Known issues
------------

Here are the changes found in Patchwork_15388 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_busy@basic-flip-pipe-c:
- fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/fi-bxt-dsi/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/fi-bxt-dsi/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms:
- fi-skl-6770hq: [PASS][3] -> [SKIP][4] ([fdo#109271]) +26 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/fi-skl-6770hq/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/fi-skl-6770hq/igt@[email protected]

#### Possible fixes ####

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [FAIL][5] ([fdo#103167]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/fi-icl-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/fi-icl-u2/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [SKIP][7] ([fdo#109271]) -> [FAIL][8] ([fdo#110829])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/fi-kbl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/fi-kbl-guc/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#110829]: https://bugs.freedesktop.org/show_bug.cgi?id=110829

Participating hosts (50 -> 44)
------------------------------

Additional (1): fi-bsw-n3050
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7402 -> Patchwork_15388

CI-20190529: 20190529
CI_DRM_7402: d5f0845c4b92c5826d63b76f89866492e0935c1b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5299: 65fed6a79adea14f7bef6d55530da47d7731d370 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15388: 6e7b4a87a8cf0aca9f5c43e71b57255302a71dfd @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

6e7b4a87a8cf drm: share address space for dma bufs d9012f9c233a drm: call drm_gem_object_funcs.mmap with fake offset

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

✓ Fi.CI.IGT: success for drm: mmap fixups (rev2)

In reply to Gerd Hoffmann
== Series Details ==

== Series Details ==

Series: drm: mmap fixups (rev2)
URL : https://patchwork.freedesktop.org/series/69820/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7402_full -> Patchwork_15388_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_15388_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276] / [fdo#112080]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb3/igt@[email protected]

* igt@gem_eio@reset-stress:
- shard-snb: [PASS][3] -> [FAIL][4] ([fdo#109661])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-snb1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-snb2/igt@[email protected]

* igt@gem_exec_reloc@basic-wc-read-active:
- shard-skl: [PASS][5] -> [DMESG-WARN][6] ([fdo#106107])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-skl9/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-skl1/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-contexts-chain-render:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([fdo#111677])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb6/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb5/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb1/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-snb6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-snb4/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-hsw4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-hsw6/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#111830 ])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb8/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb6/igt@[email protected]

* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-skl: [PASS][17] -> [INCOMPLETE][18] ([fdo#104108] / [fdo#112347])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-skl6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-skl1/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [PASS][19] -> [FAIL][20] ([fdo#105363])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-glk5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-glk1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#103167]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111832] / [fdo#111850]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb3/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([fdo#108566]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-apl3/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-apl1/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb3/igt@kms_psr@psr2_primary_mmap_gtt.html

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([fdo#108566]) +7 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-kbl1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-kbl1/igt@[email protected]

* igt@kms_vblank@pipe-d-ts-continuation-suspend:
- shard-tglb: [PASS][31] -> [INCOMPLETE][32] ([fdo#111850])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb9/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb3/igt@[email protected]

* igt@perf_pmu@busy-vcs1:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#112080]) +9 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb6/igt@[email protected]

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109276]) +18 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb5/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][37] ([fdo#108566]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-kbl3/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-kbl2/igt@[email protected]

* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][39] ([fdo#109276] / [fdo#112080]) -> [PASS][40] +4 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb8/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb4/igt@[email protected]

* igt@gem_ctx_switch@vcs1-heavy-queue:
- shard-iclb: [SKIP][41] ([fdo#112080]) -> [PASS][42] +12 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb5/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@fifo-bsd1:
- shard-iclb: [SKIP][43] ([fdo#109276]) -> [PASS][44] +19 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb5/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][45] ([fdo#112146]) -> [PASS][46] +7 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb3/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [INCOMPLETE][47] ([fdo#111736] / [fdo#111850]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb3/igt@[email protected]
- shard-apl: [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-apl4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-apl6/igt@[email protected]

* igt@gem_pipe_control_store_loop@reused-buffer:
- shard-tglb: [INCOMPLETE][51] ([fdo#111998]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb3/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [DMESG-WARN][53] ([fdo#111870]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-snb5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-snb4/igt@[email protected]

* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-glk: [FAIL][55] ([fdo#104873]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-glk4/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-glk4/igt@[email protected]

* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- shard-skl: [DMESG-WARN][57] ([fdo#105541]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-skl5/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-skl10/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled:
- shard-skl: [FAIL][59] ([fdo#103184] / [fdo#103232] / [fdo#108472]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-skl4/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-skl3/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-ytiled:
- shard-skl: [FAIL][61] ([fdo#103184] / [fdo#103232] / [fdo#108145]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-skl4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-skl3/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][63] ([fdo#105363]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-skl9/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-skl4/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-iclb: [INCOMPLETE][65] ([fdo#107713] / [fdo#109507]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb3/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][67] ([fdo#103167]) -> [PASS][68] +7 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-tglb: [FAIL][69] ([fdo#103167]) -> [PASS][70] +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb3/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb6/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
- shard-skl: [FAIL][71] ([fdo#103167]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-skl1/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-skl3/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-snb: [INCOMPLETE][73] ([fdo#105411]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-snb5/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-snb4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][75] ([fdo#108145] / [fdo#110403]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-skl3/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-skl7/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][77] ([fdo#109642] / [fdo#111068]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb1/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][79] ([fdo#109441]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb2/igt@kms_psr@psr2_no_drrs.html

* igt@kms_psr@suspend:
- shard-tglb: [INCOMPLETE][81] ([fdo#111832] / [fdo#111850]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb2/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb1/igt@[email protected]

* igt@kms_setmode@basic:
- shard-hsw: [FAIL][83] ([fdo#99912]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-hsw1/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-hsw7/igt@[email protected]

* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][85] ([fdo#111850]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb8/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb8/igt@[email protected]

* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-skl: [INCOMPLETE][87] ([fdo#111747]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-skl10/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-skl8/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][89] ([fdo#111329]) -> [SKIP][90] ([fdo#109276] / [fdo#112080])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb2/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-iclb5/igt@[email protected]

* igt@gem_ctx_isolation@vcs2-clean:
- shard-tglb: [SKIP][91] ([fdo#111912] / [fdo#112080]) -> [SKIP][92] ([fdo#112080])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb1/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb9/igt@[email protected]

* igt@gem_eio@kms:
- shard-snb: [DMESG-WARN][93] ([fdo# 112000 ] / [fdo#111780 ] / [fdo#111781]) -> [INCOMPLETE][94] ([fdo#105411])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-snb2/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-snb1/igt@[email protected]

* igt@gem_exec_schedule@deep-bsd1:
- shard-tglb: [FAIL][95] ([fdo#111646]) -> [INCOMPLETE][96] ([fdo#111671])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb1/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb9/igt@[email protected]

* igt@gem_exec_schedule@deep-vebox:
- shard-tglb: [INCOMPLETE][97] ([fdo#111671]) -> [FAIL][98] ([fdo#111646])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb5/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-tglb1/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][99] ([fdo#108566]) -> [DMESG-WARN][100] ([fdo#103313])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-kbl3/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/shard-kbl2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo# 112000 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 112000 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15388/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx