Skip to contentSkip to conversation

bluetooth: bcm: Use the BDADDR_PROPERTY quirk

PATCH In review Andre Heider 2 participants 3 messages Nov 22, 2019 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 bluetooth: bcm: Use the BDADDR_PROPERTY quirk

Some devices ship with the controller default address, like the Orange Pi 3 (BCM4345C5).

Allow the bootloader to set a valid address through the device tree.

---
 drivers/bluetooth/btbcm.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/bluetooth/btbcm.c +5 -0
index 2d2e6d862068..c5c12ba880d9 100644
@@ -440,6 +440,11 @@ int btbcm_finalize(struct hci_dev *hdev)
 
 	set_bit(HCI_QUIRK_STRICT_DUPLICATE_FILTER, &hdev->quirks);
 
+	/* Some devices ship with the controller default address.
+	 * Allow the bootloader to set a valid address through the device tree.
+	 */
+	set_bit(HCI_QUIRK_USE_BDADDR_PROPERTY, &hdev->quirks);
+
 	return 0;
 }
 EXPORT_SYMBOL_GPL(btbcm_finalize);
Signature · 1 line
2.24.0
maintainer
#1 lore raw

Hi Andre,

Quoted 9 lines

Some devices ship with the controller default address, like the Orange Pi 3 (BCM4345C5).

Allow the bootloader to set a valid address through the device tree.

---
drivers/bluetooth/btbcm.c | 5 +++++

1 file changed, 5 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel

#2 lore raw
Quoted 5 lines · Marcel Holtmann

Hi Andre,

Quoted 3 lines

Some devices ship with the controller default address, like the Orange Pi 3 (BCM4345C5).

Quoted 8 lines
Quoted 6 lines

Allow the bootloader to set a valid address through the device tree.

---
drivers/bluetooth/btbcm.c | 5 +++++

1 file changed, 5 insertions(+)

patch has been applied to bluetooth-next tree.

Nice, thank you!
Andre