Skip to contentSkip to conversation

ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs

PATCH New Takashi Iwai 1 participant 1 message Nov 22, 2019 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs

The old Nvidia chips have multiple HD-audio codecs on the same HD-audio controller, and this doesn't work as expected with the current audio component binding that is implemented under the one-codec-per- controller assumption; at the probe time, the driver leads to several kernel WARNING messages.

For the proper support, we may change the pin2port and port2pin to traverse the codec list per the given pin number, but this needs more development and testing.

As a quick workaround, instead, this patch drops the binding in the audio side for these legacy chips since the audio component support in nouveau graphics driver is still not merged (hence it's basically unused).

Fixes ade49db337a9 ("ALSA: hda/hdmi - Allow audio component for AMD/ATI and Nvidia HDMI")
---
 sound/pci/hda/patch_hdmi.c | 2 --
 1 file changed, 2 deletions(-)
sound/pci/hda/patch_hdmi.c +0 -2
index 55d20e40a195..9063bf88689f 100644
@@ -3574,8 +3574,6 @@ static int patch_nvhdmi_legacy(struct hda_codec *codec)
 
 	codec->link_down_at_suspend = 1;
 
-	generic_acomp_init(codec, &nvhdmi_audio_ops, nvhdmi_port2pin);
-
 	return 0;
 }
 
Signature · 6 lines
2.16.4

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel