Skip to contentSkip to conversation

dtc: checks: check_graph_port: skip node name check in overlay case

PATCH In review Benoit Parrot 1 participant 2 messages Nov 22, 2019 – Dec 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dtc: checks: check_graph_port: skip node name check in overlay case

In check_graph_port() we need to skip the node name check in the overlay case as it causes a false positive warning.

---
 checks.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
checks.c +2 -1
index 756f0fa9203f..6b6712da146a 100644
@@ -1707,7 +1707,8 @@ static void check_graph_port(struct check *c, struct dt_info *dti,
 	if (node->bus != &graph_port_bus)
 		return;
 
-	if (!strprefixeq(node->name, node->basenamelen, "port"))
+	if (!strprefixeq(node->name, node->basenamelen, "port") &&
+	    !(dti->dtsflags & DTSF_PLUGIN))
 		FAIL(c, dti, node, "graph port node name should be 'port'");
 
 	check_graph_reg(c, dti, node);
Signature · 1 line
2.17.1
#1 lore raw

Ping!

Benoit Parrot <[email protected]> wrote on Fri [2019-Nov-22 13:16:31 -0600]:

Quoted 22 lines

In check_graph_port() we need to skip the node name check in the overlay case as it causes a false positive warning.

---
 checks.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
checks.c +2 -1
index 756f0fa9203f..6b6712da146a 100644
@@ -1707,7 +1707,8 @@ static void check_graph_port(struct check *c, struct dt_info *dti,
 	if (node->bus != &graph_port_bus)
 		return;
 
-	if (!strprefixeq(node->name, node->basenamelen, "port"))
+	if (!strprefixeq(node->name, node->basenamelen, "port") &&
+	    !(dti->dtsflags & DTSF_PLUGIN))
 		FAIL(c, dti, node, "graph port node name should be 'port'");
 
 	check_graph_reg(c, dti, node);