build: fix windows build failure for 19.11
PATCH 1/1 build: fix windows build failure for 19.11
This patch fixes Windows build failure caused due to 'config: change ABI versioning to global' patch. This patch can be merged in 19.11 release.
--- config/meson.build | 2 +- meson.build | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)
config/meson.build +1 -1
@@ -19,7 +19,7 @@ endforeach pver = meson.project_version().split('.') major_version = '@0@.@1@'.format(pver.get(0), pver.get(1)) abi_version = run_command(find_program('cat', 'more'), - files('../ABI_VERSION')).stdout().strip() + abi_version_file).stdout().strip() # experimental libraries are versioned as 0.majorminor versions, e.g. 0.201 ever = abi_version.split('.') experimental_abi_version = '0.@0@@1@'.format(ever.get(0), ever.get(1))
meson.build +1 -0
@@ -22,6 +22,7 @@ dpdk_extra_ldflags = [] dpdk_app_link_libraries = [] dpdk_libs_disabled = [] dpdk_drvs_disabled = [] +abi_version_file = files('ABI_VERSION') # configure the build, and make sure configs here and in config folder are # able to be included in any file. We also store a global array of include dirs
Signature · 1 line
2.18.0.windows.1
Quoted 2 lines · Pallavi Kadam
This patch fixes Windows build failure caused due to 'config: change ABI versioning to global' patch.
Underlying reason is:
"While most windows apps can handle both "\" and "/" as path separators, "more" is treating the "/" as the start of a command-line flag in this case, causing errors.
Quoted 6 lines
This patch can be merged in 19.11 release.
Signed-off-by Bruce Richardson <[email protected]>Reviewed-by Ranjit Menon <[email protected]>Tested-by Pallavi Kadam <[email protected]>---
Quoted 8 lines · Pallavi Kadam
This patch fixes Windows build failure caused due to 'config: change ABI versioning to global' patch. This patch can be merged in 19.11 release.
Signed-off-by Bruce Richardson <[email protected]>Reviewed-by Ranjit Menon <[email protected]>Tested-by Pallavi Kadam <[email protected]>---
Missing Fixes: tag
Signature · 2 lines
Thanks, Anatoly
Quoted 6 lines · Anatoly
Quoted 4 lines · Pallavi Kadam
This patch fixes Windows build failure caused due to 'config: change ABI versioning to global' patch. This patch can be merged in 19.11 release.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Bruce Richardson <[email protected]>Reviewed-by Ranjit Menon <[email protected]>Tested-by Pallavi Kadam <[email protected]>---
Missing Fixes: tag
Acked-by Anatoly Burakov <[email protected]>
Who is the author of this patch?
If Pallavi authored it, we are missing a sob.
Can you just clarify this?
Then I can fix the commitlog and apply this patch.
Signature · 1 line
David Marchand
Confirmed author with Bruce offlist.
Applied with commitlog proposed by Bruce:
While most windows apps can handle both "\" and "/" as path separators, "more" is treating the "/" as the start of a command-line flag in this case, causing errors.
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
Signed-off-by Bruce Richardson <[email protected]>Reviewed-by Ranjit Menon <[email protected]>Tested-by Pallavi Kadam <[email protected]>Acked-by Anatoly Burakov <[email protected]>
Thanks.
--
David Marchand