drm/i915: Remove tautological compare in eb_relocate_vma
Subsystems (2)
PATCH 1/1 drm/i915: Remove tautological compare in eb_relocate_vma
-Wtautological-compare was recently added to -Wall in LLVM, which exposed an if statement in i915 that is always false:
../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
result of comparison of constant 576460752303423487 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
if (unlikely(remain > N_RELOC(ULONG_MAX)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
Since remain is an unsigned int, it can never be larger than UINT_MAX, which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry). Remove this statement to fix the warning.
---
NOTE: Another possible fix for this is to change ULONG_MAX to UINT_MAX
but I am not sure that is what was intended by this check. I'm happy to respin if that is the case.
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +0 -2
@@ -1482,8 +1482,6 @@ static int eb_relocate_vma(struct i915_execbuffer *eb, struct i915_vma *vma) urelocs =u64_to_user_ptr (entry->relocs_ptr); remain = entry->relocation_count; -if (unlikely (remain >N_RELOC (ULONG_MAX ))) -return -EINVAL ;/* * We must check that the entire relocation array is safe
Signature · 6 lines
2.24.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Nathan Chancellor (2019-11-23 19:53:22)
Quoted 10 lines
-Wtautological-compare was recently added to -Wall in LLVM, which exposed an if statement in i915 that is always false:
../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
result of comparison of constant 576460752303423487 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
if (unlikely(remain > N_RELOC(ULONG_MAX)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
Quoted 3 lines
Since remain is an unsigned int, it can never be larger than
UINT_MAX, which is less thanULONG_MAX/sizeof(struct drm_i915_gem_relocation_entry). Remove this statement to fix the warning.
The check should remain as we do want to document the overflow calculation, and it should represent the types used -- it's much easier to review a stub than trying to find a missing overflow check. If the overflow cannot happen as the types are wide enough, no problem, the compiler can remove the known false branch.
Tautology here has a purpose for conveying information to the reader. -Chris
Quoted 12 lines · Chris Wilson
Quoting Nathan Chancellor (2019-11-23 19:53:22)
Quoted 10 lines
-Wtautological-compare was recently added to -Wall in LLVM, which exposed an if statement in i915 that is always false:
../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
result of comparison of constant 576460752303423487 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
if (unlikely(remain > N_RELOC(ULONG_MAX)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
Quoted 6 lines
Quoted 3 lines
Since remain is an unsigned int, it can never be larger than
UINT_MAX, which is less thanULONG_MAX/sizeof(struct drm_i915_gem_relocation_entry). Remove this statement to fix the warning.The check should remain as we do want to document the overflow calculation, and it should represent the types used -- it's much easier
What do you mean "represent the types used?" Are you concerned that the type of drm_i915_gem_exec_object2->relocation_count might change in the future?
Quoted 3 lines
to review a stub than trying to find a missing overflow check. If the overflow cannot happen as the types are wide enough, no problem, the compiler can remove the known false branch.
What overflow are you trying to protect against here?
Quoted 2 lines
Tautology here has a purpose for conveying information to the reader.
Well leaving a warning unaddressed is also not a solution. Either replace it with a comment or turn off the warning for your subdir.
The warning here looks valid to me; you have a guard for something that's impossible.
Signature · 6 lines
Thanks, ~Nick Desaulniers _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Nick Desaulniers (2019-12-02 19:18:20)
Quoted 17 lines · Chris Wilson
Quoted 16 lines
Quoting Nathan Chancellor (2019-11-23 19:53:22)
Quoted 13 lines
-Wtautological-compare was recently added to -Wall in LLVM, which exposed an if statement in i915 that is always false:
../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
result of comparison of constant 576460752303423487 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
if (unlikely(remain > N_RELOC(ULONG_MAX)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~Since remain is an unsigned int, it can never be larger than
UINT_MAX, which is less thanULONG_MAX/sizeof(struct drm_i915_gem_relocation_entry). Remove this statement to fix the warning.
Quoted 6 lines
Quoted 2 lines
The check should remain as we do want to document the overflow calculation, and it should represent the types used -- it's much easier
What do you mean "represent the types used?" Are you concerned that the type of
drm_i915_gem_exec_object2->relocation_countmight change in the future?
We may want to change the restriction, yes.
Quoted 5 lines
Quoted 3 lines
to review a stub than trying to find a missing overflow check. If the overflow cannot happen as the types are wide enough, no problem, the compiler can remove the known false branch.
What overflow are you trying to protect against here?
These values are under user control, our validation steps should be clear and easy to check. If we have the types wrong, if the checks are wrong, we need to fix them. If the code is removed because it can be evaluated by the compiler to be redundant, it is much harder for us to verify that we have tried to validate user input.
Quoted 4 lines
Quoted 1 line
Tautology here has a purpose for conveying information to the reader.
Well leaving a warning unaddressed is also not a solution. Either replace it with a comment or turn off the warning for your subdir.
My personal preference would be to use a bunch of central macros for the various type/kmalloc overflows, and have the warnings suppressed there since they are very much about documenting user input validation. -Chris
Quoted 42 lines · Chris Wilson
Quoting Nick Desaulniers (2019-12-02 19:18:20)
Quoted 17 lines · Chris Wilson
Quoted 16 lines
Quoting Nathan Chancellor (2019-11-23 19:53:22)
Quoted 13 lines
-Wtautological-compare was recently added to -Wall in LLVM, which exposed an if statement in i915 that is always false:
../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
result of comparison of constant 576460752303423487 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
if (unlikely(remain > N_RELOC(ULONG_MAX)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~Since remain is an unsigned int, it can never be larger than
UINT_MAX, which is less thanULONG_MAX/sizeof(struct drm_i915_gem_relocation_entry). Remove this statement to fix the warning.Quoted 6 lines
Quoted 2 lines
The check should remain as we do want to document the overflow calculation, and it should represent the types used -- it's much easier
What do you mean "represent the types used?" Are you concerned that the type of
drm_i915_gem_exec_object2->relocation_countmight change in the future?We may want to change the restriction, yes.
Quoted 5 lines
Quoted 3 lines
to review a stub than trying to find a missing overflow check. If the overflow cannot happen as the types are wide enough, no problem, the compiler can remove the known false branch.
What overflow are you trying to protect against here?
These values are under user control, our validation steps should be clear and easy to check. If we have the types wrong, if the checks are wrong, we need to fix them. If the code is removed because it can be evaluated by the compiler to be redundant, it is much harder for us to verify that we have tried to validate user input.
Quoted 2 lines
Quoted 1 line
Tautology here has a purpose for conveying information to the reader.
Quoted 7 lines
Quoted 2 lines
Well leaving a warning unaddressed is also not a solution. Either replace it with a comment or turn off the warning for your subdir.
My personal preference would be to use a bunch of central macros for the various type/kmalloc overflows, and have the warnings suppressed there since they are very much about documenting user input validation. -Chris
Is kmalloc_array what you're looking for? Looks like it has the check_mul_overflow call in it.
Signature · 6 lines
Thanks, ~Nick Desaulniers _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 46 lines · Nick Desaulniers
Quoted 45 lines · Chris Wilson
Quoting Nick Desaulniers (2019-12-02 19:18:20)
Quoted 17 lines · Chris Wilson
Quoted 16 lines
Quoting Nathan Chancellor (2019-11-23 19:53:22)
Quoted 13 lines
-Wtautological-compare was recently added to -Wall in LLVM, which exposed an if statement in i915 that is always false:
../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
result of comparison of constant 576460752303423487 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
if (unlikely(remain > N_RELOC(ULONG_MAX)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~Since remain is an unsigned int, it can never be larger than
UINT_MAX, which is less thanULONG_MAX/sizeof(struct drm_i915_gem_relocation_entry). Remove this statement to fix the warning.Quoted 6 lines
Quoted 2 lines
The check should remain as we do want to document the overflow calculation, and it should represent the types used -- it's much easier
What do you mean "represent the types used?" Are you concerned that the type of
drm_i915_gem_exec_object2->relocation_countmight change in the future?We may want to change the restriction, yes.
Quoted 5 lines
Quoted 3 lines
to review a stub than trying to find a missing overflow check. If the overflow cannot happen as the types are wide enough, no problem, the compiler can remove the known false branch.
What overflow are you trying to protect against here?
These values are under user control, our validation steps should be clear and easy to check. If we have the types wrong, if the checks are wrong, we need to fix them. If the code is removed because it can be evaluated by the compiler to be redundant, it is much harder for us to verify that we have tried to validate user input.
Quoted 4 lines
Quoted 1 line
Tautology here has a purpose for conveying information to the reader.
Well leaving a warning unaddressed is also not a solution. Either replace it with a comment or turn off the warning for your subdir.
Quoted 7 lines
Quoted 4 lines
My personal preference would be to use a bunch of central macros for the various type/kmalloc overflows, and have the warnings suppressed there since they are very much about documenting user input validation. -Chris
Is
kmalloc_arraywhat you're looking for? Looks like it has thecheck_mul_overflowcall in it.
I don't think kmalloc_array is right because we are not validating an allocation. I am not sure that any of these overflow macros are correct, we would probably need something new but I am not sure.
Cheers,
Nathan
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove tautological compare in eb_relocate_vma
In reply to Nathan Chancellor== Series Details ==
== Series Details ==
Series: drm/i915: Remove tautological compare in eb_relocate_vma
URL : https://patchwork.freedesktop.org/series/69934/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 95b9c28d83b0 drm/i915: Remove tautological compare in eb_relocate_vma -:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #17: which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Remove tautological compare in eb_relocate_vma
In reply to Nathan Chancellor== Series Details ==
== Series Details ==
Series: drm/i915: Remove tautological compare in eb_relocate_vma
URL : https://patchwork.freedesktop.org/series/69934/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7410 -> Patchwork_15410
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/index.html
Known issues
------------
Here are the changes found in Patchwork_15410 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-6770hq: [PASS][1] -> [DMESG-WARN][2] ([fdo#105541])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-skl-6770hq/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-skl-6770hq/igt@[email protected]
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-nick: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@i915_module_load@reload-with-fault-injection:
- {fi-kbl-7560u}: [INCOMPLETE][5] ([fdo#109964] / [fdo#112298]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-kbl-7560u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-kbl-7560u/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][7] ([fdo#108511]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-skl-6770hq/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-skl-6770hq/igt@[email protected]
* igt@i915_selftest@live_execlists:
- fi-bxt-dsi: [TIMEOUT][9] ([fdo#112067]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-icl-dsi: [DMESG-WARN][11] ([fdo#106107]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-icl-dsi/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-icl-dsi/igt@[email protected]
#### Warnings ####
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][13] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-kbl-x1275/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-kbl-x1275/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][15] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][16] ([fdo#103558] / [fdo#105602]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-kbl-x1275/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#112067]: https://bugs.freedesktop.org/show_bug.cgi?id=112067
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (46 -> 39)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7410 -> Patchwork_15410
CI-20190529: 20190529
CI_DRM_7410: da8ac60ce6345f32bd821093a86d3f11b30942f1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5303: 360b11e511d98b6370134cff6e8ec3c434a65aee @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15410: 95b9c28d83b024c637b2022013342a7be1744a58 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
95b9c28d83b0 drm/i915: Remove tautological compare in eb_relocate_vma
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Remove tautological compare in eb_relocate_vma
In reply to Nathan Chancellor== Series Details ==
== Series Details ==
Series: drm/i915: Remove tautological compare in eb_relocate_vma
URL : https://patchwork.freedesktop.org/series/69934/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7410_full -> Patchwork_15410_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15410_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276] / [fdo#112080]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb5/igt@[email protected]
* igt@gem_eio@suspend:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4] ([fdo#111850])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb2/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-glk: [PASS][5] -> [FAIL][6] ([fdo#109661])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-glk5/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-glk7/igt@[email protected]
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +12 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@[email protected]
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [PASS][9] -> [TIMEOUT][10] ([fdo#112068 ])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb8/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb1/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111832] / [fdo#111850]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb4/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: [PASS][15] -> [SKIP][16] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb6/igt@[email protected]
* igt@i915_pm_rpm@system-suspend:
- shard-skl: [PASS][17] -> [INCOMPLETE][18] ([fdo#104108] / [fdo#107807])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl2/igt@[email protected]
* igt@i915_selftest@live_hangcheck:
- shard-snb: [PASS][19] -> [INCOMPLETE][20] ([fdo#105411])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb7/igt@i915_selftest@live_hangcheck.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb7/igt@i915_selftest@live_hangcheck.html
* igt@i915_selftest@live_perf:
- shard-hsw: [PASS][21] -> [INCOMPLETE][22] ([fdo#103540])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-hsw5/igt@i915_selftest@live_perf.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-hsw2/igt@i915_selftest@live_perf.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-apl: [PASS][23] -> [FAIL][24] ([fdo#105363])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-apl2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-apl8/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][25] -> [INCOMPLETE][26] ([fdo#109507])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl9/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl9/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([fdo#108566]) +5 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@[email protected]
- shard-tglb: [PASS][31] -> [INCOMPLETE][32] ([fdo#111832] / [fdo#111850] / [fdo#111884])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb7/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb3/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#103167])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: [PASS][37] -> [INCOMPLETE][38] ([fdo#104108])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl8/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl9/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][41] -> [DMESG-WARN][42] ([fdo#108566]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-apl2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-apl6/igt@[email protected]
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-skl: [PASS][43] -> [TIMEOUT][44] ([fdo#111732 ])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl7/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl5/igt@[email protected]
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#112080]) +11 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb4/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb5/igt@[email protected]
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109276]) +16 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [SKIP][49] ([fdo#109276] / [fdo#112080]) -> [PASS][50] +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@[email protected]
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][51] ([fdo#110841]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb3/igt@[email protected]
* igt@gem_ctx_shared@q-smoketest-bsd:
- shard-tglb: [INCOMPLETE][53] ([fdo# 111852 ]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb6/igt@[email protected]
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][55] ([fdo#110854]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb5/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb1/igt@[email protected]
* igt@gem_exec_gttfill@basic:
- shard-tglb: [INCOMPLETE][57] ([fdo#111593]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb4/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb8/igt@[email protected]
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][59] ([fdo#112080]) -> [PASS][60] +18 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb2/igt@[email protected]
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][61] ([fdo#112146]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@[email protected]
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [FAIL][63] ([fdo#112037]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@[email protected]
- shard-kbl: [FAIL][65] ([fdo#112037]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][67] ([fdo#104108]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl10/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl10/igt@[email protected]
* igt@i915_pm_backlight@fade_with_suspend:
- shard-tglb: [INCOMPLETE][69] ([fdo#111832] / [fdo#111850]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb3/igt@i915_pm_backlight@fade_with_suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb3/igt@i915_pm_backlight@fade_with_suspend.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][71] ([fdo#111830 ]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb4/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb5/igt@[email protected]
* igt@i915_selftest@live_requests:
- shard-tglb: [INCOMPLETE][73] ([fdo#112057]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb6/igt@i915_selftest@live_requests.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb5/igt@i915_selftest@live_requests.html
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [FAIL][75] ([fdo#106509] / [fdo#107409]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-glk4/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-glk2/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][77] ([fdo#105363]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-glk1/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-glk7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [INCOMPLETE][79] ([fdo#105411]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb1/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][81] ([fdo#108566]) -> [PASS][82] +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl7/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [FAIL][83] ([fdo#103167]) -> [PASS][84] +5 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb8/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render:
- shard-iclb: [FAIL][85] ([fdo#103167]) -> [PASS][86] +9 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-apl: [DMESG-WARN][87] ([fdo#108566]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-apl4/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-apl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][89] ([fdo#108145] / [fdo#110403]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl8/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl9/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][91] ([fdo#109441]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][93] ([fdo#99912]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl6/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-idle-hang:
- shard-snb: [SKIP][95] ([fdo#109271]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb1/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb7/igt@[email protected]
* igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][97] ([fdo#111850]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb3/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb3/igt@[email protected]
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][99] ([fdo#109276]) -> [PASS][100] +21 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@[email protected]
#### Warnings ####
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][101] ([fdo#105411]) -> [DMESG-WARN][102] ([fdo# 112000 ] / [fdo#111780 ] / [fdo#111781])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb6/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb2/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [DMESG-WARN][103] ([fdo#110789] / [fdo#111870]) -> [DMESG-WARN][104] ([fdo#111870])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-hsw5/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-hsw2/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-hsw: [DMESG-WARN][105] ([fdo#111870]) -> [DMESG-WARN][106] ([fdo#110789] / [fdo#111870])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-hsw1/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-hsw1/igt@[email protected]
{name}: This element is suppressed. This means it is igno
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx