Skip to contentSkip to conversation

virtio-rng: fix device/driver confusion

PATCH In review Michael S. Tsirkin 2 participants 2 messages Nov 24, 2019 – Nov 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-rng: fix device/driver confusion

The point of rng is to give data to driver so of course all buffers are driver readable. What shouldn't be there is device readable buffers - this matches our terminology elsewhere too (read/write-ability is from POV of device).

---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
content.tex +1 -1
index 678afbe..72e832e 100644
@@ -4721,7 +4721,7 @@ \subsection{Device Operation}\label{sec:Device Types / Entropy Device / Device O
 
 \drivernormative{\subsubsection}{Device Operation}{Device Types / Entropy Device / Device Operation}
 
-The driver MUST NOT place driver-readable buffers into the queue.
+The driver MUST NOT place device-readable buffers into the queue.
 
 The driver MUST examine the length written by the device to determine
 how many random bytes were received.
Signature · 7 lines
MST


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines

The point of rng is to give data to driver so of course all buffers are driver readable. What shouldn't be there is device readable buffers - this matches our terminology elsewhere too (read/write-ability is from POV of device).

Quoted 23 lines
---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
content.tex +0 -0
index 678afbe..72e832e 100644
@@ -4721,7 +4721,7 @@ \subsection{Device Operation}\label{sec:Device Types /

Entropy Device / Device O

\drivernormative{\subsubsection}{Device Operation}{Device Types / Entropy Device / Device Operation}

content.tex +1 -2
-The driver MUST NOT place driver-readable buffers into the queue.
+The driver MUST NOT place device-readable buffers into the queue.
 
 The driver MUST examine the length written by the device to determine
 how many random bytes were received.
--

MST

Quoted 5 lines

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]