Skip to contentSkip to conversation

ath9k: use iowrite32 over __raw_writel

PATCH In review Christian Lamparter 2 participants 3 messages Nov 24, 2019 – Nov 28, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath9k: use iowrite32 over __raw_writel

This patch changes the ath9k_pci_owl_loader to use the same iowrite32 memory accessor that ath9k_pci is using to communicate with the PCI(e) chip.

This will fix endian issues that came up during testing with loaned AVM Fritz!Box 7360 (Lantiq MIPS SoCs + AR9287).

Fixes 5a4f2040fd07 ("ath9k: add loader for AR92XX (and older) pci(e)")
---
 drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c +1 -1
index 956fa7828d0c..56d1a7764b9f 100644
@@ -83,7 +83,7 @@ static int ath9k_pci_fixup(struct pci_dev *pdev, const u16 *cal_data,
 			val = swahb32(val);
 		}
 
-		__raw_writel(val, mem + reg);
+		iowrite32(val, mem + reg);
 		usleep_range(100, 120);
 	}
 
Signature · 1 line
2.24.0
#1 lore raw
Quoted 9 lines · Christian Lamparter

This patch changes the ath9k_pci_owl_loader to use the same iowrite32 memory accessor that ath9k_pci is using to communicate with the PCI(e) chip.

This will fix endian issues that came up during testing with loaned AVM Fritz!Box 7360 (Lantiq MIPS SoCs + AR9287).

Fixes 5a4f2040fd07 ("ath9k: add loader for AR92XX (and older) pci(e)")

I'll queue this to v5.5.

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to Christian Lamparter
Quoted 9 lines · Christian Lamparter

This patch changes the ath9k_pci_owl_loader to use the same iowrite32 memory accessor that ath9k_pci is using to communicate with the PCI(e) chip.

This will fix endian issues that came up during testing with loaned AVM Fritz!Box 7360 (Lantiq MIPS SoCs + AR9287).

Fixes 5a4f2040fd07 ("ath9k: add loader for AR92XX (and older) pci(e)")

Patch applied to wireless-drivers.git, thanks.

22d0d5ae7a08 ath9k: use iowrite32 over __raw_writel

Signature · 3 lines
https://patchwork.kernel.org/patch/11259213/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches