Skip to contentSkip to conversation

tools: checkpatch: Restore 'debug' and 'printf' to logFunctions list

PATCH New James Byrne 2 participants 2 messages Nov 21, 2019 – Nov 24, 2019 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 tools: checkpatch: Restore 'debug' and 'printf' to logFunctions list

The 'debug' and 'printf' functions were previously added to the list of logFunctions in commit 0cab42110dbf ("checkpatch.pl: Add 'debug' to the list of logFunctions") and commit 397bfd4642c1 ("checkpatch.pl:
Add 'printf' to logFunctions") but these additions were lost when newer versions of checkpatch were pulled in from the upstream Linux kernel version.

This restores them so that you don't end up in a situation where checkpatch will give a warning for "quoted string split across lines" which you cannot fix without getting a warning for "line over 80 characters" instead.

---

Changes in v2: None

 scripts/checkpatch.pl | 2 ++
 1 file changed, 2 insertions(+)
scripts/checkpatch.pl +2 -0
index 6fcc66afb0..c2641bc995 100755
@@ -464,6 +464,8 @@ our $logFunctions = qr{(?x:
 	TP_printk|
 	WARN(?:_RATELIMIT|_ONCE|)|
 	panic|
+	debug|
+	printf|
 	MODULE_[A-Z_]+|
 	seq_vprintf|seq_printf|seq_puts
 )};
Signature · 1 line
2.24.0
#1 lore raw

PATCH v2 1/3 tools: checkpatch: Restore 'debug' and 'printf' to logFunctions list

Quoted 7 lines · James Byrne

The 'debug' and 'printf' functions were previously added to the list of logFunctions in commit 0cab42110dbf ("checkpatch.pl: Add 'debug' to the list of logFunctions") and commit 397bfd4642c1 ("checkpatch.pl:
Add 'printf' to logFunctions") but these additions were lost when newer versions of checkpatch were pulled in from the upstream Linux kernel version.

Quoted 6 lines

This restores them so that you don't end up in a situation where checkpatch will give a warning for "quoted string split across lines" which you cannot fix without getting a warning for "line over 80 characters" instead.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191124/ef4e5b14/attachment.sig>