Revert "video: mxsfb: Configure the clock after eLCDIF reset"
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 Revert "video: mxsfb: Configure the clock after eLCDIF reset"
Commit ec3dcea74470 ("video: mxsfb: Configure the clock after eLCDIF reset") causes boot regression on imx7d-pico/imx7d-sdb boards, so revert it until a better solution is prepared.
This reverts commit ec3dcea7447031463643c33143b3a5f027f0b54d.
Reported-by Joris Offouga <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
--- drivers/video/mxsfb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/video/mxsfb.c +3 -3
@@ -57,6 +57,9 @@ static void mxs_lcd_init(u32 fb_addr, struct ctfb_res_modes *mode, int bpp)uint32_t word_len =0 , bus_width =0 ;uint8_t valid_data =0 ; +/* Kick in the LCDIF clock */ +mxs_set_lcdclk (MXS_LCDIF_BASE ,PS2KHZ (mode->pixclock)); +/* Restart the LCDIF block */ mxs_reset_block (®s->hw_lcdif_ctrl_reg);
@@ -127,9 +130,6 @@ static void mxs_lcd_init(u32 fb_addr, struct ctfb_res_modes *mode, int bpp)/* FIFO cleared */ writel (LCDIF_CTRL1_FIFO_CLEAR , ®s->hw_lcdif_ctrl1_clr); -/* Kick in the LCDIF clock */ -mxs_set_lcdclk (MXS_LCDIF_BASE ,PS2KHZ (mode->pixclock)); -/* RUN! */ writel (LCDIF_CTRL_RUN , ®s->hw_lcdif_ctrl_set); }
Signature · 1 line
2.17.1
PATCH 1/1 Revert "video: mxsfb: Configure the clock after eLCDIF reset"
Hi Fabio,
Quoted 11 lines · On Sun, 24 Nov 2019 17:37:52 -0300 Fabio Estevam festevam at gmail.com wrote:
Commit
ec3dcea74470("video: mxsfb: Configure the clock after eLCDIF reset") causes boot regression on imx7d-pico/imx7d-sdb boards, so revert it until a better solution is prepared.This reverts commit
ec3dcea7447031463643c33143b3a5f027f0b54d.Reported-by Joris Offouga <[email protected]>Signed-off-by Fabio Estevam <[email protected]>--- drivers/video/mxsfb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Applied to u-boot-video/master, thanks!
--
Anatolij