Skip to contentSkip to conversation

test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'

PATCH In review SZEDER Gábor 2 participants 2 messages Nov 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'

When 'test_commit_bulk' is invoked in an empty test repository, it prints a "fatal: Needed a single revision" error, but still does what it's supposed to do. A test helper function displaying a fatal error and still succeeding is always suspect to be buggy, but luckily that's not the case here: that error comes from a 'git rev-parse --verify HEAD' command invoked in a condition, which doesn't have anything to verify in an empty repository.

Use the '--quiet' option to suppress that error message.

---
 t/test-lib-functions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
t/test-lib-functions.sh +1 -1
index b299ecc326..6302bfb51d 100644
@@ -308,7 +308,7 @@ test_commit_bulk () {
 	total=$1
 
 	add_from=
-	if git -C "$indir" rev-parse --verify "$ref"
+	if git -C "$indir" rev-parse --quiet --verify "$ref"
 	then
 		add_from=t
 	fi
Signature · 1 line
2.24.0.587.g7096fda53a
#1 lore raw
Quoted 9 lines · SZEDER Gábor

When 'test_commit_bulk' is invoked in an empty test repository, it prints a "fatal: Needed a single revision" error, but still does what it's supposed to do. A test helper function displaying a fatal error and still succeeding is always suspect to be buggy, but luckily that's not the case here: that error comes from a 'git rev-parse --verify HEAD' command invoked in a condition, which doesn't have anything to verify in an empty repository.

Use the '--quiet' option to suppress that error message.

Yep, makes perfect sense. Thanks.

-Peff