Skip to contentSkip to conversation

examples/ioat: fix possible null dereference

PATCH Applied Bruce Richardson 2 participants 2 messages Nov 25, 2019 – Nov 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples/ioat: fix possible null dereference

When searching for raw devices with the correct type, we check the driver name using strcmp, without first checking that the call to info get succeeded and assigned a value to that pointer.

If the call to get the device info fails, we can treat it as if the device didn't match, and continue the loop, so the easiest fix is just to skip the strcmp if the driver_name is null. [A non-null value from a previous failed match is ok as it too causes the same behaviour of another loop iteration].

Coverity issue: 350353

Fixes 2328542ed84e ("examples/ioat: add rawdev copy mode")
---
 examples/ioat/ioatfwd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
examples/ioat/ioatfwd.c +3 -2
index a0cc5c496..e9117718f 100644
@@ -751,8 +751,9 @@ assign_rawdevs(void)
 				if (rdev_id == rte_rawdev_count())
 					goto end;
 				rte_rawdev_info_get(rdev_id++, &rdev_info);
-			} while (strcmp(rdev_info.driver_name,
-				IOAT_PMD_RAWDEV_NAME_STR) != 0);
+			} while (rdev_info.driver_name == NULL ||
+					strcmp(rdev_info.driver_name,
+						IOAT_PMD_RAWDEV_NAME_STR) != 0);
 
 			cfg.ports[i].ioat_ids[j] = rdev_id - 1;
 			configure_rawdev_queue(cfg.ports[i].ioat_ids[j]);
Signature · 1 line
2.21.0
#1 lore raw
Quoted 10 lines · Bruce Richardson

When searching for raw devices with the correct type, we check the driver name using strcmp, without first checking that the call to info get succeeded and assigned a value to that pointer.

If the call to get the device info fails, we can treat it as if the device didn't match, and continue the loop, so the easiest fix is just to skip the strcmp if the driver_name is null. [A non-null value from a previous failed match is ok as it too causes the same behaviour of another loop iteration].

Quoted 4 lines

Coverity issue: 350353

Fixes 2328542ed84e ("examples/ioat: add rawdev copy mode")

Applied, thanks.

--
David Marchand