Skip to contentSkip to conversation

drm/amd/display: Modify comments to match the code

PATCH New Zhan liu 1 participant 1 message Nov 25, 2019

Subsystems (3)
lore
Share & tools
lore

Zhan liu

author
#0 lore raw

PATCH v2 1/1 drm/amd/display: Modify comments to match the code

[Why]
This line of code was modified. However, comments remained unchanged. As a result, comments and code are mismatching.

[How]
Modifying comments to reflect code. At the same time, explaining why the value was changed from 200ms to 3000ms.

---
 drivers/gpu/drm/amd/display/dc/dc_helper.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dc_helper.c +6 -1
index 8da4576e2908..e41befa067ce 100644
@@ -485,7 +485,12 @@ void generic_reg_wait(const struct dc_context *ctx,
 		return;
 	}
 
-	/* something is terribly wrong if time out is > 200ms. (5Hz) */
+	/*
+	 * Something is terribly wrong if time out is > 3000ms.
+	 * 3000ms is the maximum time needed for SMU to pass values back.
+	 * This value comes from experiments.
+	 *
+	 */
 	ASSERT(delay_between_poll_us * time_out_num_tries <= 3000000);
 
 	for (i = 0; i <= time_out_num_tries; i++) {
Signature · 6 lines
2.21.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx