Skip to contentSkip to conversation

ci: add Cirrus-CI config for FreeBSD CI

PATCH In review Ed Maste 3 participants 6 messages Nov 25, 2019 – Dec 20, 2019

lore
Share & tools
lore

Ed Maste

author
#0 lore raw

PATCH 1/1 ci: add Cirrus-CI config for FreeBSD CI

From: Ed Maste <[email protected]>

Cirrus-CI is relatively unique among hosted CI providers in supporting FreeBSD (in addition to Linux, Windows, and macOS). Add a Cirrus-CI config to facilitate building and testing on FreeBSD.

---
6 i18n tests are currently failing and need investigation. Example result: https://cirrus-ci.com/task/5394512637067264
Test log: https://api.cirrus-ci.com/v1/task/5394512637067264/logs/test.log

 .cirrus.yml | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 .cirrus.yml
.cirrus.yml new file +12 -0
new file mode 100644
index 0000000000..47d871ded5
@@ -0,0 +1,12 @@
+env:
+  CIRRUS_CLONE_DEPTH: 1
+
+freebsd_12_task:
+  freebsd_instance:
+    image: freebsd-12-1-release-amd64
+  install_script:
+    pkg install -y gettext gmake perl5
+  build_script:
+    - gmake
+  test_script:
+    - gmake test
Signature · 1 line
2.24.0
#1 lore raw
Quoted 7 lines · Ed Maste

From: Ed Maste <[email protected]>

Cirrus-CI is relatively unique among hosted CI providers in supporting FreeBSD (in addition to Linux, Windows, and macOS). Add a Cirrus-CI config to facilitate building and testing on FreeBSD.

I'm all for automated testing on FreeBSD, but we would need someone to triage and address any failures reasonably quickly. Is that something you'd be okay with doing, or is there someone else who would be okay with doing that?

Quoted 4 lines

---
6 i18n tests are currently failing and need investigation. Example result: https://cirrus-ci.com/task/5394512637067264
Test log: https://api.cirrus-ci.com/v1/task/5394512637067264/logs/test.log

Could we fix these issues first so we don't have CI suddenly start failing?

Signature · 2 lines
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
#2 lore raw
Quoted 8 lines · brian m. carlson
Quoted 6 lines · Ed Maste

From: Ed Maste <[email protected]>

Cirrus-CI is relatively unique among hosted CI providers in supporting FreeBSD (in addition to Linux, Windows, and macOS). Add a Cirrus-CI config to facilitate building and testing on FreeBSD.

Quoted 6 lines
Quoted 1 line

I'm all for automated testing on FreeBSD, but we would need someone to triage and address any failures reasonably quickly. Is that something you'd be okay with doing, or is there someone else who would be okay with doing that?

We're currently experimenting with a migration of the FreeBSD repo from Subversion to git, so long term there will be many with a vested interest in triaging and addressing failures. In the near term though I'd be able to take this on.

Quoted 6 lines
Quoted 3 lines

6 i18n tests are currently failing and need investigation. Example result: https://cirrus-ci.com/task/5394512637067264
Test log: https://api.cirrus-ci.com/v1/task/5394512637067264/logs/test.log

Could we fix these issues first so we don't have CI suddenly start failing?

Indeed, that makes sense. I think the failures may be an issue with the test though; here's the first failure:

expecting success of 4210.6 '-c grep.patternType=fixed log --grep does not find non-reencoded values (latin1 + locale)':
cat >expect <<-\EOF &&
latin1
utf8
EOF
LC_ALL="is_IS.UTF-8" git -c grep.patternType=fixed log
--encoding=ISO-8859-1 --format=%s --grep="_" >actual &&
test_cmp expect actual

fatal: command line, '_': illegal byte sequence

This was added in 4e2443b1813 with this note in the commit message:

| It's possible that this
| test breaks the "basic" and "extended" backends on some systems that
| are more anal than glibc about the encoding of locale issues with
| POSIX functions that I can remember, but PCRE is more careful about
| the validation.

I've CC'd Ævar Arnfjörð Bjarmason for advice on this.

#3 lore raw
In reply to brian m. carlson
Quoted 5 lines · brian m. carlson

I'm all for automated testing on FreeBSD, but we would need someone to triage and address any failures reasonably quickly. Is that something you'd be okay with doing, or is there someone else who would be okay with doing that?

Renato Botelho <[email protected]> is the maintainer of the devel/git port/package on FreeBSD and has now also joined this list and offered to help triage and address issues.

Quoted 2 lines

Could we fix these issues first so we don't have CI suddenly start failing?

After some further investigation I believe these tests are technically invalid but work with glibc because of its looser requirements. I've sent a patch (t4210: skip i18n tests that don't work on FreeBSD) to address the failures.

#4 lore raw
Quoted 5 lines · Ed Maste

After some further investigation I believe these tests are technically invalid but work with glibc because of its looser requirements. I've sent a patch (t4210: skip i18n tests that don't work on FreeBSD) to address the failures.

And a now-passing test run on FreeBSD with the change :
https://cirrus-ci.com/task/5657957240406016

#5 lore raw

PATCH v2 1/1 CI: add FreeBSD CI support via Cirrus-CI

In reply to Ed Maste

Currently testing on FreeBSD 12.1.

---
Since v1, create an unprivileged user and build/test using that user. CI run with this change: https://cirrus-ci.com/task/6565294088126464

 .cirrus.yml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 .cirrus.yml
.cirrus.yml new file +15 -0
new file mode 100644
index 0000000000..c2f5fe385a
@@ -0,0 +1,15 @@
+env:
+  CIRRUS_CLONE_DEPTH: 1
+
+freebsd_12_task:
+  freebsd_instance:
+    image: freebsd-12-1-release-amd64
+  install_script:
+    pkg install -y gettext gmake perl5
+  create_user_script:
+    - pw useradd git
+    - chown -R git:git .
+  build_script:
+    - su git -c gmake
+  test_script:
+    - su git -c 'gmake test'
Signature · 1 line
2.24.0