Skip to contentSkip to conversation

package/glibc: install locale utility when nls is enabled

PATCH New Pascal de Bruijn 3 participants 3 messages Nov 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/glibc: install locale utility when nls is enabled

---
 package/glibc/Config.in | 2 +-
 package/glibc/glibc.mk  | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)
package/glibc/Config.in +1 -1
index 323767f..b8c2573 100644
@@ -14,7 +14,7 @@ config BR2_PACKAGE_GLIBC_UTILS
 	depends on BR2_PACKAGE_BASH
 	help
 	  Enabling this option will compile and install the getconf,
-	  ldconfig and ldd glibc utilities for the target.
+	  ldconfig, ldd and locale glibc utilities for the target.
 
 comment "glibc utilities need bash"
 	depends on !BR2_PACKAGE_BASH
package/glibc/glibc.mk +3 -0
index 5da0b06..e366134 100644
@@ -146,7 +146,10 @@ endif
 ifeq ($(BR2_PACKAGE_GLIBC_UTILS),y)
 GLIBC_TARGET_UTILS_USR_BIN = posix/getconf elf/ldd
 GLIBC_TARGET_UTILS_SBIN = elf/ldconfig
+endif
 
+ifeq ($(BR2_SYSTEM_ENABLE_NLS),y)
+GLIBC_TARGET_UTILS_USR_BIN += locale/locale
 endif
 
 define GLIBC_INSTALL_TARGET_CMDS
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package/glibc: install locale utility when nls is enabled

Quoted 5 lines · On Tue, 26 Nov 2019 09:55:41 +0100 Pascal de Bruijn <[email protected]>…
---
 package/glibc/Config.in | 2 +-
 package/glibc/glibc.mk  | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

Applied to next, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/glibc: install locale utility when nls is enabled

In reply to Pascal de Bruijn

Hello Pascal,

Quoted 24 lines · Pascal de Bruijn
---
 package/glibc/Config.in | 2 +-
 package/glibc/glibc.mk  | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)
package/glibc/Config.in +1 -1
index 323767f..b8c2573 100644
@@ -14,7 +14,7 @@ config BR2_PACKAGE_GLIBC_UTILS
 	depends on BR2_PACKAGE_BASH
 	help
 	  Enabling this option will compile and install the getconf,
-	  ldconfig and ldd glibc utilities for the target.
+	  ldconfig, ldd and locale glibc utilities for the target.
 
 comment "glibc utilities need bash"
 	depends on !BR2_PACKAGE_BASH
package/glibc/glibc.mk +0 -0
index 5da0b06..e366134 100644

package/glibc/glibc.mk endif · line 153

Quoted 8 lines
package/glibc/glibc.mk +3 -0
@@ -146,7 +146,10 @@ endif
 ifeq ($(BR2_PACKAGE_GLIBC_UTILS),y)
 GLIBC_TARGET_UTILS_USR_BIN = posix/getconf elf/ldd
 GLIBC_TARGET_UTILS_SBIN = elf/ldconfig
+endif
 
+ifeq ($(BR2_SYSTEM_ENABLE_NLS),y)
+GLIBC_TARGET_UTILS_USR_BIN += locale/locale
 endif

Short question regarding your patch: Why install the locale command only in case BR2_SYSTEM_ENABLE_NLS is enabled?

Background: The postgresql initialize startup script emits the following warning:

	performing post-bootstrap initialization ... sh: locale: not found
	1970-01-01 00:10:13.173 UTC [398] WARNING:  no usable system locales were found

Which can be fixed by:

- install the locale command (fixes 'sh: locale: not found')
- enabling some locales e.g. by BR2_GENERATE_LOCALE="C en_US" (fixes no usable system locales were found)

No need to enable BR2_SYSTEM_ENABLE_NLS...

Regards,
Peter

Quoted 2 lines
package/glibc/glibc.mk +0 -0
 define GLIBC_INSTALL_TARGET_CMDS