mt76: fix possible undetected invalid MAC address
Subsystems (2)
Shayne Chen
reviewerPATCH 1/1 mt76: fix possible undetected invalid MAC address
Make sure the MAC address is checked before function returns.
If CONFIG_OF is set and the device node is null, the function will return directly, and an invalid MAC address will not be checked.
Signed-off-by Shayne Chen <[email protected]>
--- drivers/net/wireless/mediatek/mt76/eeprom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/eeprom.c +2 -1
@@ -80,13 +80,14 @@ mt76_eeprom_override(struct mt76_dev *dev)const u8 *mac;if (!np) -return ; + goto out; mac =of_get_mac_address (np);if (!IS_ERR (mac))ether_addr_copy (dev->macaddr, mac);#endif +out:if (!is_valid_ether_addr (dev->macaddr)) {eth_random_addr (dev->macaddr); dev_info(dev->dev,
Signature · 1 line
2.17.1