Skip to contentSkip to conversation

mm: fix comments related to node reclaim

PATCH Applied Hao Lee 2 participants 2 messages Nov 26, 2019 – Nov 28, 2019

Subsystems (3)
Memory management MM core MGLRU
lore
Share & tools
lore

Hao Lee

author
#0 lore raw

PATCH v2 1/1 mm: fix comments related to node reclaim

As zone reclaim has been replaced by node reclaim, this patch fixes related comments.

Signed-off-by Hao Lee <[email protected]>
---
 include/linux/mmzone.h      | 2 +-
 include/uapi/linux/sysctl.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/mmzone.h +1 -1
index 9e47289a4511..7e3208f4f5bc 100644
@@ -747,7 +747,7 @@ typedef struct pglist_data {
 
 #ifdef CONFIG_NUMA
 	/*
-	 * zone reclaim becomes active if more unmapped pages exist.
+	 * node reclaim becomes active if more unmapped pages exist.
 	 */
 	unsigned long		min_unmapped_pages;
 	unsigned long		min_slab_pages;
include/uapi/linux/sysctl.h +1 -1
index 87aa2a6d9125..27c1ed2822e6 100644
@@ -195,7 +195,7 @@ enum
 	VM_MIN_UNMAPPED=32,	/* Set min percent of unmapped pages */
 	VM_PANIC_ON_OOM=33,	/* panic at out-of-memory */
 	VM_VDSO_ENABLED=34,	/* map VDSO into new processes? */
-	VM_MIN_SLAB=35,		 /* Percent pages ignored by zone reclaim */
+	VM_MIN_SLAB=35,		 /* Percent pages ignored by node reclaim */
 };
Signature · 1 line
2.14.5
#1 lore raw
Quoted 27 lines · Hao Lee

As zone reclaim has been replaced by node reclaim, this patch fixes related comments.

Signed-off-by Hao Lee <[email protected]>
---
 include/linux/mmzone.h      | 2 +-
 include/uapi/linux/sysctl.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/mmzone.h +1 -1
index 9e47289a4511..7e3208f4f5bc 100644
@@ -747,7 +747,7 @@ typedef struct pglist_data {
 
 #ifdef CONFIG_NUMA
 	/*
-	 * zone reclaim becomes active if more unmapped pages exist.
+	 * node reclaim becomes active if more unmapped pages exist.
 	 */
 	unsigned long		min_unmapped_pages;
 	unsigned long		min_slab_pages;
include/uapi/linux/sysctl.h +0 -0
index 87aa2a6d9125..27c1ed2822e6 100644

include/uapi/linux/sysctl.h enum · line 199

Quoted 6 lines
include/uapi/linux/sysctl.h +1 -1
@@ -195,7 +195,7 @@ enum
 	VM_MIN_UNMAPPED=32,	/* Set min percent of unmapped pages */
 	VM_PANIC_ON_OOM=33,	/* panic at out-of-memory */
 	VM_VDSO_ENABLED=34,	/* map VDSO into new processes? */
-	VM_MIN_SLAB=35,		 /* Percent pages ignored by zone reclaim */
+	VM_MIN_SLAB=35,		 /* Percent pages ignored by node reclaim */
 };

This looks good to me but wondering if this sort of change could qualify for a stand alone patch or should be carried along with other functional changes. Will leave it upto others to decide.

Quoted 3 lines