usb: typec: fix use after free in typec_register_port()
Subsystems (2)
PATCH 1/1 usb: typec: fix use after free in typec_register_port()
We can't use "port->sw" and/or "port->mux" after it has been freed.
Fixes 23481121c81d ("usb: typec: class: Don't use port parent for getting mux handles")
Signed-off-by Wen Yang <[email protected]>
Cc Heikki Krogerus <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
--- drivers/usb/typec/class.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/usb/typec/class.c +4 -2
@@ -1612,14 +1612,16 @@ struct typec_port *typec_register_port(struct device *parent, port->sw =typec_switch_get (&port->dev);if (IS_ERR (port->sw)) { + ret =PTR_ERR (port->sw);put_device (&port->dev); -return ERR_CAST (port->sw); +return ERR_PTR (ret); } port->mux =typec_mux_get (&port->dev,NULL );if (IS_ERR (port->mux)) { + ret =PTR_ERR (port->mux);put_device (&port->dev); -return ERR_CAST (port->mux); +return ERR_PTR (ret); } ret =device_add (&port->dev);
Signature · 1 line
1.8.3.1
Quoted 5 lines · Wen Yang
We can't use "
port->sw" and/or "port->mux" after it has been freed.Fixes 23481121c81d ("usb: typec: class: Don't use port parent for getting mux handles")Signed-off-by Wen Yang <[email protected]>Cc Heikki Krogerus <[email protected]>
Acked-by Heikki Krogerus <[email protected]>
Quoted 32 lines
--- drivers/usb/typec/class.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/usb/typec/class.c +4
-2@@ -1612,14 +1612,16 @@ struct typec_port *typec_register_port(struct device *parent, port->sw =typec_switch_get (&port->dev);if (IS_ERR (port->sw)) { + ret =PTR_ERR (port->sw);put_device (&port->dev); -return ERR_CAST (port->sw); +return ERR_PTR (ret); } port->mux =typec_mux_get (&port->dev,NULL );if (IS_ERR (port->mux)) { + ret =PTR_ERR (port->mux);put_device (&port->dev); -return ERR_CAST (port->mux); +return ERR_PTR (ret); } ret =device_add (&port->dev);Signature · 1 line
1.8.3.1
thanks,
Signature · 1 line
heikki