Skip to contentSkip to conversation

dynamic-debug cleanups, 2 new features

PATCH Superseded Jim Cromie 1 participant 1 message Nov 27, 2019

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Jim Cromie

author
#0 lore raw

cover dynamic-debug cleanups, 2 new features

this is v2 of patchset posted earlier:
https://lkml.org/lkml/2019/10/29/989

changes from v1:
dont drop trim_prefix yet, its harmless, and better supports old compilers. dont move externs to header, despite checkpatch

New Features (review):

accept new query input:
file inode.c:100-200
file inode.c:start_*

add 'xyz' user flags, allowing user to compose an arbitrary set of callsites by marking them with user flags. This takes 3 remaining bits in the flags byte.

extend flags-spec to allow filter-flags, which select callsites for modification based upon their current flags. This lets user activate the set of callsites composed previously (xy+p).

Jim Cromie (16):
dyndbg-docs: eschew file /full/path query in docs
dyndbg: drop obsolete comment on ddebug_proc_open
dyndbg: raise verbosity needed to enable ddebug_proc_* logging
dyndbg: rename __verbose section to __dyndbg
dyndbg: fix overcounting of ram used by dyndbg
dyndbg: fix a BUG_ON in ddebug_describe_flags
dyndbg: refactor parse_linerange out of ddebug_parse_query
dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'
dyndbg: refactor ddebug_read_flags out of ddebug_parse_flags
dyndbg: combine flags & mask into a struct, use that
dyndbg: add filter parameter to ddebug_parse_flags
dyndbg: extend ddebug_parse_flags to accept optional filter-flags
dyndbg: prefer declarative init in caller, to memset in callee
dyndbg: add inverted-flags, implement filtering on flags
dyndbg: allow inverted-flag-chars in modflags
dyndbg: make ddebug_tables list LIFO for add/remove_module

 .../admin-guide/dynamic-debug-howto.rst       |  72 +++--
 include/asm-generic/vmlinux.lds.h             |   6 +-
 include/linux/dynamic_debug.h                 |   7 +-
 kernel/module.c                               |   2 +-
 lib/dynamic_debug.c                           | 283 +++++++++++-------
 5 files changed, 232 insertions(+), 138 deletions(-)
Signature · 1 line
2.23.0