Skip to contentSkip to conversation

soc: mediatek: cmdq: fixup wrong input order of write api

PATCH In review Matthias Brugger 1 participant 2 messages Nov 28, 2019

Subsystems (2)
lore
Share & tools
lore

Matthias Brugger

author maintainer
#0 lore raw

PATCH 1/1 soc: mediatek: cmdq: fixup wrong input order of write api

From: Bibby Hsieh <[email protected]>

Fixup a issue was caused by the previous fixup patch.

Fixes 1a92f989126e ("soc: mediatek: cmdq: reorder the parameter")
---
 drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/mediatek/mtk-cmdq-helper.c +1 -1
index 7aa0517ff2f3..3c82de5f9417 100644
@@ -155,7 +155,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
 		err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask);
 		offset_mask |= CMDQ_WRITE_ENABLE_MASK;
 	}
-	err |= cmdq_pkt_write(pkt, value, subsys, offset_mask);
+	err |= cmdq_pkt_write(pkt, subsys, offset_mask, value);
 
 	return err;
 }
Signature · 1 line
2.24.0
author maintainer
#1 lore raw

I resend the patch by accident.

Please ignore this one.

Regards,
Matthias

Quoted 28 lines · Matthias Brugger

From: Bibby Hsieh <[email protected]>

Fixup a issue was caused by the previous fixup patch.

Fixes 1a92f989126e ("soc: mediatek: cmdq: reorder the parameter")
---
 drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/mediatek/mtk-cmdq-helper.c +1 -1
index 7aa0517ff2f3..3c82de5f9417 100644
@@ -155,7 +155,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
 		err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask);
 		offset_mask |= CMDQ_WRITE_ENABLE_MASK;
 	}
-	err |= cmdq_pkt_write(pkt, value, subsys, offset_mask);
+	err |= cmdq_pkt_write(pkt, subsys, offset_mask, value);
 
 	return err;
 }