zram: fix error return codes not being returned in writeback_store
Subsystems (3)
PATCH 1/1 zram: fix error return codes not being returned in writeback_store
From: Colin Ian King <[email protected]>
Currently when an error code -EIO or -ENOSPC in the for-loop of writeback_store the error code is being overwritten by a ret = len assignment at the end of the function and the error codes are being lost. Fix this by assigning ret = len at the start of the function and remove the assignment from the end, hence allowing ret to be preserved when error codes are assigned to it.
Addresses-Coverity: ("Unused value")
--- drivers/block/zram/zram_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/block/zram/zram_drv.c +1 -2
@@ -626,7 +626,7 @@ static ssize_t writeback_store(struct device *dev,struct bio bio;struct bio_vec bio_vec;struct page *page; -ssize_t ret; +ssize_t ret = len;int mode;unsigned long blk_idx =0 ;
@@ -762,7 +762,6 @@ static ssize_t writeback_store(struct device *dev,if (blk_idx)free_block_bdev (zram, blk_idx); - ret = len;__free_page (page); release_init_lock:up_read (&zram->init_lock);
Signature · 1 line
2.24.0
Quoted 9 lines · Colin King
From: Colin Ian King <[email protected]>
Currently when an error code
-EIOor-ENOSPCin the for-loop ofwriteback_storethe error code is being overwritten by a ret = len assignment at the end of the function and the error codes are being lost. Fix this by assigning ret = len at the start of the function and remove the assignment from the end, hence allowing ret to be preserved when error codes are assigned to it.
Quoted 3 lines
Addresses-Coverity: ("Unused value")
Fixes a939888ec38b ("zram: support idle/huge page writeback")Signed-off-by Colin Ian King <[email protected]>
Thanks!