Skip to contentSkip to conversation

crypto: arm64/ghash-neon - bump priority to 150

PATCH In review Ard Biesheuvel 2 participants 2 messages Nov 28, 2019 – Dec 11, 2019

Subsystems (2)
Crypto API arm64
lore
Share & tools
lore

Ard Biesheuvel

author
#0 lore raw

PATCH 1/1 crypto: arm64/ghash-neon - bump priority to 150

The SIMD based GHASH implementation for arm64 is typically much faster than the generic one, and doesn't use any lookup tables, so it is clearly preferred when available. So bump the priority to reflect that.

Fixes 5a22b198cd527447 ("crypto: arm64/ghash - register PMULL variants ...")
Signed-off-by Ard Biesheuvel <[email protected]>
---
 arch/arm64/crypto/ghash-ce-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/crypto/ghash-ce-glue.c +1 -1
index 522cf004ce65..196aedd0c20c 100644
@@ -259,7 +259,7 @@ static int ghash_setkey(struct crypto_shash *tfm,
 static struct shash_alg ghash_alg[] = {{
 	.base.cra_name		= "ghash",
 	.base.cra_driver_name	= "ghash-neon",
-	.base.cra_priority	= 100,
+	.base.cra_priority	= 150,
 	.base.cra_blocksize	= GHASH_BLOCK_SIZE,
 	.base.cra_ctxsize	= sizeof(struct ghash_key),
 	.base.cra_module	= THIS_MODULE,
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 9 lines · Ard Biesheuvel

The SIMD based GHASH implementation for arm64 is typically much faster than the generic one, and doesn't use any lookup tables, so it is clearly preferred when available. So bump the priority to reflect that.

Fixes 5a22b198cd527447 ("crypto: arm64/ghash - register PMULL variants ...")
Signed-off-by Ard Biesheuvel <[email protected]>
---
 arch/arm64/crypto/ghash-ce-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt