Skip to contentSkip to conversation

recipes-support: gperftools: RDEPENDS for pprof

PATCH In review Cengiz Can 2 participants 2 messages Nov 28, 2019 – Jul 25, 2020

lore
Share & tools
lore

Cengiz Can

author
#0 lore raw

PATCH v2 1/1 recipes-support: gperftools: RDEPENDS for pprof

gperftools comes with pprof tool that usually needs to be run at target machine to aggregate CPUPROFILE data.

However since we were not shipping objdump (binutils), Getopt::long and POSIX perl5 modules, it was failing.

I've extended RDEPENDS_${PN} with those so that whenever someone installs gperftools, those dependencies are fulfilled as well.

---
 meta-oe/recipes-support/gperftools/gperftools_2.7.bb | 5 +++++
 1 file changed, 5 insertions(+)
meta-oe/recipes-support/gperftools/gperftools_2.7.bb +5 -0
index 731c83516..ee34acec2 100644
@@ -35,5 +35,10 @@ PACKAGECONFIG[static] = "--enable-static,--disable-static,"
 
 PACKAGE_BEFORE_PN += "libtcmalloc-minimal"
 FILES_libtcmalloc-minimal = "${libdir}/libtcmalloc_minimal*${SOLIBS} ${libdir}/libtcmalloc_minimal_debug*${SOLIBS}"
+
+# pprof tool requires Getopt::long and POSIX perl5 modules.
+# Also runs `objdump` on each cpuprofile data file
+RDEPENDS_${PN} += "binutils perl-module-getopt-long perl-module-posix"
+
 RDEPENDS_${PN} += "libtcmalloc-minimal (= ${EXTENDPKGV})"
 

--
2.24.0

#1 lore raw

Hi all,

I'm using mongodb with tcmalloc PACKAGECONFIG so it rdepends on gperftools. Before this commit, my image didn't need perl, so I'm wondering if we cannot split tcmalloc library or pprof tool in separate gperftools-{tcmalloc,pprof} package?

Kind regards,
Vincent

Quoted 38 lines · Cengiz Can

gperftools comes with pprof tool that usually needs to be run at target machine to aggregate CPUPROFILE data.

However since we were not shipping objdump (binutils), Getopt::long and POSIX perl5 modules, it was failing.

I've extended RDEPENDS_${PN} with those so that whenever someone installs gperftools, those dependencies are fulfilled as well.

---
 meta-oe/recipes-support/gperftools/gperftools_2.7.bb | 5 +++++
 1 file changed, 5 insertions(+)
meta-oe/recipes-support/gperftools/gperftools_2.7.bb +5 -1
index 731c83516..ee34acec2 100644
@@ -35,5 +35,10 @@ PACKAGECONFIG[static] = "--enable-static,--disable-static,"
 
 PACKAGE_BEFORE_PN += "libtcmalloc-minimal"
 FILES_libtcmalloc-minimal = "${libdir}/libtcmalloc_minimal*${SOLIBS} ${libdir}/libtcmalloc_minimal_debug*${SOLIBS}"
+
+# pprof tool requires Getopt::long and POSIX perl5 modules.
+# Also runs `objdump` on each cpuprofile data file
+RDEPENDS_${PN} += "binutils perl-module-getopt-long perl-module-posix"
+
 RDEPENDS_${PN} += "libtcmalloc-minimal (= ${EXTENDPKGV})"
 
--

2.24.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel