Skip to contentSkip to conversation

package/musl: add an upstream URL to Config.in

PATCH New Mark Corbin 3 participants 4 messages Nov 28, 2019 – Dec 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/musl: add an upstream URL to Config.in

Add an upstream URL to the help text in Config.in. This addresses the 'Missing' URL status in the package stats web page output.

---
 package/musl/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/musl/Config.in +2 -0
index 67e9e78a14..69da615b63 100644
@@ -8,3 +8,5 @@ config BR2_PACKAGE_MUSL
 		&& !(BR2_i386 || BR2_powerpc)
 	# Compatibility headers: cdefs.h, queue.h
 	select BR2_PACKAGE_MUSL_COMPAT_HEADERS
+	help
+	  https://www.musl-libc.org/
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/musl: add an upstream URL to Config.in

Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mark" == Mark Corbin <[email protected]> writes:

Add an upstream URL to the help text in Config.in. This addresses the 'Missing' URL status in the package stats web page output.

---
 package/musl/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/musl/Config.in +0 -0
index 67e9e78a14..69da615b63 100644

package/musl/Config.in config BR2_PACKAGE_MUSL · line 12

Quoted 5 lines
package/musl/Config.in +2 -0
@@ -8,3 +8,5 @@ config BR2_PACKAGE_MUSL
 		&& !(BR2_i386 || BR2_powerpc)
 	# Compatibility headers: cdefs.h, queue.h
 	select BR2_PACKAGE_MUSL_COMPAT_HEADERS
+	help
+	  https://www.musl-libc.org/

It is a bit silly to have a help text for blind option, but OK - I guess it doesn't harm.

The user visible option is BR2_TOOLCHAIN_BUILDROOT_MUSL, which also didn't have this URL so I added it there as well and committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/musl: add an upstream URL to Config.in

Quoted 11 lines · Peter Korsgaard
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mark" == Mark Corbin <[email protected]> writes:

Add an upstream URL to the help text in Config.in. This addresses the 'Missing' URL status in the package stats web page output.

---
 package/musl/Config.in | 2 ++
 1 file changed, 2 insertions(+)
Quoted 13 lines

package/musl/Config.in config BR2_PACKAGE_MUSL · line 12

Quoted 10 lines
package/musl/Config.in +2 -0
index 67e9e78a14..69da615b63 100644
@@ -8,3 +8,5 @@ config BR2_PACKAGE_MUSL
 		&& !(BR2_i386 || BR2_powerpc)
 	# Compatibility headers: cdefs.h, queue.h
 	select BR2_PACKAGE_MUSL_COMPAT_HEADERS
+	help
+	  https://www.musl-libc.org/

It is a bit silly to have a help text for blind option, but OK - I guess it doesn't harm.

I think we would be better off changing the pkg-stats scripts to not report
this for options without any help text.

Regards,
Arnout

Quoted 4 lines

The user visible option is BR2_TOOLCHAIN_BUILDROOT_MUSL, which also didn't have this URL so I added it there as well and committed, thanks.

#3 lore raw

PATCH 1/1 package/musl: add an upstream URL to Config.in

Quoted 28 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 11 lines · Peter Korsgaard
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mark" == Mark Corbin <[email protected]> writes:

Add an upstream URL to the help text in Config.in. This addresses the 'Missing' URL status in the package stats web page output.

---
 package/musl/Config.in | 2 ++
 1 file changed, 2 insertions(+)
Quoted 13 lines

package/musl/Config.in config BR2_PACKAGE_MUSL · line 12

Quoted 10 lines
package/musl/Config.in +2 -0
index 67e9e78a14..69da615b63 100644
@@ -8,3 +8,5 @@ config BR2_PACKAGE_MUSL
 		&& !(BR2_i386 || BR2_powerpc)
 	# Compatibility headers: cdefs.h, queue.h
 	select BR2_PACKAGE_MUSL_COMPAT_HEADERS
+	help
+	  https://www.musl-libc.org/

It is a bit silly to have a help text for blind option, but OK - I guess it doesn't harm.

Quoted 2 lines

I think we would be better off changing the pkg-stats scripts to not report
this for options without any help text.

True. Does anybody feel up for implementing that?

Signature · 1 line
Bye, Peter Korsgaard