can: ucan: fix non-atomic allocation in completion handler
Subsystems (4)
PATCH 1/1 can: ucan: fix non-atomic allocation in completion handler
USB completion handlers are called in atomic context and must specifically not allocate memory using GFP_KERNEL.
Fixes 9f2d3eae88d2 ("can: ucan: add driver for Theobroma Systems UCAN devices")
Cc stable <[email protected]> # 4.19
Cc Jakob Unterwurzacher <[email protected]>
Cc Martin Elshuber <[email protected]>
Cc Philipp Tomsich <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
--- drivers/net/can/usb/ucan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/can/usb/ucan.c +1 -1
@@ -792,7 +792,7 @@ static void ucan_read_bulk_callback(struct urb *urb) up);usb_anchor_urb (urb, &up->rx_urbs); - ret =usb_submit_urb (urb,GFP_KERNEL ); + ret =usb_submit_urb (urb,GFP_ATOMIC );if (ret <0 ) { netdev_err(up->netdev,
Signature · 1 line
2.24.0
Marc Kleine-Budde
maintainerQuoted 9 lines · Johan Hovold
USB completion handlers are called in atomic context and must specifically not allocate memory using
GFP_KERNEL.Fixes 9f2d3eae88d2 ("can: ucan: add driver for Theobroma Systems UCAN devices")Cc stable <[email protected]> # 4.19Cc Jakob Unterwurzacher <[email protected]>Cc Martin Elshuber <[email protected]>Cc Philipp Tomsich <[email protected]>Signed-off-by Johan Hovold <[email protected]>
Added to linux-can.
tnx,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |