Skip to contentSkip to conversation

ext2: set proper errno in error case of ext2_fill_super()

PATCH RESEND In review Chengguang Xu 2 participants 2 messages Nov 29, 2019 ext2 file system

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 ext2: set proper errno in error case of ext2_fill_super()

Set proper errno in the case of failure of
initializing percpu variables.

---
Forgot to cc ext4 maillist, so resend it.

 fs/ext2/super.c | 1 +
 1 file changed, 1 insertion(+)
fs/ext2/super.c +1 -0
index 30c630d73f0f..74a9e3e71c13 100644
@@ -1147,6 +1147,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
 				ext2_count_dirs(sb), GFP_KERNEL);
 	}
 	if (err) {
+		ret = err;
 		ext2_msg(sb, KERN_ERR, "error: insufficient memory");
 		goto failed_mount3;
 	}
Signature · 1 line
2.20.1
#1 lore raw
Quoted 4 lines · Chengguang Xu

Set proper errno in the case of failure of
initializing percpu variables.

Thanks. I've added the patch to my tree.

Honza

Quoted 23 lines

---
Forgot to cc ext4 maillist, so resend it.

 fs/ext2/super.c | 1 +
 1 file changed, 1 insertion(+)
fs/ext2/super.c +1 -0
index 30c630d73f0f..74a9e3e71c13 100644
@@ -1147,6 +1147,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
 				ext2_count_dirs(sb), GFP_KERNEL);
 	}
 	if (err) {
+		ret = err;
 		ext2_msg(sb, KERN_ERR, "error: insufficient memory");
 		goto failed_mount3;
 	}
Signature · 1 line
2.20.1
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR