arm64: dts: allwinner: a64: olinuxino: Update regulators
Subsystems (3)
v2 cover arm64: dts: allwinner: a64: olinuxino: Update regulators
This patch serie updates bank regulators for A64-OLinuXino and A64-OLinuXino-eMMC.
Also, eMMC supply is changed to ELDO1, which is the actual one. The same is done for the SDIO card - ALDO2 is changed to DCDC1.
Changes for v2:
- Restore the original eMMC vmmc-supply property
- Add fixes and kernel tags
Stefan Mavrodiev (3):
arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator
arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators
arm64: dts: allwinner: a64: olinuxino: Fix SDIO supply regulator
.../allwinner/sun50i-a64-olinuxino-emmc.dts | 6 +++++- .../dts/allwinner/sun50i-a64-olinuxino.dts | 18 +++++++++++++++++- 2 files changed, 22 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/3 arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator
A64-OLinuXino-eMMC uses 1.8V for eMMC supply. This is done via a triple jumper, which sets VCC-PL to either 1.8V or 3.3V. This setting is different for boards with and without eMMC.
This is not a big issue for DDR52 mode, however the eMMC will not work in HS200/HS400, since these modes explicitly requires 1.8V.
---
Changes for v2:
- Restore the original eMMC vmmc-supply property
arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts +1 -1
@@ -15,7 +15,7 @@ pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>; vmmc-supply = <®_dcdc1>; - vqmmc-supply = <®_dcdc1>; + vqmmc-supply = <®_eldo1>; bus-width = <8>; non-removable; cap-mmc-hw-reset;
Signature · 1 line
2.17.1
Maxime Ripard
AppliedRe: [PATCH v2 1/3] arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator
Quoted 10 lines · Stefan Mavrodiev
A64-OLinuXino-eMMC uses 1.8V for eMMC supply. This is done via a triple jumper, which sets VCC-PL to either 1.8V or 3.3V. This setting is different for boards with and without eMMC.
This is not a big issue for DDR52 mode, however the eMMC will not work in HS200/HS400, since these modes explicitly requires 1.8V.
Fixes 94f68f3a4b2a ("arm64: dts: allwinner: a64: Add A64 OlinuXino board (with eMMC)")Cc [email protected] # v5.4Signed-off-by Stefan Mavrodiev <[email protected]>
Applied, thanks!
Maxime
PATCH v2 2/3 arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators
In reply to Stefan MavrodievAllwinner A64 SoC has separate supplies for PC, PD, PE, PG and PL. This patch adds regulators for them to the pinctrl node.
Exception is PL which is used by the RSB bus. To avoid circular dependencies, VCC-PL is omitted.
On boards with eMMC, VCC-PC is supplied by ELDO1, instead of DCDC1.
--- .../dts/allwinner/sun50i-a64-olinuxino-emmc.dts | 4 ++++ .../boot/dts/allwinner/sun50i-a64-olinuxino.dts | 16 ++++++++++++++++ 2 files changed, 20 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts +4 -0
@@ -21,3 +21,7 @@ cap-mmc-hw-reset; status = "okay"; }; + +&pio { + vcc-pc-supply = <®_eldo1>; +};
arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts +16 -0
@@ -163,6 +163,22 @@ status = "okay"; }; +&pio { + vcc-pc-supply = <®_dcdc1>; + vcc-pd-supply = <®_dcdc1>; + vcc-pe-supply = <®_aldo1>; + vcc-pg-supply = <®_dldo4>; +}; + +&r_pio { + /** + * Do not add vcc-pl-supply, since PL0 and PL1 are used + * by the RSB bus. + * + * vcc-pl-supply = <®_aldo2>; + */ +}; + &r_rsb { status = "okay";
Signature · 1 line
2.17.1
Maxime Ripard
AppliedRe: [PATCH v2 2/3] arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators
Quoted 9 lines · Stefan Mavrodiev
Allwinner A64 SoC has separate supplies for PC, PD, PE, PG and PL. This patch adds regulators for them to the pinctrl node.
Exception is PL which is used by the RSB bus. To avoid circular dependencies, VCC-PL is omitted.
On boards with eMMC, VCC-PC is supplied by ELDO1, instead of DCDC1.
Signed-off-by Stefan Mavrodiev <[email protected]>
Queued for 5.6, thanks!
Maxime
PATCH v2 3/3 arm64: dts: allwinner: a64: olinuxino: Fix SDIO supply regulator
In reply to Stefan MavrodievA64-OLinuXino uses DCDC1 (VCC-IO) for MMC1 supply. In commit 916b68cfe4b5 ("arm64: dts: a64-olinuxino: Enable RTL8723BS WiFi") ALDO2 is set, which is VCC-PL. Since DCDC1 is always present, the boards are working without a problem.
This patch sets the correct regulator.
--- arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts +1 -1
@@ -140,7 +140,7 @@ &mmc1 { pinctrl-names = "default"; pinctrl-0 = <&mmc1_pins>; - vmmc-supply = <®_aldo2>; + vmmc-supply = <®_dcdc1>; vqmmc-supply = <®_dldo4>; mmc-pwrseq = <&wifi_pwrseq>; bus-width = <4>;
Signature · 1 line
2.17.1
Maxime Ripard
AppliedRe: [PATCH v2 3/3] arm64: dts: allwinner: a64: olinuxino: Fix SDIO supply regulator
Quoted 10 lines · Stefan Mavrodiev
A64-OLinuXino uses DCDC1 (VCC-IO) for MMC1 supply. In commit
916b68cfe4b5("arm64: dts: a64-olinuxino: Enable RTL8723BS WiFi") ALDO2 is set, which is VCC-PL. Since DCDC1 is always present, the boards are working without a problem.This patch sets the correct regulator.
Fixes 916b68cfe4b5 ("arm64: dts: a64-olinuxino: Enable RTL8723BS WiFi")Cc [email protected] # v4.16+Signed-off-by Stefan Mavrodiev <[email protected]>
Applied, thanks!
Maxime