kernel: set taint flag 'L' at any kind of lockup
Subsystems (5)
PATCH 1/2 kernel: set taint flag 'L' at any kind of lockup
Any lockup or stall notifies about unexpected lack of progress. It's better to know about them for further problem investigations.
Right now only softlockup has own taint flag. Let's generalize it.
This patch renames TAINT_SOFTLOCKUP into TAINT_LOCKUP at sets it for:
- softlockup
- hardlockup
- RCU stalls
- stuck in workqueues
- detected task hung
--- Documentation/admin-guide/sysctl/kernel.rst | 2 +- Documentation/admin-guide/tainted-kernels.rst | 8 ++++++-- include/linux/kernel.h | 2 +- kernel/hung_task.c | 2 ++ kernel/panic.c | 2 +- kernel/rcu/tree_stall.h | 1 + kernel/watchdog.c | 2 +- kernel/watchdog_hld.c | 1 + kernel/workqueue.c | 1 + tools/debugging/kernel-chktaint | 2 +- 10 files changed, 16 insertions(+), 7 deletions(-)
Documentation/admin-guide/sysctl/kernel.rst +1 -1
@@ -1082,7 +1082,7 @@ ORed together. The letters are seen in "Tainted" line of Oops reports. 2048 `(I)` workaround for bug in platform firmware applied 4096 `(O)` externally-built ("out-of-tree") module was loaded 8192 `(E)` unsigned module was loaded - 16384 `(L)` soft lockup occurred + 16384 `(L)` lockup occurred 32768 `(K)` kernel has been live patched 65536 `(X)` Auxiliary taint, defined and used by for distros 131072 `(T)` The kernel was built with the struct randomization plugin
Documentation/admin-guide/tainted-kernels.rst +6 -2
@@ -96,7 +96,7 @@ Bit Log Number Reason that got the kernel tainted 11 _/I 2048 workaround for bug in platform firmware applied 12 _/O 4096 externally-built ("out-of-tree") module was loaded 13 _/E 8192 unsigned module was loaded - 14 _/L 16384 soft lockup occurred + 14 _/L 16384 lockup occurred 15 _/K 32768 kernel has been live patched 16 _/X 65536 auxiliary taint, defined for and used by distros 17 _/T 131072 kernel was built with the struct randomization plugin
@@ -152,7 +152,11 @@ More detailed explanation for tainting 13) ``E`` if an unsigned module has been loaded in a kernel supporting module signature. - 14) ``L`` if a soft lockup has previously occurred on the system. + 14) ``L`` if some kind of lockup has previously occurred on the system: + - soft/hardlockup, see Documentation/admin-guide/lockup-watchdogs.rst + - RCU stall, see Documentation/RCU/stallwarn.txt + - hung task detected, see CONFIG_DETECT_HUNG_TASK + - kernel workqueue lockup, see CONFIG_WQ_WATCHDOG 15) ``K`` if the kernel has been live patched.
include/linux/kernel.h +1 -1
@@ -591,7 +591,7 @@ extern enum system_states {#define TAINT_FIRMWARE_WORKAROUND 11#define TAINT_OOT_MODULE 12#define TAINT_UNSIGNED_MODULE 13 -#define TAINT_SOFTLOCKUP 14 +#define TAINT_LOCKUP 14#define TAINT_LIVEPATCH 15#define TAINT_AUX 16#define TAINT_RANDSTRUCT 17
kernel/hung_task.c +2 -0
@@ -139,6 +139,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout) hung_task_show_lock = true; } +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK ); +touch_nmi_watchdog (); }
kernel/panic.c +1 -1
@@ -372,7 +372,7 @@ const struct taint_flag taint_flags[TAINT_FLAGS_COUNT] = { [ TAINT_FIRMWARE_WORKAROUND ] = { 'I', ' ', false }, [ TAINT_OOT_MODULE ] = { 'O', ' ', true }, [ TAINT_UNSIGNED_MODULE ] = { 'E', ' ', true }, - [ TAINT_SOFTLOCKUP ] = { 'L', ' ', false }, + [ TAINT_LOCKUP ] = { 'L', ' ', false }, [ TAINT_LIVEPATCH ] = { 'K', ' ', true }, [ TAINT_AUX ] = { 'X', ' ', true }, [ TAINT_RANDSTRUCT ] = { 'T', ' ', true },
kernel/rcu/tree_stall.h +1 -0
@@ -74,6 +74,7 @@ early_initcall(check_cpu_stall_init);/* If so specified via sysctl, panic, yielding cleaner stall-warning output. */ static void panic_on_rcu_stall (void ) { +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK );if (sysctl_panic_on_rcu_stall)panic ("RCU Stall\n" ); }
kernel/watchdog.c +1 -1
@@ -466,7 +466,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)smp_mb__after_atomic (); } -add_taint (TAINT_SOFTLOCKUP ,LOCKDEP_STILL_OK ); +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK );if (softlockup_panic)panic ("softlockup: hung tasks" );__this_cpu_write (soft_watchdog_warn, true);
kernel/watchdog_hld.c +1 -0
@@ -152,6 +152,7 @@ static void watchdog_overflow_callback(struct perf_event *event, !test_and_set_bit(0, &hardlockup_allcpu_dumped))trigger_allbutself_cpu_backtrace (); +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK );if (hardlockup_panic)nmi_panic (regs,"Hard LOCKUP" );
kernel/workqueue.c +1 -0
@@ -5741,6 +5741,7 @@ static void wq_watchdog_timer_fn(struct timer_list *unused)pr_cont_pool_info (pool);pr_cont (" stuck for %us!\n" ,jiffies_to_msecs (jiffies - pool_ts) /1000 ); +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK ); } }
tools/debugging/kernel-chktaint +1 -1
@@ -168,7 +168,7 @@ if [ `expr $T % 2` -eq 0 ]; then addout " " else addout "L" - echo " * soft lockup occurred (#14)" + echo " * lockup occurred (#14)" fi T=`expr $T / 2`
PATCH 2/2 kernel: add sysctl kernel.nr_taints
Once taint flag is set it's never cleared. Following taint could be detected only via parsing kernel log messages which are different for each occasion. For repeatable taints like TAINT_MACHINE_CHECK, TAINT_BAD_PAGE, TAINT_DIE, TAINT_WARN, TAINT_LOCKUP it would be good to know count to see their rate.
This patch adds sysctl with vector of counters. One for each taint flag. Counters are non-atomic in favor of simplicity. Exact count doesn't matter. Writing vector of zeroes resets counters.
This is useful for detecting frequent problems with automatic monitoring.
--- include/linux/kernel.h | 1 + kernel/panic.c | 2 ++ kernel/sysctl.c | 9 +++++++++ 3 files changed, 12 insertions(+)
include/linux/kernel.h +1 -0
@@ -604,6 +604,7 @@ struct taint_flag { };extern const struct taint_flag taint_flags[TAINT_FLAGS_COUNT ]; +extern int sysctl_nr_taints[TAINT_FLAGS_COUNT ];extern const char hex_asc[];#define hex_asc_lo (x) hex_asc[((x) & 0x0f)]
kernel/panic.c +2 -0
@@ -39,6 +39,7 @@int panic_on_oops =CONFIG_PANIC_ON_OOPS_VALUE ;static unsigned long tainted_mask =IS_ENABLED (CONFIG_GCC_PLUGIN_RANDSTRUCT ) ? (1 <<TAINT_RANDSTRUCT ) :0 ; +int sysctl_nr_taints[TAINT_FLAGS_COUNT ];static int pause_on_oops;static int pause_on_oops_flag;static DEFINE_SPINLOCK (pause_on_oops_lock);
@@ -434,6 +435,7 @@ void add_taint(unsigned flag, enum lockdep_ok lockdep_ok)pr_warn ("Disabling lock debugging due to kernel taint\n" );set_bit (flag, &tainted_mask); + sysctl_nr_taints[flag]++; }EXPORT_SYMBOL (add_taint);
kernel/sysctl.c +9 -0
@@ -553,6 +553,15 @@ static struct ctl_table kern_table[] = { .mode = 0644, .proc_handler = proc_taint, }, + { + .procname = "nr_taints", + .data = &sysctl_nr_taints, + .maxlen = sizeof(sysctl_nr_taints), + .mode = 0644, + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ZERO, + .extra2 = SYSCTL_ZERO, + }, { .procname = "sysctl_writes_strict", .data = &sysctl_writes_strict,
Re: [PATCH 2/2] kernel: add sysctl kernel.nr_taints
Quoted 5 lines · Konstantin Khlebnikov
Once taint flag is set it's never cleared. Following taint could be detected only via parsing kernel log messages which are different for each occasion. For repeatable taints like
TAINT_MACHINE_CHECK,TAINT_BAD_PAGE,TAINT_DIE,TAINT_WARN,TAINT_LOCKUPit would be good to know count to see their rate.
Quoted 7 lines
This patch adds sysctl with vector of counters. One for each taint flag. Counters are non-atomic in favor of simplicity. Exact count doesn't matter. Writing vector of zeroes resets counters.
This is useful for detecting frequent problems with automatic monitoring.
Signed-off-by Konstantin Khlebnikov <[email protected]>
I like this, yeah. This would let LKDTM users reset taint counts to re-check the same kernel, etc, without explicitly clearing the taint flags which always seemed like a bad idea. :)
One nit below...
Quoted 31 lines
--- include/linux/kernel.h | 1 + kernel/panic.c | 2 ++ kernel/sysctl.c | 9 +++++++++ 3 files changed, 12 insertions(+)include/linux/kernel.h +1
-0@@ -604,6 +604,7 @@ struct taint_flag { };extern const struct taint_flag taint_flags[TAINT_FLAGS_COUNT ]; +extern int sysctl_nr_taints[TAINT_FLAGS_COUNT ];extern const char hex_asc[];#define hex_asc_lo (x) hex_asc[((x) & 0x0f)]kernel/panic.c +1
-0@@ -39,6 +39,7 @@int panic_on_oops =CONFIG_PANIC_ON_OOPS_VALUE ;static unsigned long tainted_mask =IS_ENABLED (CONFIG_GCC_PLUGIN_RANDSTRUCT ) ? (1 <<TAINT_RANDSTRUCT ) :0 ; +int sysctl_nr_taints[TAINT_FLAGS_COUNT ];static int pause_on_oops;static int pause_on_oops_flag;static DEFINE_SPINLOCK (pause_on_oops_lock);
kernel/panic.c void add_taint(unsigned flag, enum lockdep_ok lockdep_ok) · line 438
Quoted 4 lines
kernel/panic.c +1
-0@@ -434,6 +435,7 @@ void add_taint(unsigned flag, enum lockdep_ok lockdep_ok)pr_warn ("Disabling lock debugging due to kernel taint\n" );set_bit (flag, &tainted_mask); + sysctl_nr_taints[flag]++;
As long as we're changing this code, how about adding an explicit check of "flag" against either ARRAY_SIZE(sysctl_nr_tains) or TAINT_FLAGS_COUNT?
It looks like only 1 caller isn't using a static value, though:proc_taint(), so it would catch "overflows" there (it's already bounded to the size of tainted_mask, but proc could set "unknown" taint flags).
-Kees
Quoted 24 lines
kernel/panic.c +0
-0}EXPORT_SYMBOL (add_taint);kernel/sysctl.c +9
-0@@ -553,6 +553,15 @@ static struct ctl_table kern_table[] = { .mode = 0644, .proc_handler = proc_taint, }, + { + .procname = "nr_taints", + .data = &sysctl_nr_taints, + .maxlen = sizeof(sysctl_nr_taints), + .mode = 0644, + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ZERO, + .extra2 = SYSCTL_ZERO, + }, { .procname = "sysctl_writes_strict", .data = &sysctl_writes_strict,
Signature · 1 line
Kees Cook
Quoted 11 lines · Konstantin Khlebnikov
Any lockup or stall notifies about unexpected lack of progress. It's better to know about them for further problem investigations.
Right now only softlockup has own taint flag. Let's generalize it.
This patch renames
TAINT_SOFTLOCKUPintoTAINT_LOCKUPat sets it for:
- softlockup
- hardlockup
- RCU stalls
- stuck in workqueues
- detected task hung
This seems reasonable to me. The only nit I have is that it might be nicer to separate the rename from the new call sites, but if there's no v2, I'm fine with it this way.
Quoted 156 lines
Signed-off-by Konstantin Khlebnikov <[email protected]>--- Documentation/admin-guide/sysctl/kernel.rst | 2 +- Documentation/admin-guide/tainted-kernels.rst | 8 ++++++-- include/linux/kernel.h | 2 +- kernel/hung_task.c | 2 ++ kernel/panic.c | 2 +- kernel/rcu/tree_stall.h | 1 + kernel/watchdog.c | 2 +- kernel/watchdog_hld.c | 1 + kernel/workqueue.c | 1 + tools/debugging/kernel-chktaint | 2 +- 10 files changed, 16 insertions(+), 7 deletions(-)Documentation/admin-guide/sysctl/kernel.rst +1
-1@@ -1082,7 +1082,7 @@ ORed together. The letters are seen in "Tainted" line of Oops reports. 2048 `(I)` workaround for bug in platform firmware applied 4096 `(O)` externally-built ("out-of-tree") module was loaded 8192 `(E)` unsigned module was loaded - 16384 `(L)` soft lockup occurred + 16384 `(L)` lockup occurred 32768 `(K)` kernel has been live patched 65536 `(X)` Auxiliary taint, defined and used by for distros 131072 `(T)` The kernel was built with the struct randomization pluginDocumentation/admin-guide/tainted-kernels.rst +6
-2@@ -96,7 +96,7 @@ Bit Log Number Reason that got the kernel tainted 11 _/I 2048 workaround for bug in platform firmware applied 12 _/O 4096 externally-built ("out-of-tree") module was loaded 13 _/E 8192 unsigned module was loaded - 14 _/L 16384 soft lockup occurred + 14 _/L 16384 lockup occurred 15 _/K 32768 kernel has been live patched 16 _/X 65536 auxiliary taint, defined for and used by distros 17 _/T 131072 kernel was built with the struct randomization plugin@@ -152,7 +152,11 @@ More detailed explanation for tainting 13) ``E`` if an unsigned module has been loaded in a kernel supporting module signature. - 14) ``L`` if a soft lockup has previously occurred on the system. + 14) ``L`` if some kind of lockup has previously occurred on the system: + - soft/hardlockup, see Documentation/admin-guide/lockup-watchdogs.rst + - RCU stall, see Documentation/RCU/stallwarn.txt + - hung task detected, see CONFIG_DETECT_HUNG_TASK + - kernel workqueue lockup, see CONFIG_WQ_WATCHDOG 15) ``K`` if the kernel has been live patched.include/linux/kernel.h +1
-1@@ -591,7 +591,7 @@ extern enum system_states {#define TAINT_FIRMWARE_WORKAROUND 11#define TAINT_OOT_MODULE 12#define TAINT_UNSIGNED_MODULE 13 -#define TAINT_SOFTLOCKUP 14 +#define TAINT_LOCKUP 14#define TAINT_LIVEPATCH 15#define TAINT_AUX 16#define TAINT_RANDSTRUCT 17kernel/hung_task.c +2
-0@@ -139,6 +139,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout) hung_task_show_lock = true; } +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK ); +touch_nmi_watchdog (); }kernel/panic.c +1
-1@@ -372,7 +372,7 @@ const struct taint_flag taint_flags[TAINT_FLAGS_COUNT] = { [ TAINT_FIRMWARE_WORKAROUND ] = { 'I', ' ', false }, [ TAINT_OOT_MODULE ] = { 'O', ' ', true }, [ TAINT_UNSIGNED_MODULE ] = { 'E', ' ', true }, - [ TAINT_SOFTLOCKUP ] = { 'L', ' ', false }, + [ TAINT_LOCKUP ] = { 'L', ' ', false }, [ TAINT_LIVEPATCH ] = { 'K', ' ', true }, [ TAINT_AUX ] = { 'X', ' ', true }, [ TAINT_RANDSTRUCT ] = { 'T', ' ', true },kernel/rcu/tree_stall.h +1
-0@@ -74,6 +74,7 @@ early_initcall(check_cpu_stall_init);/* If so specified via sysctl, panic, yielding cleaner stall-warning output. */ static void panic_on_rcu_stall (void ) { +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK );if (sysctl_panic_on_rcu_stall)panic ("RCU Stall\n" ); }kernel/watchdog.c +1
-1@@ -466,7 +466,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)smp_mb__after_atomic (); } -add_taint (TAINT_SOFTLOCKUP ,LOCKDEP_STILL_OK ); +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK );if (softlockup_panic)panic ("softlockup: hung tasks" );__this_cpu_write (soft_watchdog_warn, true);kernel/watchdog_hld.c +1
-0@@ -152,6 +152,7 @@ static void watchdog_overflow_callback(struct perf_event *event, !test_and_set_bit(0, &hardlockup_allcpu_dumped))trigger_allbutself_cpu_backtrace (); +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK );if (hardlockup_panic)nmi_panic (regs,"Hard LOCKUP" );kernel/workqueue.c +1
-0@@ -5741,6 +5741,7 @@ static void wq_watchdog_timer_fn(struct timer_list *unused)pr_cont_pool_info (pool);pr_cont (" stuck for %us!\n" ,jiffies_to_msecs (jiffies - pool_ts) /1000 ); +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK ); } }tools/debugging/kernel-chktaint +1
-1@@ -168,7 +168,7 @@ if [ `expr $T % 2` -eq 0 ]; then addout " " else addout "L" - echo " * soft lockup occurred (#14)" + echo " * lockup occurred (#14)" fi T=`expr $T / 2`
Signature · 1 line
Kees Cook
Quoted 5 lines · Konstantin Khlebnikov
Any lockup or stall notifies about unexpected lack of progress. It's better to know about them for further problem investigations.
Right now only softlockup has own taint flag. Let's generalize it.
Quoted 8 lines
This patch renames
TAINT_SOFTLOCKUPintoTAINT_LOCKUPat sets it for:
- softlockup
- hardlockup
- RCU stalls
- stuck in workqueues
- detected task hungSigned-off-by Konstantin Khlebnikov <[email protected]>
From an RCU perspective,
Quoted 154 lines
--- Documentation/admin-guide/sysctl/kernel.rst | 2 +- Documentation/admin-guide/tainted-kernels.rst | 8 ++++++-- include/linux/kernel.h | 2 +- kernel/hung_task.c | 2 ++ kernel/panic.c | 2 +- kernel/rcu/tree_stall.h | 1 + kernel/watchdog.c | 2 +- kernel/watchdog_hld.c | 1 + kernel/workqueue.c | 1 + tools/debugging/kernel-chktaint | 2 +- 10 files changed, 16 insertions(+), 7 deletions(-)Documentation/admin-guide/sysctl/kernel.rst +1
-1@@ -1082,7 +1082,7 @@ ORed together. The letters are seen in "Tainted" line of Oops reports. 2048 `(I)` workaround for bug in platform firmware applied 4096 `(O)` externally-built ("out-of-tree") module was loaded 8192 `(E)` unsigned module was loaded - 16384 `(L)` soft lockup occurred + 16384 `(L)` lockup occurred 32768 `(K)` kernel has been live patched 65536 `(X)` Auxiliary taint, defined and used by for distros 131072 `(T)` The kernel was built with the struct randomization pluginDocumentation/admin-guide/tainted-kernels.rst +6
-2@@ -96,7 +96,7 @@ Bit Log Number Reason that got the kernel tainted 11 _/I 2048 workaround for bug in platform firmware applied 12 _/O 4096 externally-built ("out-of-tree") module was loaded 13 _/E 8192 unsigned module was loaded - 14 _/L 16384 soft lockup occurred + 14 _/L 16384 lockup occurred 15 _/K 32768 kernel has been live patched 16 _/X 65536 auxiliary taint, defined for and used by distros 17 _/T 131072 kernel was built with the struct randomization plugin@@ -152,7 +152,11 @@ More detailed explanation for tainting 13) ``E`` if an unsigned module has been loaded in a kernel supporting module signature. - 14) ``L`` if a soft lockup has previously occurred on the system. + 14) ``L`` if some kind of lockup has previously occurred on the system: + - soft/hardlockup, see Documentation/admin-guide/lockup-watchdogs.rst + - RCU stall, see Documentation/RCU/stallwarn.txt + - hung task detected, see CONFIG_DETECT_HUNG_TASK + - kernel workqueue lockup, see CONFIG_WQ_WATCHDOG 15) ``K`` if the kernel has been live patched.include/linux/kernel.h +1
-1@@ -591,7 +591,7 @@ extern enum system_states {#define TAINT_FIRMWARE_WORKAROUND 11#define TAINT_OOT_MODULE 12#define TAINT_UNSIGNED_MODULE 13 -#define TAINT_SOFTLOCKUP 14 +#define TAINT_LOCKUP 14#define TAINT_LIVEPATCH 15#define TAINT_AUX 16#define TAINT_RANDSTRUCT 17kernel/hung_task.c +2
-0@@ -139,6 +139,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout) hung_task_show_lock = true; } +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK ); +touch_nmi_watchdog (); }kernel/panic.c +1
-1@@ -372,7 +372,7 @@ const struct taint_flag taint_flags[TAINT_FLAGS_COUNT] = { [ TAINT_FIRMWARE_WORKAROUND ] = { 'I', ' ', false }, [ TAINT_OOT_MODULE ] = { 'O', ' ', true }, [ TAINT_UNSIGNED_MODULE ] = { 'E', ' ', true }, - [ TAINT_SOFTLOCKUP ] = { 'L', ' ', false }, + [ TAINT_LOCKUP ] = { 'L', ' ', false }, [ TAINT_LIVEPATCH ] = { 'K', ' ', true }, [ TAINT_AUX ] = { 'X', ' ', true }, [ TAINT_RANDSTRUCT ] = { 'T', ' ', true },kernel/rcu/tree_stall.h +1
-0@@ -74,6 +74,7 @@ early_initcall(check_cpu_stall_init);/* If so specified via sysctl, panic, yielding cleaner stall-warning output. */ static void panic_on_rcu_stall (void ) { +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK );if (sysctl_panic_on_rcu_stall)panic ("RCU Stall\n" ); }kernel/watchdog.c +1
-1@@ -466,7 +466,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)smp_mb__after_atomic (); } -add_taint (TAINT_SOFTLOCKUP ,LOCKDEP_STILL_OK ); +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK );if (softlockup_panic)panic ("softlockup: hung tasks" );__this_cpu_write (soft_watchdog_warn, true);kernel/watchdog_hld.c +1
-0@@ -152,6 +152,7 @@ static void watchdog_overflow_callback(struct perf_event *event, !test_and_set_bit(0, &hardlockup_allcpu_dumped))trigger_allbutself_cpu_backtrace (); +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK );if (hardlockup_panic)nmi_panic (regs,"Hard LOCKUP" );kernel/workqueue.c +1
-0@@ -5741,6 +5741,7 @@ static void wq_watchdog_timer_fn(struct timer_list *unused)pr_cont_pool_info (pool);pr_cont (" stuck for %us!\n" ,jiffies_to_msecs (jiffies - pool_ts) /1000 ); +add_taint (TAINT_LOCKUP ,LOCKDEP_STILL_OK ); } }tools/debugging/kernel-chktaint +1
-1@@ -168,7 +168,7 @@ if [ `expr $T % 2` -eq 0 ]; then addout " " else addout "L" - echo " * soft lockup occurred (#14)" + echo " * lockup occurred (#14)" fi T=`expr $T / 2`
Quoted 6 lines · Konstantin Khlebnikov
Any lockup or stall notifies about unexpected lack of progress. It's better to know about them for further problem investigations.
Right now only softlockup has own taint flag. Let's generalize it.
This patch renames
TAINT_SOFTLOCKUPintoTAINT_LOCKUPat sets it for:
Please search 'This patch' in Documentation/process/submitting-patches.rst
Quoted 5 lines
- softlockup
- hardlockup
- RCU stalls
- stuck in workqueues
- detected task hung
This does too many things at once and wants to be split in pieces:
1) Change the TAINT flag and update documentation
2) Add the tainting to the places which are not yet covered
Thanks,
tglx