updates for hns3 PMD driver
cover updates for hns3 PMD driver
From: "Wei Hu (Xavier)" <[email protected]>
This series are updates for hns3 ethernet PMD driver.
Hao Chen (4):
net/hns3: support Rx interrupt
net/hns3: optimize RSS's default algorithm
net/hns3: remove the redundant function call
net/hns3: remove the unused macros
Hongbo Zheng (1):
net/hns3: get link state change through mailbox
Huisong Li (1):
net/hns3: modify custom macro
Wei Hu (Xavier) (3):
net/hns3: modify the return value of enable msix net/hns3: remove the redundant variable initialization net/hns3: remove the unnecessary assignment
doc/guides/nics/features/hns3.ini | 1 + doc/guides/nics/features/hns3_vf.ini | 1 + drivers/net/hns3/hns3_cmd.h | 28 +++++ drivers/net/hns3/hns3_ethdev.c | 176 ++++++++++++++++++++++++--- drivers/net/hns3/hns3_ethdev.h | 2 +- drivers/net/hns3/hns3_ethdev_vf.c | 167 ++++++++++++++++++++++--- drivers/net/hns3/hns3_mbx.c | 37 ++++++ drivers/net/hns3/hns3_mbx.h | 21 ++++ drivers/net/hns3/hns3_regs.h | 3 + drivers/net/hns3/hns3_rss.c | 14 ++- drivers/net/hns3/hns3_rss.h | 10 -- drivers/net/hns3/hns3_rxtx.c | 58 ++++++++- drivers/net/hns3/hns3_rxtx.h | 4 + 13 files changed, 473 insertions(+), 49 deletions(-)
Signature · 1 line
2.23.0
PATCH 1/9 net/hns3: support Rx interrupt
From: Hao Chen <[email protected]>
This patch supports of receive packets through interrupt mode for hns3 PF/VF driver. The following ops functions should be implemented defined in struct eth_dev_ops:rx_queue_intr_enablerx_queue_intr_disablerx_queue_count
--- doc/guides/nics/features/hns3.ini | 1 + doc/guides/nics/features/hns3_vf.ini | 1 + drivers/net/hns3/hns3_cmd.h | 28 +++++ drivers/net/hns3/hns3_ethdev.c | 160 ++++++++++++++++++++++++-- drivers/net/hns3/hns3_ethdev_vf.c | 166 ++++++++++++++++++++++++--- drivers/net/hns3/hns3_mbx.h | 13 +++ drivers/net/hns3/hns3_regs.h | 3 + drivers/net/hns3/hns3_rxtx.c | 51 ++++++++ drivers/net/hns3/hns3_rxtx.h | 4 + 9 files changed, 405 insertions(+), 22 deletions(-)
doc/guides/nics/features/hns3.ini +1 -0
@@ -5,6 +5,7 @@ ; [Features] Link status = Y +Rx interrupt = Y MTU update = Y Jumbo frame = Y Promiscuous mode = Y
doc/guides/nics/features/hns3_vf.ini +1 -0
@@ -5,6 +5,7 @@ ; [Features] Link status = Y +Rx interrupt = Y MTU update = Y Jumbo frame = Y Unicast MAC filter = Y
drivers/net/hns3/hns3_cmd.h +28 -0
@@ -209,6 +209,10 @@ enum hns3_opcode_type {/* SFP command */ HNS3_OPC_SFP_GET_SPEED =0x7104 , +/* Interrupts commands */ +HNS3_OPC_ADD_RING_TO_VECTOR =0x1503 , +HNS3_OPC_DEL_RING_TO_VECTOR =0x1504 , +/* Error INT commands */ HNS3_QUERY_MSIX_INT_STS_BD_NUM =0x1513 , HNS3_QUERY_CLEAR_ALL_MPF_MSIX_INT = 0x1514,
@@ -673,6 +677,30 @@ struct hns3_tqp_map_cmd {uint8_t rsv[18 ]; }; +#define HNS3_RING_TYPE_B 0 +#define HNS3_RING_TYPE_TX 0 +#define HNS3_RING_TYPE_RX 1 +#define HNS3_RING_GL_IDX_S 0 +#define HNS3_RING_GL_IDX_M GENMASK(1, 0) +#define HNS3_RING_GL_RX 0 +#define HNS3_RING_GL_TX 1 + +#define HNS3_VECTOR_ELEMENTS_PER_CMD 10 + +#define HNS3_INT_TYPE_S 0 +#define HNS3_INT_TYPE_M GENMASK(1, 0) +#define HNS3_TQP_ID_S 2 +#define HNS3_TQP_ID_M GENMASK(12, 2) +#define HNS3_INT_GL_IDX_S 13 +#define HNS3_INT_GL_IDX_M GENMASK(14, 13) +struct hns3_ctrl_vector_chain_cmd { +uint8_t int_vector_id; +uint8_t int_cause_num; +uint16_t tqp_type_and_id[HNS3_VECTOR_ELEMENTS_PER_CMD ]; +uint8_t vfid; +uint8_t rsv; +}; +struct hns3_config_max_frm_size_cmd {uint16_t max_frm_size;uint8_t min_frm_size;
drivers/net/hns3/hns3_ethdev.c +151 -9
210 lines not on this page · raw message
drivers/net/hns3/hns3_ethdev_vf.c +153 -13
217 lines not on this page · raw message
drivers/net/hns3/hns3_mbx.h +13 -0
@@ -104,6 +104,19 @@ struct hns3_mbx_pf_to_vf_cmd {uint16_t msg[8 ]; }; +struct hns3_ring_chain_param { +uint8_t ring_type; +uint8_t tqp_index; +uint8_t int_gl_index; +}; + +#define HNS3_MBX_MAX_RING_CHAIN_PARAM_NUM 4 +struct hns3_vf_bind_vector_msg { +uint8_t vector_id; +uint8_t ring_num; +struct hns3_ring_chain_param param[HNS3_MBX_MAX_RING_CHAIN_PARAM_NUM ]; +}; +struct hns3_vf_rst_cmd {uint8_t dest_vfid;uint8_t vf_rst;
drivers/net/hns3/hns3_regs.h +3 -0
@@ -83,6 +83,9 @@#define HNS3_RING_EN_B 0 +#define HNS3_VECTOR_REG_OFFSET 0x4 +#define HNS3_VECTOR_VF_OFFSET 0x100000 +#define HNS3_TQP_REG_OFFSET 0x80000#define HNS3_TQP_REG_SIZE 0x200
drivers/net/hns3/hns3_rxtx.c +51 -0
57 lines not on this page · raw message
drivers/net/hns3/hns3_rxtx.h +4 -0
@@ -295,6 +295,9 @@ void hns3_dev_rx_queue_release(void *queue);void hns3_dev_tx_queue_release (void *queue);void hns3_free_all_queues (struct rte_eth_dev *dev);int hns3_reset_all_queues (struct hns3_adapter *hns); +uint32_t hns3_dev_rx_queue_count (struct rte_eth_dev *dev,uint16_t rx_queue_id); +int hns3_dev_rx_queue_intr_enable (struct rte_eth_dev *dev,uint16_t queue_id); +int hns3_dev_rx_queue_intr_disable (struct rte_eth_dev *dev,uint16_t queue_id);int hns3_start_queues (struct hns3_adapter *hns,bool reset_queue);int hns3_stop_queues (struct hns3_adapter *hns,bool reset_queue);void hns3_dev_release_mbufs (struct hns3_adapter *hns);
@@ -311,4 +314,5 @@ uint16_t hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts);const uint32_t *hns3_dev_supported_ptypes_get (struct rte_eth_dev *dev);void hns3_set_rxtx_function (struct rte_eth_dev *eth_dev); +void hns3_tqp_intr_enable (struct hns3_hw *hw,uint16_t tpq_int_num,bool en);#endif /* _HNS3_RXTX_H_ */
Signature · 1 line
2.23.0
PATCH 2/9 net/hns3: get link state change through mailbox
In reply to Wei Hu (Xavier)From: Hongbo Zheng <[email protected]>
When link down occurs, firmware adds the function of sending message to PF driver through mailbox, hns3 PMD driver can recognize link state change faster through the message.
--- drivers/net/hns3/hns3_ethdev.c | 8 ++++++-- drivers/net/hns3/hns3_ethdev.h | 1 + drivers/net/hns3/hns3_mbx.c | 37 ++++++++++++++++++++++++++++++++++ drivers/net/hns3/hns3_mbx.h | 8 ++++++++ 4 files changed, 52 insertions(+), 2 deletions(-)
drivers/net/hns3/hns3_ethdev.c +6 -2
@@ -218,6 +218,8 @@ hns3_interrupt_handler(void *param)hns3_schedule_reset (hns); }else if (event_cause ==HNS3_VECTOR0_EVENT_RST )hns3_schedule_reset (hns); +else if (event_cause ==HNS3_VECTOR0_EVENT_MBX ) +hns3_dev_handle_mbx_msg (hw);else hns3_err (hw,"Received unknown event" );
@@ -3806,14 +3808,16 @@ hns3_get_mac_link_status(struct hns3_hw *hw)return !!link_status; } -static void +void hns3_update_link_status (struct hns3_hw *hw) {int state; state =hns3_get_mac_link_status (hw); -if (state != hw->mac.link_status) +if (state != hw->mac.link_status) { hw->mac.link_status = state; +hns3_warn (hw,"Link status change to %s!" , state ?"up" :"down" ); + } } static void
drivers/net/hns3/hns3_ethdev.h +1 -0
@@ -631,6 +631,7 @@ int hns3_dev_filter_ctrl(struct rte_eth_dev *dev, enum rte_filter_op filter_op, void *arg);bool hns3_is_reset_pending (struct hns3_adapter *hns);bool hns3vf_is_reset_pending (struct hns3_adapter *hns); +void hns3_update_link_status (struct hns3_hw *hw);static inline bool is_reset_pending (struct hns3_adapter *hns)
drivers/net/hns3/hns3_mbx.c +37 -0
@@ -282,6 +282,40 @@ hns3_update_resp_position(struct hns3_hw *hw, uint32_t resp_msg) resp->tail = tail; } +static void +hns3_link_fail_parse (struct hns3_hw *hw,uint8_t link_fail_code) +{ +switch (link_fail_code) { +case HNS3_MBX_LF_NORMAL : +break ; +case HNS3_MBX_LF_REF_CLOCK_LOST : +hns3_warn (hw,"Reference clock lost!" ); +break ; +case HNS3_MBX_LF_XSFP_TX_DISABLE : +hns3_warn (hw,"SFP tx is disabled!" ); +break ; +case HNS3_MBX_LF_XSFP_ABSENT : +hns3_warn (hw,"SFP is absent!" ); +break ; +default : +hns3_warn (hw,"Unknown fail code:%u!" , link_fail_code); +break ; + } +} + +static void +hns3_handle_link_change_event (struct hns3_hw *hw, +struct hns3_mbx_pf_to_vf_cmd *req) +{ +#define LINK_STATUS_OFFSET 1 +#define LINK_FAIL_CODE_OFFSET 2 + +if (!req->msg[LINK_STATUS_OFFSET ]) +hns3_link_fail_parse (hw, req->msg[LINK_FAIL_CODE_OFFSET ]); + +hns3_update_link_status (hw); +} +void hns3_dev_handle_mbx_msg (struct hns3_hw *hw) {
@@ -335,6 +369,9 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)hns3_mbx_handler (hw);break ; +case HNS3_MBX_PUSH_LINK_STATUS : +hns3_handle_link_change_event (hw, req); +break ;default : hns3_err(hw, "VF received unsupported(%d) mbx msg from PF",
drivers/net/hns3/hns3_mbx.h +8 -0
@@ -41,6 +41,7 @@ enum HNS3_MBX_OPCODE {HNS3_MBX_GET_QID_IN_PF ,/* (VF -> PF) get queue id in pf */ HNS3_MBX_HANDLE_VF_TBL =38 ,/* (VF -> PF) store/clear hw cfg tbl */ + HNS3_MBX_PUSH_LINK_STATUS = 201, /* (IMP -> PF) get port link status */ };/* below are per-VF mac-vlan subcodes */
@@ -64,6 +65,13 @@ enum hns3_mbx_tbl_cfg_subcode { HNS3_MBX_VPORT_LIST_CLEAR = 0, }; +enum hns3_mbx_link_fail_subcode { +HNS3_MBX_LF_NORMAL =0 , +HNS3_MBX_LF_REF_CLOCK_LOST , +HNS3_MBX_LF_XSFP_TX_DISABLE , +HNS3_MBX_LF_XSFP_ABSENT , +}; +#define HNS3_MBX_MAX_MSG_SIZE 16#define HNS3_MBX_MAX_RESP_DATA_SIZE 8#define HNS3_MBX_RING_MAP_BASIC_MSG_NUM 3
Signature · 1 line
2.23.0