Skip to contentSkip to conversation

add support for videostrong KII Pro

PATCH Superseded Mohammad Rasim 2 participants 13 messages Nov 30, 2019

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover add support for videostrong KII Pro

This patchset adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design.

Device specifications:
- SOC: Amlogic S905
- RAM: 2GB DDR3
- Storage: 16GB
- Connectivity:
- 10/100M Ethernet (IC Plus IP101GR)
- 802.11 b/g/n/ac Wi-Fi (Ampak AP6335 BT/WIFI combo)
- Bluetooth 4.0 (Ampak AP6335 BT/WIFI combo)
- Video out: HDMI 2.0 up to 4K @ 60Hz, and 3.5mm AV (composite video) jack
- Audio out: HDMI, AV (stereo audio) and optical S/PDIF
- Tuner: AVL6862 DVB-C/T/T2 + DVB-S/S2 demod and Rafael Micro R848 tuner
- Ports:
- x1 micro SD card slot up to 32GB
- 4x USB 2.0 host ports
- Misc:
- Power button and LED, IR receiver

Changes since RFC v1:
- add commit description to the cover letter
- update bluetooth bindings
- use lowercase name for the dts filename,vendor prefix and compatible
- add copyrights to the new files
- include "meson-gxbb-p20x.dtsi" instead of "meson-gxbb-p201.dts"

Changes since RFC v2:
- Fix styling issues

Changes since v1:
- add leds node to the device tree
- add gpio-keys-polled node to the device tree

Changes since v2:
- use phy-handle to describe the phy
- The blutooth compatible is now merged,change the commit message accordingly

Mohammad Rasim (2):
dt-bindings: Add vendor prefix for Videostrong
arm64: dts: meson-gxbb: add support for Videostrong KII Pro

 .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
 arch/arm64/boot/dts/amlogic/Makefile          |  1 +
 .../boot/dts/amlogic/meson-gxbb-kii-pro.dts   | 76 +++++++++++++++++++
 3 files changed, 79 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts

--
2.24.0

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

#1 lore raw

PATCH v3 1/2 dt-bindings: Add vendor prefix for Videostrong

Videostrong Technology Co., Ltd., A manufacturer of Android Players & STB (Android with DVB Hybrid box & DVB-T2/S2/C/ISDB-T/DTMB-TH/ATSC )as well as HD media players.

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index fd6fa07c45b8..a6c83d70aa74 100644
@@ -1008,6 +1008,8 @@ patternProperties:
     description: Variscite Ltd.
   "^via,.*":
     description: VIA Technologies, Inc.
+  "^videostrong,.*":
+    description: Videostrong Technology Co., Ltd.
   "^virtio,.*":
     description: Virtual I/O Device Specification, developed by the OASIS consortium
   "^vishay,.*":

--
2.24.0

reviewer Acked-by on v3 1/2
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: Add vendor prefix for Videostrong

Hi Mohammad,

Quoted 3 lines · Mohammad Rasim

Videostrong Technology Co., Ltd., A manufacturer of Android Players & STB (Android with DVB Hybrid box & DVB-T2/S2/C/ISDB-T/DTMB-TH/ATSC )as well as

the space after ATSC should be after the ")"

Quoted 3 lines

HD media players.

with above typo fixed:

#3 lore raw

Re: [PATCH v3 1/2] dt-bindings: Add vendor prefix for Videostrong

Quoted 9 lines · Martin Blumenstingl

Hi Mohammad,

Quoted 3 lines · Mohammad Rasim

Videostrong Technology Co., Ltd., A manufacturer of Android Players & STB (Android with DVB Hybrid box & DVB-T2/S2/C/ISDB-T/DTMB-TH/ATSC )as well as

the space after ATSC should be after the ")"

Thanks, will fix that

Quoted 5 lines
Quoted 3 lines

HD media players.

with above typo fixed:

#4 lore raw

PATCH v3 2/2 arm64: dts: meson-gxbb: add support for

In reply to Mohammad Rasim

This patch adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design

The device tree includes a new compatible for bluetooth "brcm,bcm4335a0" which was merged recently into torvalds tree

---
 arch/arm64/boot/dts/amlogic/Makefile          |  1 +
 .../boot/dts/amlogic/meson-gxbb-kii-pro.dts   | 76 +++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
arch/arm64/boot/dts/amlogic/Makefile +1 -0
index 84afecba9ec0..a795a170dcab 100644
@@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +76 -0

76 lines not on this page · raw message

--
2.24.0

reviewer Reviewed-by on v3 2/2
#5 lore raw

Re: [PATCH v3 2/2] arm64: dts: meson-gxbb: add support for

Hi Mohammad,

this patch should be third in the series.
the currently missing patch for the dt-bindings should be patch two. you can take the following commit as an example:
effdd8a6b6ecb30b088f36ed0a1fb67cdc7610a9 ("dt-bindings: arm: amlogic:
add SEI Robotics SEI610 bindings")

Quoted 41 lines · Mohammad Rasim

This patch adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design

The device tree includes a new compatible for bluetooth "brcm,bcm4335a0" which was merged recently into torvalds tree

---
 arch/arm64/boot/dts/amlogic/Makefile          |  1 +
 .../boot/dts/amlogic/meson-gxbb-kii-pro.dts   | 76 +++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
arch/arm64/boot/dts/amlogic/Makefile +1 -0
index 84afecba9ec0..a795a170dcab 100644
@@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +9 -0
new file mode 100644
index 000000000000..5d120e6ca338
@@ -0,0 +1,76 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 Mohammad Rasim <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "meson-gxbb-p20x.dtsi"
+

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 19

Quoted 10 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +10 -0
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+/ {
+       compatible = "videostrong,kii-pro", "amlogic,p201", "amlogic,s905", "amlogic,meson-gxbb";
+       model = "Videostrong KII Pro";
+
+       leds {
+               compatible = "gpio-leds";
+               red {
+                       label = "status";

this property seems to be deprecated now, see Documentation/devicetree/bindings/leds/common.txt
but I'm not sure whether Kevin has made a decision yet when to not accept "label" properties here anymore

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 31

Quoted 12 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +12 -0
+                       gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
+                       default-state = "off";
+               };
+       };
+
+       gpio-keys-polled {
+               compatible = "gpio-keys-polled";
+               #address-cells = <1>;
+               #size-cells = <0>;
+               poll-interval = <20>;
+
+               button@0 {

please name this button-reset (even though we've done it wrong for other boards in the past)
@0 indicates a unit-address, but the button has no address

Quoted 33 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +33 -0
+                       label = "reset";
+                       linux,code = <KEY_POWER>;
+                       gpios = <&gpio_ao GPIOAO_3 GPIO_ACTIVE_HIGH>;
+               };
+       };
+
+};
+
+
+
+&uart_A {
+       status = "okay";
+       pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
+       pinctrl-names = "default";
+       uart-has-rtscts;
+
+       bluetooth {
+               compatible = "brcm,bcm4335a0";
+       };
+};
+
+
+
+&ethmac {
+       status = "okay";
+       pinctrl-0 = <&eth_rmii_pins>;
+       pinctrl-names = "default";
+
+       phy-handle = <&eth_phy0>;
+       phy-mode = "rmii";
+
+       mdio {
+               compatible = "snps,dwmac-mdio";

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 74

Quoted 10 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +10 -0
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               eth_phy0: ethernet-phy@0 {
+                       /* IC Plus IP101GR (0x02430c54) */
+                       reg = <0>;
+                       reset-assert-us = <10000>;
+                       reset-deassert-us = <10000>;
+                       reset-gpios = <&gpio GPIOZ_14 GPIO_ACTIVE_LOW>;
+               };

thank you for switching to the new PHY bindings :)

assuming Kevin still accepts the LED "label" and you rename the button node then you can add my:

(don't forget that we still need an additional dt-bindings patch though)

Martin

#6 lore raw

Re: [PATCH v3 2/2] arm64: dts: meson-gxbb: add support for

Quoted 57 lines · Martin Blumenstingl

Hi Mohammad,

this patch should be third in the series.
the currently missing patch for the dt-bindings should be patch two. you can take the following commit as an example:
effdd8a6b6ecb30b088f36ed0a1fb67cdc7610a9 ("dt-bindings: arm: amlogic:
add SEI Robotics SEI610 bindings")

Quoted 47 lines · Mohammad Rasim

This patch adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design

The device tree includes a new compatible for bluetooth "brcm,bcm4335a0" which was merged recently into torvalds tree

---
 arch/arm64/boot/dts/amlogic/Makefile          |  1 +
 .../boot/dts/amlogic/meson-gxbb-kii-pro.dts   | 76 +++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
arch/arm64/boot/dts/amlogic/Makefile +1 -0
index 84afecba9ec0..a795a170dcab 100644
@@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +15 -0
new file mode 100644
index 000000000000..5d120e6ca338
@@ -0,0 +1,76 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 Mohammad Rasim <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "meson-gxbb-p20x.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+/ {
+       compatible = "videostrong,kii-pro", "amlogic,p201", "amlogic,s905", "amlogic,meson-gxbb";
+       model = "Videostrong KII Pro";
+
Quoted 8 lines

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 19

Quoted 4 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +4 -0
+       leds {
+               compatible = "gpio-leds";
+               red {
+                       label = "status";

this property seems to be deprecated now, see Documentation/devicetree/bindings/leds/common.txt
but I'm not sure whether Kevin has made a decision yet when to not accept "label" properties here anymore

OK, I will remove the deprecated property
but I'm not sure what should I choose as a function, LED_FUNCTION_STATUS or LED_FUNCTION_ACTIVITY ?

Quoted 16 lines

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 31

Quoted 13 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +12 -0
+                       gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
+                       default-state = "off";
+               };
+       };
+
+       gpio-keys-polled {
+               compatible = "gpio-keys-polled";
+               #address-cells = <1>;
+               #size-cells = <0>;
+               poll-interval = <20>;
+
+               button@0 {

please name this button-reset (even though we've done it wrong for other boards in the past)
@0 indicates a unit-address, but the button has no address

Ok, will fix it in the next version

Quoted 46 lines
Quoted 34 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +33 -0
+                       label = "reset";
+                       linux,code = <KEY_POWER>;
+                       gpios = <&gpio_ao GPIOAO_3 GPIO_ACTIVE_HIGH>;
+               };
+       };
+
+};
+
+
+
+&uart_A {
+       status = "okay";
+       pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
+       pinctrl-names = "default";
+       uart-has-rtscts;
+
+       bluetooth {
+               compatible = "brcm,bcm4335a0";
+       };
+};
+
+
+
+&ethmac {
+       status = "okay";
+       pinctrl-0 = <&eth_rmii_pins>;
+       pinctrl-names = "default";
+
+       phy-handle = <&eth_phy0>;
+       phy-mode = "rmii";
+
+       mdio {
+               compatible = "snps,dwmac-mdio";

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 74

Quoted 10 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +10 -0
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               eth_phy0: ethernet-phy@0 {
+                       /* IC Plus IP101GR (0x02430c54) */
+                       reg = <0>;
+                       reset-assert-us = <10000>;
+                       reset-deassert-us = <10000>;
+                       reset-gpios = <&gpio GPIOZ_14 GPIO_ACTIVE_LOW>;
+               };

thank you for switching to the new PHY bindings :)

Quoted 5 lines

assuming Kevin still accepts the LED "label" and you rename the button node then you can add my:

(don't forget that we still need an additional dt-bindings patch though)

I'm sending a new version anyways so I will remove the lable property

Thanks

Quoted 2 lines

Martin

#7 lore raw

Re: [PATCH v3 2/2] arm64: dts: meson-gxbb: add support for

Quoted 67 lines · Mohammad Rasim
Quoted 57 lines · Martin Blumenstingl

Hi Mohammad,

this patch should be third in the series.
the currently missing patch for the dt-bindings should be patch two. you can take the following commit as an example:
effdd8a6b6ecb30b088f36ed0a1fb67cdc7610a9 ("dt-bindings: arm: amlogic:
add SEI Robotics SEI610 bindings")

Quoted 47 lines · Mohammad Rasim

This patch adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design

The device tree includes a new compatible for bluetooth "brcm,bcm4335a0" which was merged recently into torvalds tree

---
 arch/arm64/boot/dts/amlogic/Makefile          |  1 +
 .../boot/dts/amlogic/meson-gxbb-kii-pro.dts   | 76 +++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
arch/arm64/boot/dts/amlogic/Makefile +1 -0
index 84afecba9ec0..a795a170dcab 100644
@@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +15 -0
new file mode 100644
index 000000000000..5d120e6ca338
@@ -0,0 +1,76 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 Mohammad Rasim <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "meson-gxbb-p20x.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+/ {
+       compatible = "videostrong,kii-pro", "amlogic,p201", "amlogic,s905", "amlogic,meson-gxbb";
+       model = "Videostrong KII Pro";
+
Quoted 8 lines

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 19

Quoted 4 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +4 -0
+       leds {
+               compatible = "gpio-leds";
+               red {
+                       label = "status";

this property seems to be deprecated now, see Documentation/devicetree/bindings/leds/common.txt
but I'm not sure whether Kevin has made a decision yet when to not accept "label" properties here anymore

Quoted 3 lines

OK, I will remove the deprecated property
but I'm not sure what should I choose as a function, LED_FUNCTION_STATUS or LED_FUNCTION_ACTIVITY ?

I haven't used function and color myself but I believe it works like this (untested):
- add an #include <dt-bindings/leds/common.h> next to the other #includes (keep alphabetical ordering). this include file also contains all the #defines for color and function
- add a color property, for example: color = <LED_COLOR_ID_RED>;
- add a function property, for example: function = <LED_FUNCTION_STATUS>;
- test, debug and fix potential issues ;)

Martin

#8 lore raw

Re: [PATCH v3 2/2] arm64: dts: meson-gxbb: add support for

Quoted 72 lines · Martin Blumenstingl
Quoted 67 lines · Mohammad Rasim
Quoted 57 lines · Martin Blumenstingl

Hi Mohammad,

this patch should be third in the series.
the currently missing patch for the dt-bindings should be patch two. you can take the following commit as an example:
effdd8a6b6ecb30b088f36ed0a1fb67cdc7610a9 ("dt-bindings: arm: amlogic:
add SEI Robotics SEI610 bindings")

Quoted 47 lines · Mohammad Rasim

This patch adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design

The device tree includes a new compatible for bluetooth "brcm,bcm4335a0" which was merged recently into torvalds tree

---
 arch/arm64/boot/dts/amlogic/Makefile          |  1 +
 .../boot/dts/amlogic/meson-gxbb-kii-pro.dts   | 76 +++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
arch/arm64/boot/dts/amlogic/Makefile +1 -0
index 84afecba9ec0..a795a170dcab 100644
@@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +15 -0
new file mode 100644
index 000000000000..5d120e6ca338
@@ -0,0 +1,76 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 Mohammad Rasim <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "meson-gxbb-p20x.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+/ {
+       compatible = "videostrong,kii-pro", "amlogic,p201", "amlogic,s905", "amlogic,meson-gxbb";
+       model = "Videostrong KII Pro";
+
Quoted 8 lines

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 19

Quoted 4 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +4 -0
+       leds {
+               compatible = "gpio-leds";
+               red {
+                       label = "status";

this property seems to be deprecated now, see Documentation/devicetree/bindings/leds/common.txt
but I'm not sure whether Kevin has made a decision yet when to not accept "label" properties here anymore

Quoted 3 lines

OK, I will remove the deprecated property
but I'm not sure what should I choose as a function, LED_FUNCTION_STATUS or LED_FUNCTION_ACTIVITY ?

Quoted 8 lines

I haven't used function and color myself but I believe it works like this (untested):
- add an #include <dt-bindings/leds/common.h> next to the other #includes (keep alphabetical ordering). this include file also contains all the #defines for color and function
- add a color property, for example: color = <LED_COLOR_ID_RED>;
- add a function property, for example: function = <LED_FUNCTION_STATUS>;
- test, debug and fix potential issues ;)

Yes, I've already tested it but I'm just not sure what should be in the function property, LED_FUNCTION_STATUS and LED_FUNCTION_ACTIVITY both seem like good choices,
in my tests this property was prepended to the label
So the following:

		status {
			gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
			default-state = "off";
			color = <LED_COLOR_ID_RED>;
			function = LED_FUNCTION_STATUS;
		};

resulted in a led labeled red:status
[root@alarm ~]# ls /sys/class/leds/
input1::capslock input1::numlock input1::scrolllock red:status

if this property only used to lable the led then LED_FUNCTION_STATUS is ok, but maybe this is used by userspace to trigger the led ?!

Regards

Quoted 3 lines

Martin

#9 lore raw

Re: [PATCH v3 2/2] arm64: dts: meson-gxbb: add support for

Quoted 81 lines · Mohammad Rasim
Quoted 72 lines · Martin Blumenstingl
Quoted 67 lines · Mohammad Rasim
Quoted 57 lines · Martin Blumenstingl

Hi Mohammad,

this patch should be third in the series.
the currently missing patch for the dt-bindings should be patch two. you can take the following commit as an example:
effdd8a6b6ecb30b088f36ed0a1fb67cdc7610a9 ("dt-bindings: arm: amlogic:
add SEI Robotics SEI610 bindings")

Quoted 47 lines · Mohammad Rasim

This patch adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design

The device tree includes a new compatible for bluetooth "brcm,bcm4335a0" which was merged recently into torvalds tree

---
 arch/arm64/boot/dts/amlogic/Makefile          |  1 +
 .../boot/dts/amlogic/meson-gxbb-kii-pro.dts   | 76 +++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
arch/arm64/boot/dts/amlogic/Makefile +1 -0
index 84afecba9ec0..a795a170dcab 100644
@@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +15 -0
new file mode 100644
index 000000000000..5d120e6ca338
@@ -0,0 +1,76 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 Mohammad Rasim <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "meson-gxbb-p20x.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+/ {
+       compatible = "videostrong,kii-pro", "amlogic,p201", "amlogic,s905", "amlogic,meson-gxbb";
+       model = "Videostrong KII Pro";
+
Quoted 8 lines

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 19

Quoted 4 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +4 -0
+       leds {
+               compatible = "gpio-leds";
+               red {
+                       label = "status";

this property seems to be deprecated now, see Documentation/devicetree/bindings/leds/common.txt
but I'm not sure whether Kevin has made a decision yet when to not accept "label" properties here anymore

Quoted 3 lines

OK, I will remove the deprecated property
but I'm not sure what should I choose as a function, LED_FUNCTION_STATUS or LED_FUNCTION_ACTIVITY ?

Quoted 8 lines

I haven't used function and color myself but I believe it works like this (untested):
- add an #include <dt-bindings/leds/common.h> next to the other #includes (keep alphabetical ordering). this include file also contains all the #defines for color and function
- add a color property, for example: color = <LED_COLOR_ID_RED>;
- add a function property, for example: function = <LED_FUNCTION_STATUS>;
- test, debug and fix potential issues ;)

Quoted 4 lines

Yes, I've already tested it but I'm just not sure what should be in the function property, LED_FUNCTION_STATUS and LED_FUNCTION_ACTIVITY both seem like good choices,
in my tests this property was prepended to the label

Scratch that, I was confused because i changed the node name, the labled is generated from the color property and the node name. although my question regarding userspace usage still applies.

Quoted 19 lines

So the following:

		status {
			gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
			default-state = "off";
			color = <LED_COLOR_ID_RED>;
			function = LED_FUNCTION_STATUS;
		};

resulted in a led labeled red:status
[root@alarm ~]# ls /sys/class/leds/
input1::capslock input1::numlock input1::scrolllock red:status

if this property only used to lable the led then LED_FUNCTION_STATUS is ok, but maybe this is used by userspace to trigger the led ?!

Regards

Quoted 3 lines

Martin

#10 lore raw

Re: [PATCH v3 2/2] arm64: dts: meson-gxbb: add support for

In reply to Mohammad Rasim

On Sat, Nov 30, 2019 at 8:07 PM Mohammad Rasim
<[email protected]> wrote:
[...]

Quoted 19 lines
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 19

Quoted 4 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +4 -0
+       leds {
+               compatible = "gpio-leds";
+               red {
+                       label = "status";

this property seems to be deprecated now, see Documentation/devicetree/bindings/leds/common.txt
but I'm not sure whether Kevin has made a decision yet when to not accept "label" properties here anymore

OK, I will remove the deprecated property
but I'm not sure what should I choose as a function, LED_FUNCTION_STATUS or LED_FUNCTION_ACTIVITY ?

Quoted 8 lines

I haven't used function and color myself but I believe it works like this (untested):
- add an #include <dt-bindings/leds/common.h> next to the other #includes (keep alphabetical ordering). this include file also contains all the #defines for color and function
- add a color property, for example: color = <LED_COLOR_ID_RED>;
- add a function property, for example: function = <LED_FUNCTION_STATUS>;
- test, debug and fix potential issues ;)

Quoted 3 lines

Yes, I've already tested it but I'm just not sure what should be in the function property, LED_FUNCTION_STATUS and LED_FUNCTION_ACTIVITY both seem like good choices,

I haven't considered "activity" before, but most of our boards with some kind of status LED use status in the label
unless someone objects: choose the one you like most

[...]

Quoted 2 lines

if this property only used to lable the led then LED_FUNCTION_STATUS is ok, but maybe this is used by userspace to trigger the led ?!

in general devicetree describes hardware
I don't know if userspace does something "automatically" based on the function. however, my expectation is that the trigger from "linux,default-trigger" is used (if set) and that you can change the trigger from userspace manually (if you wish)

Martin

#11 lore raw
In reply to Mohammad Rasim

Hi Mohammad,

Quoted 5 lines · Mohammad Rasim

This patchset adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design.

Quoted 16 lines

Device specifications:
- SOC: Amlogic S905
- RAM: 2GB DDR3
- Storage: 16GB
- Connectivity:
- 10/100M Ethernet (IC Plus IP101GR)
- 802.11 b/g/n/ac Wi-Fi (Ampak AP6335 BT/WIFI combo)
- Bluetooth 4.0 (Ampak AP6335 BT/WIFI combo)
- Video out: HDMI 2.0 up to 4K @ 60Hz, and 3.5mm AV (composite video) jack
- Audio out: HDMI, AV (stereo audio) and optical S/PDIF
- Tuner: AVL6862 DVB-C/T/T2 + DVB-S/S2 demod and Rafael Micro R848 tuner
- Ports:
- x1 micro SD card slot up to 32GB
- 4x USB 2.0 host ports
- Misc:
- Power button and LED, IR receiver

it would be great if you could add this description also to the .dts patch that way we can always look up the specs in git history (which is easier than finding the corresponding mail)

Martin

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

#12 lore raw
Quoted 25 lines · Martin Blumenstingl

Hi Mohammad,

Quoted 5 lines · Mohammad Rasim

This patchset adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design.

Quoted 16 lines

Device specifications:
- SOC: Amlogic S905
- RAM: 2GB DDR3
- Storage: 16GB
- Connectivity:
- 10/100M Ethernet (IC Plus IP101GR)
- 802.11 b/g/n/ac Wi-Fi (Ampak AP6335 BT/WIFI combo)
- Bluetooth 4.0 (Ampak AP6335 BT/WIFI combo)
- Video out: HDMI 2.0 up to 4K @ 60Hz, and 3.5mm AV (composite video) jack
- Audio out: HDMI, AV (stereo audio) and optical S/PDIF
- Tuner: AVL6862 DVB-C/T/T2 + DVB-S/S2 demod and Rafael Micro R848 tuner
- Ports:
- x1 micro SD card slot up to 32GB
- 4x USB 2.0 host ports
- Misc:
- Power button and LED, IR receiver

Quoted 4 lines

it would be great if you could add this description also to the .dts patch that way we can always look up the specs in git history (which is easier than finding the corresponding mail)

Ok, will add it in the next version

Regards

Quoted 2 lines

Martin

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic