media: dvb_dummy_fe: Fix ERROR: POINTER_LOCATION
PATCH v2 1/1 media: dvb_dummy_fe: Fix ERROR: POINTER_LOCATION
From: "Daniel W. S. Almeida" <[email protected]>
Change foo* bar to foo *bar to avoid ERROR: POINTER_LOCATION in checkpatch.pl
ERROR: "foo* bar" should be "foo *bar"
+static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength)
ERROR: "foo* bar" should be "foo *bar"
+static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength)
ERROR: "foo* bar" should be "foo *bar"
+static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr)
ERROR: "foo* bar" should be "foo *bar"
+static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr)
ERROR: "foo* bar" should be "foo *bar"
+static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks)
ERROR: "foo* bar" should be "foo *bar"
+static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks)
ERROR: "foo* bar" should be "foo *bar"
+static int dvb_dummy_fe_sleep(struct dvb_frontend* fe)
ERROR: "foo* bar" should be "foo *bar" +static int dvb_dummy_fe_init(struct dvb_frontend* fe)
ERROR: "foo* bar" should be "foo *bar"
+static void dvb_dummy_fe_release(struct dvb_frontend* fe)
ERROR: "foo* bar" should be "foo *bar"
+ struct dvb_dummy_fe_state* state = fe->demodulator_priv;
ERROR: "foo* bar" should be "foo *bar" +struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void)
ERROR: "foo* bar" should be "foo *bar"
+ struct dvb_dummy_fe_state* state = NULL;
ERROR: "foo* bar" should be "foo *bar"
+ struct dvb_dummy_fe_state* state = NULL;
ERROR: "foo* bar" should be "foo *bar"
+ struct dvb_dummy_fe_state* state = NULL;
------------------------------------------------------------
Changes in v2:
-Added checkpatch.pl previous output so it's more clear what is being fixed by this patch.
--- drivers/media/dvb-frontends/dvb_dummy_fe.c | 24 +++++++++++----------- drivers/media/dvb-frontends/dvb_dummy_fe.h | 6 +++--- 2 files changed, 15 insertions(+), 15 deletions(-)
drivers/media/dvb-frontends/dvb_dummy_fe.c +12 -12
@@ -31,25 +31,25 @@ static int dvb_dummy_fe_read_status(struct dvb_frontend *fe,return 0 ; } -static int dvb_dummy_fe_read_ber (struct dvb_frontend * fe,u32 * ber) +static int dvb_dummy_fe_read_ber (struct dvb_frontend *fe,u32 *ber) { *ber =0 ;return 0 ; } -static int dvb_dummy_fe_read_signal_strength (struct dvb_frontend * fe,u16 * strength) +static int dvb_dummy_fe_read_signal_strength (struct dvb_frontend *fe,u16 *strength) { *strength =0 ;return 0 ; } -static int dvb_dummy_fe_read_snr (struct dvb_frontend * fe,u16 * snr) +static int dvb_dummy_fe_read_snr (struct dvb_frontend *fe,u16 *snr) { *snr =0 ;return 0 ; } -static int dvb_dummy_fe_read_ucblocks (struct dvb_frontend * fe,u32 * ucblocks) +static int dvb_dummy_fe_read_ucblocks (struct dvb_frontend *fe,u32 *ucblocks) { *ucblocks =0 ;return 0 ;
@@ -77,12 +77,12 @@ static int dvb_dummy_fe_set_frontend(struct dvb_frontend *fe)return 0 ; } -static int dvb_dummy_fe_sleep (struct dvb_frontend * fe) +static int dvb_dummy_fe_sleep (struct dvb_frontend *fe) {return 0 ; } -static int dvb_dummy_fe_init (struct dvb_frontend * fe) +static int dvb_dummy_fe_init (struct dvb_frontend *fe) {return 0 ; }
@@ -99,17 +99,17 @@ static int dvb_dummy_fe_set_voltage(struct dvb_frontend *fe,return 0 ; } -static void dvb_dummy_fe_release (struct dvb_frontend * fe) +static void dvb_dummy_fe_release (struct dvb_frontend *fe) { -struct dvb_dummy_fe_state * state = fe->demodulator_priv; +struct dvb_dummy_fe_state *state = fe->demodulator_priv;kfree (state); }static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops; -struct dvb_frontend *dvb_dummy_fe_ofdm_attach (void ) +struct dvb_frontend *dvb_dummy_fe_ofdm_attach (void ) { -struct dvb_dummy_fe_state * state =NULL ; +struct dvb_dummy_fe_state *state =NULL ;/* allocate memory for the internal state */ state =kzalloc (sizeof (struct dvb_dummy_fe_state ),GFP_KERNEL );
@@ -126,7 +126,7 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops;struct dvb_frontend *dvb_dummy_fe_qpsk_attach (void ) { -struct dvb_dummy_fe_state * state =NULL ; +struct dvb_dummy_fe_state *state =NULL ;/* allocate memory for the internal state */ state =kzalloc (sizeof (struct dvb_dummy_fe_state ),GFP_KERNEL );
@@ -143,7 +143,7 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops;struct dvb_frontend *dvb_dummy_fe_qam_attach (void ) { -struct dvb_dummy_fe_state * state =NULL ; +struct dvb_dummy_fe_state *state =NULL ;/* allocate memory for the internal state */ state =kzalloc (sizeof (struct dvb_dummy_fe_state ),GFP_KERNEL );
drivers/media/dvb-frontends/dvb_dummy_fe.h +3 -3
@@ -12,9 +12,9 @@#include <media/dvb_frontend.h> #if IS_REACHABLE (CONFIG_DVB_DUMMY_FE ) -extern struct dvb_frontend *dvb_dummy_fe_ofdm_attach (void ); -extern struct dvb_frontend *dvb_dummy_fe_qpsk_attach (void ); -extern struct dvb_frontend *dvb_dummy_fe_qam_attach (void ); +extern struct dvb_frontend *dvb_dummy_fe_ofdm_attach (void ); +extern struct dvb_frontend *dvb_dummy_fe_qpsk_attach (void ); +extern struct dvb_frontend *dvb_dummy_fe_qam_attach (void );#else static inline struct dvb_frontend *dvb_dummy_fe_ofdm_attach (void ) {
Signature · 1 line
2.24.0
Mauro Carvalho Chehab
maintainerEm Tue, 12 Nov 2019 09:50:14 -0300
"Daniel W. S. Almeida" <[email protected]> escreveu:
Quoted 67 lines
From: "Daniel W. S. Almeida" <[email protected]>
Change foo* bar to foo *bar to avoid ERROR:
POINTER_LOCATIONin checkpatch.plERROR: "foo* bar" should be "foo *bar"
+static intdvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength)ERROR: "foo* bar" should be "foo *bar"
+static intdvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength)ERROR: "foo* bar" should be "foo *bar"
+static intdvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr)ERROR: "foo* bar" should be "foo *bar"
+static intdvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr)ERROR: "foo* bar" should be "foo *bar"
+static intdvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks)ERROR: "foo* bar" should be "foo *bar"
+static intdvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks)ERROR: "foo* bar" should be "foo *bar"
+static intdvb_dummy_fe_sleep(struct dvb_frontend* fe)ERROR: "foo* bar" should be "foo *bar" +static int
dvb_dummy_fe_init(struct dvb_frontend* fe)ERROR: "foo* bar" should be "foo *bar"
+static voiddvb_dummy_fe_release(struct dvb_frontend* fe)ERROR: "foo* bar" should be "foo *bar"
(quoted diff) +1
-0+ struct dvb_dummy_fe_state* state = fe->demodulator_priv;ERROR: "foo* bar" should be "foo *bar" +struct dvb_frontend*
dvb_dummy_fe_ofdm_attach(void)ERROR: "foo* bar" should be "foo *bar"
(quoted diff) +1
-0+ struct dvb_dummy_fe_state* state = NULL;ERROR: "foo* bar" should be "foo *bar"
(quoted diff) +1
-0+ struct dvb_dummy_fe_state* state = NULL;ERROR: "foo* bar" should be "foo *bar"
(quoted diff) +1
-0+ struct dvb_dummy_fe_state* state = NULL;Suggested-by Shuah Khan <[email protected]>Signed-off-by Daniel W. S. Almeida <[email protected]>------------------------------------------------------------
Changes in v2:-Added checkpatch.pl previous output so it's more clear what is being fixed by this patch.
--- drivers/media/dvb-frontends/dvb_dummy_fe.c | 24 +++++++++++----------- drivers/media/dvb-frontends/dvb_dummy_fe.h | 6 +++--- 2 files changed, 15 insertions(+), 15 deletions(-)drivers/media/dvb-frontends/dvb_dummy_fe.c +0
-0@@ -31,25 +31,25 @@ static int dvb_dummy_fe_read_status(struct dvb_frontend *fe,return 0 ; }
drivers/media/dvb-frontends/dvb_dummy_fe.c static int dvb_dummy_fe_read_status(struct dvb_frontend *fe, · line 40
Quoted 10 lines
drivers/media/dvb-frontends/dvb_dummy_fe.c +2
-2-static int dvb_dummy_fe_read_ber (struct dvb_frontend * fe,u32 * ber) +static int dvb_dummy_fe_read_ber (struct dvb_frontend *fe,u32 *ber) { *ber =0 ;return 0 ; } -static int dvb_dummy_fe_read_signal_strength (struct dvb_frontend * fe,u16 * strength) +static int dvb_dummy_fe_read_signal_strength (struct dvb_frontend *fe,u16 *strength)
Line too long. As you're touching on it, please also fix the long line warning.
Quoted 77 lines
drivers/media/dvb-frontends/dvb_dummy_fe.c +10
-10{ *strength =0 ;return 0 ; } -static int dvb_dummy_fe_read_snr (struct dvb_frontend * fe,u16 * snr) +static int dvb_dummy_fe_read_snr (struct dvb_frontend *fe,u16 *snr) { *snr =0 ;return 0 ; } -static int dvb_dummy_fe_read_ucblocks (struct dvb_frontend * fe,u32 * ucblocks) +static int dvb_dummy_fe_read_ucblocks (struct dvb_frontend *fe,u32 *ucblocks) { *ucblocks =0 ;return 0 ;@@ -77,12 +77,12 @@ static int dvb_dummy_fe_set_frontend(struct dvb_frontend *fe)return 0 ; } -static int dvb_dummy_fe_sleep (struct dvb_frontend * fe) +static int dvb_dummy_fe_sleep (struct dvb_frontend *fe) {return 0 ; } -static int dvb_dummy_fe_init (struct dvb_frontend * fe) +static int dvb_dummy_fe_init (struct dvb_frontend *fe) {return 0 ; }@@ -99,17 +99,17 @@ static int dvb_dummy_fe_set_voltage(struct dvb_frontend *fe,return 0 ; } -static void dvb_dummy_fe_release (struct dvb_frontend * fe) +static void dvb_dummy_fe_release (struct dvb_frontend *fe) { -struct dvb_dummy_fe_state * state = fe->demodulator_priv; +struct dvb_dummy_fe_state *state = fe->demodulator_priv;kfree (state); }static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops; -struct dvb_frontend *dvb_dummy_fe_ofdm_attach (void ) +struct dvb_frontend *dvb_dummy_fe_ofdm_attach (void ) { -struct dvb_dummy_fe_state * state =NULL ; +struct dvb_dummy_fe_state *state =NULL ;/* allocate memory for the internal state */ state =kzalloc (sizeof (struct dvb_dummy_fe_state ),GFP_KERNEL );@@ -126,7 +126,7 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops;struct dvb_frontend *dvb_dummy_fe_qpsk_attach (void ) { -struct dvb_dummy_fe_state * state =NULL ; +struct dvb_dummy_fe_state *state =NULL ;/* allocate memory for the internal state */ state =kzalloc (sizeof (struct dvb_dummy_fe_state ),GFP_KERNEL );@@ -143,7 +143,7 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops;struct dvb_frontend *dvb_dummy_fe_qam_attach (void ) { -struct dvb_dummy_fe_state * state =NULL ; +struct dvb_dummy_fe_state *state =NULL ;/* allocate memory for the internal state */ state =kzalloc (sizeof (struct dvb_dummy_fe_state ),GFP_KERNEL );drivers/media/dvb-frontends/dvb_dummy_fe.h +0
-0
drivers/media/dvb-frontends/dvb_dummy_fe.h line 17
Quoted 9 lines
drivers/media/dvb-frontends/dvb_dummy_fe.h +3
-3@@ -12,9 +12,9 @@#include <media/dvb_frontend.h> #if IS_REACHABLE (CONFIG_DVB_DUMMY_FE ) -extern struct dvb_frontend *dvb_dummy_fe_ofdm_attach (void ); -extern struct dvb_frontend *dvb_dummy_fe_qpsk_attach (void ); -extern struct dvb_frontend *dvb_dummy_fe_qam_attach (void ); +extern struct dvb_frontend *dvb_dummy_fe_ofdm_attach (void ); +extern struct dvb_frontend *dvb_dummy_fe_qpsk_attach (void ); +extern struct dvb_frontend *dvb_dummy_fe_qam_attach (void );
Don't keep the "extern" here:
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #185: FILE: drivers/media/dvb-frontends/dvb_dummy_fe.h:15:
+extern struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #186: FILE: drivers/media/dvb-frontends/dvb_dummy_fe.h:16:
+extern struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #187: FILE: drivers/media/dvb-frontends/dvb_dummy_fe.h:17:
+extern struct dvb_frontend *dvb_dummy_fe_qam_attach(void);
drivers/media/dvb-frontends/dvb_dummy_fe.h line 20
Quoted 3 lines
drivers/media/dvb-frontends/dvb_dummy_fe.h +0
-0#else static inline struct dvb_frontend *dvb_dummy_fe_ofdm_attach (void ) {
Cheers,
Mauro