drm/i915: lookup for mem_region of a mem_type
Subsystems (2)
PATCH v4 1/2 drm/i915: lookup for mem_region of a mem_type
Lookup function to retrieve the pointer to a memory region of a mem_type.
--- drivers/gpu/drm/i915/intel_memory_region.c | 12 ++++++++++++ drivers/gpu/drm/i915/intel_memory_region.h | 3 +++ 2 files changed, 15 insertions(+)
drivers/gpu/drm/i915/intel_memory_region.c +12 -0
@@ -16,6 +16,18 @@ const u32 intel_region_map[] = { [INTEL_REGION_STOLEN] = REGION_MAP(INTEL_MEMORY_STOLEN, 0), }; +struct intel_memory_region * +intel_memory_region_lookup (struct drm_i915_private *i915, +enum intel_memory_type mem_type) +{ +enum intel_region_id id; + +for (id =INTEL_REGION_SMEM ; id <INTEL_REGION_UNKNOWN ; id++) +if (i915->mm.regions[id]->type == mem_type) +return i915->mm.regions[id]; +return NULL ; +} +static u64 intel_memory_region_free_pages (struct intel_memory_region *mem,struct list_head *blocks)
drivers/gpu/drm/i915/intel_memory_region.h +3 -0
@@ -125,5 +125,8 @@ void intel_memory_region_put(struct intel_memory_region *mem);int intel_memory_regions_hw_probe (struct drm_i915_private *i915);void intel_memory_regions_driver_release (struct drm_i915_private *i915); +struct intel_memory_region * +intel_memory_region_lookup (struct drm_i915_private *i915, +enum intel_memory_type mem_type);#endif
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 2/2 drm/i915: Create dumb buffer from LMEM
When LMEM is supported, dumb buffer preferred to be created from LMEM.
v2:
Parameters are reshuffled. [Chris]
v3:
s/region_id/mem_type
v4:
use the i915_gem_object_create_region [chris]
--- drivers/gpu/drm/i915/i915_gem.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +11 -3
@@ -44,6 +44,7 @@#include "gem/i915_gem_clflush.h" #include "gem/i915_gem_context.h" #include "gem/i915_gem_ioctls.h" +#include "gem/i915_gem_region.h" #include "gem/i915_gem_pm.h" #include "gt/intel_context.h" #include "gt/intel_engine_user.h"
@@ -176,6 +177,7 @@ i915_gem_phys_pwrite(struct drm_i915_gem_object *obj,static int i915_gem_create (struct drm_file *file,struct drm_i915_private *dev_priv, +enum intel_memory_type mem_type,u64 *size_p,u32 *handle_p) {
@@ -189,7 +191,8 @@ i915_gem_create(struct drm_file *file,return -EINVAL ;/* Allocate the new object */ - obj =i915_gem_object_create_shmem (dev_priv, size); + obj =i915_gem_object_create_region (intel_memory_region_lookup (dev_priv, + mem_type), size,0 );if (IS_ERR (obj))return PTR_ERR (obj);
@@ -209,6 +212,7 @@ i915_gem_dumb_create(struct drm_file *file,struct drm_device *dev, struct drm_mode_create_dumb *args) { + enum intel_memory_type mem_type = INTEL_MEMORY_SYSTEM;int cpp =DIV_ROUND_UP (args->bpp,8 );u32 format;
@@ -235,7 +239,11 @@ i915_gem_dumb_create(struct drm_file *file, args->pitch =ALIGN (args->pitch,4096 ); args->size = args->pitch * args->height; -return i915_gem_create (file,to_i915 (dev), + +if (HAS_LMEM (to_i915 (dev))) + mem_type =INTEL_MEMORY_LOCAL ; + +return i915_gem_create (file,to_i915 (dev), mem_type, &args->size, &args->handle); }
@@ -254,7 +262,7 @@ i915_gem_create_ioctl(struct drm_device *dev, void *data,i915_gem_flush_free_objects (dev_priv); -return i915_gem_create (file, dev_priv, +return i915_gem_create (file, dev_priv,INTEL_MEMORY_SYSTEM , &args->size, &args->handle); }
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Create dumb buffer from LMEM
Quoted 37 lines · Ramalingam C
When LMEM is supported, dumb buffer preferred to be created from LMEM.
v2:
Parameters are reshuffled. [Chris]
v3:
s/region_id/mem_type
v4:
use thei915_gem_object_create_region[chris]Signed-off-by Ramalingam C <[email protected]>cc Matthew Auld <[email protected]>--- drivers/gpu/drm/i915/i915_gem.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_gem.c +2
-0@@ -44,6 +44,7 @@#include "gem/i915_gem_clflush.h" #include "gem/i915_gem_context.h" #include "gem/i915_gem_ioctls.h" +#include "gem/i915_gem_region.h" #include "gem/i915_gem_pm.h" #include "gt/intel_context.h" #include "gt/intel_engine_user.h" @@ -176,6 +177,7 @@ i915_gem_phys_pwrite(struct drm_i915_gem_object *obj,static int i915_gem_create (struct drm_file *file,struct drm_i915_private *dev_priv, +enum intel_memory_type mem_type,u64 *size_p,u32 *handle_p) {
drivers/gpu/drm/i915/i915_gem.c i915_gem_create(struct drm_file *file, · line 195
Quoted 6 lines
drivers/gpu/drm/i915/i915_gem.c +2
-1@@ -189,7 +191,8 @@ i915_gem_create(struct drm_file *file,return -EINVAL ;/* Allocate the new object */ - obj =i915_gem_object_create_shmem (dev_priv, size); + obj =i915_gem_object_create_region (intel_memory_region_lookup (dev_priv, + mem_type), size,0 );
But how should we go about testing this?
We would still need to clear the object(maybe I915_BO_ALLOC_CLEARED?) in order to pass the IGTs. We also need to adjust dumb_buffer.c, since that uses get_avail_ram_mb() for always_clear, but maybe we need the query region uapi for that?
Quoted 36 lines
drivers/gpu/drm/i915/i915_gem.c +7
-3if (IS_ERR (obj))return PTR_ERR (obj);@@ -209,6 +212,7 @@ i915_gem_dumb_create(struct drm_file *file,struct drm_device *dev, struct drm_mode_create_dumb *args) { + enum intel_memory_type mem_type = INTEL_MEMORY_SYSTEM;int cpp =DIV_ROUND_UP (args->bpp,8 );u32 format;@@ -235,7 +239,11 @@ i915_gem_dumb_create(struct drm_file *file, args->pitch =ALIGN (args->pitch,4096 ); args->size = args->pitch * args->height; -return i915_gem_create (file,to_i915 (dev), + +if (HAS_LMEM (to_i915 (dev))) + mem_type =INTEL_MEMORY_LOCAL ; + +return i915_gem_create (file,to_i915 (dev), mem_type, &args->size, &args->handle); }@@ -254,7 +262,7 @@ i915_gem_create_ioctl(struct drm_device *dev, void *data,i915_gem_flush_free_objects (dev_priv); -return i915_gem_create (file, dev_priv, +return i915_gem_create (file, dev_priv,INTEL_MEMORY_SYSTEM , &args->size, &args->handle); } --2.20.1
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Create dumb buffer from LMEM
Quoting Matthew Auld (2019-12-05 12:12:19)
Quoted 47 lines · Ramalingam C
Quoted 37 lines
When LMEM is supported, dumb buffer preferred to be created from LMEM.
v2:
Parameters are reshuffled. [Chris]
v3:
s/region_id/mem_type
v4:
use thei915_gem_object_create_region[chris]Signed-off-by Ramalingam C <[email protected]>cc Matthew Auld <[email protected]>--- drivers/gpu/drm/i915/i915_gem.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_gem.c +2
-0@@ -44,6 +44,7 @@#include "gem/i915_gem_clflush.h" #include "gem/i915_gem_context.h" #include "gem/i915_gem_ioctls.h" +#include "gem/i915_gem_region.h" #include "gem/i915_gem_pm.h" #include "gt/intel_context.h" #include "gt/intel_engine_user.h" @@ -176,6 +177,7 @@ i915_gem_phys_pwrite(struct drm_i915_gem_object *obj,static int i915_gem_create (struct drm_file *file,struct drm_i915_private *dev_priv, +enum intel_memory_type mem_type,u64 *size_p,u32 *handle_p) {drivers/gpu/drm/i915/i915_gem.c i915_gem_create(struct drm_file *file, · line 195
Quoted 6 lines
drivers/gpu/drm/i915/i915_gem.c +2
-1@@ -189,7 +191,8 @@ i915_gem_create(struct drm_file *file,return -EINVAL ;/* Allocate the new object */ - obj =i915_gem_object_create_shmem (dev_priv, size); + obj =i915_gem_object_create_region (intel_memory_region_lookup (dev_priv, + mem_type), size,0 );Reviewed-by Matthew Auld <[email protected]>
Quoted 6 lines
But how should we go about testing this?
We would still need to clear the
object(maybe I915_BO_ALLOC_CLEARED?)in order to pass the IGTs. We also need to adjustdumb_buffer.c, since that usesget_avail_ram_mb()foralways_clear, but maybe we need the query region uapi for that?
Hmm. Questions over the maximum size for dumb buffer, maximum number of dumb buffers, etc, should be addressed to the dumb API. So some form of drmGetCap() ?
Note for merging, we need the lmem vm_fault implementation first. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Create dumb buffer from LMEM
Quoted 50 lines · Chris Wilson
Quoting Matthew Auld (2019-12-05 12:12:19)
Quoted 49 lines · Ramalingam C
Quoted 37 lines
When LMEM is supported, dumb buffer preferred to be created from LMEM.
v2:
Parameters are reshuffled. [Chris]
v3:
s/region_id/mem_type
v4:
use thei915_gem_object_create_region[chris]Signed-off-by Ramalingam C <[email protected]>cc Matthew Auld <[email protected]>--- drivers/gpu/drm/i915/i915_gem.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_gem.c +2
-0@@ -44,6 +44,7 @@#include "gem/i915_gem_clflush.h" #include "gem/i915_gem_context.h" #include "gem/i915_gem_ioctls.h" +#include "gem/i915_gem_region.h" #include "gem/i915_gem_pm.h" #include "gt/intel_context.h" #include "gt/intel_engine_user.h" @@ -176,6 +177,7 @@ i915_gem_phys_pwrite(struct drm_i915_gem_object *obj,static int i915_gem_create (struct drm_file *file,struct drm_i915_private *dev_priv, +enum intel_memory_type mem_type,u64 *size_p,u32 *handle_p) {drivers/gpu/drm/i915/i915_gem.c i915_gem_create(struct drm_file *file, · line 195
Quoted 6 lines
drivers/gpu/drm/i915/i915_gem.c +2
-1@@ -189,7 +191,8 @@ i915_gem_create(struct drm_file *file,return -EINVAL ;/* Allocate the new object */ - obj =i915_gem_object_create_shmem (dev_priv, size); + obj =i915_gem_object_create_region (intel_memory_region_lookup (dev_priv, + mem_type), size,0 );Reviewed-by Matthew Auld <[email protected]>But how should we go about testing this?
Quoted 8 lines
Quoted 4 lines
We would still need to clear the
object(maybe I915_BO_ALLOC_CLEARED?)in order to pass the IGTs. We also need to adjustdumb_buffer.c, since that usesget_avail_ram_mb()foralways_clear, but maybe we need the query region uapi for that?Hmm. Questions over the maximum size for dumb buffer, maximum number of dumb buffers, etc, should be addressed to the dumb API. So some form of
drmGetCap()?
Chris, Is this suggestion to add this capability probing through a new IOCTL for dumb APIs? Please clarify.
-Ram
Quoted 3 lines
Note for merging, we need the lmem
vm_faultimplementation first. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Create dumb buffer from LMEM
Quoting Ramalingam C (2019-12-05 13:02:40)
Quoted 7 lines · Chris Wilson
Quoted 6 lines
Quoting Matthew Auld (2019-12-05 12:12:19)
Quoted 4 lines
We would still need to clear the
object(maybe I915_BO_ALLOC_CLEARED?)in order to pass the IGTs. We also need to adjustdumb_buffer.c, since that usesget_avail_ram_mb()foralways_clear, but maybe we need the query region uapi for that?
Quoted 5 lines
Quoted 3 lines
Hmm. Questions over the maximum size for dumb buffer, maximum number of dumb buffers, etc, should be addressed to the dumb API. So some form of
drmGetCap()?Chris, Is this suggestion to add this capability probing through a new IOCTL for dumb APIs? Please clarify.
I don't think we need a new ioctl, as drm_getcap already covers the dumb buffer API. We just need to expose the limits of the dumb buffer API through it.
The 2 that spring to mind are maximum size of individual buffer and maximum size of total dumb buffers. (The latter may be infinite for drivers that allow swapping of inactive buffers.) There was a request on irc for something like this as well, but I'm not aware of the context. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Create dumb buffer from LMEM
Quoted 14 lines · Chris Wilson
Quoting Ramalingam C (2019-12-05 13:02:40)
Quoted 7 lines · Chris Wilson
Quoted 6 lines
Quoting Matthew Auld (2019-12-05 12:12:19)
Quoted 4 lines
We would still need to clear the
object(maybe I915_BO_ALLOC_CLEARED?)in order to pass the IGTs. We also need to adjustdumb_buffer.c, since that usesget_avail_ram_mb()foralways_clear, but maybe we need the query region uapi for that?Quoted 5 lines
Quoted 3 lines
Hmm. Questions over the maximum size for dumb buffer, maximum number of dumb buffers, etc, should be addressed to the dumb API. So some form of
drmGetCap()?Chris, Is this suggestion to add this capability probing through a new IOCTL for dumb APIs? Please clarify.
Quoted 6 lines
I don't think we need a new ioctl, as
drm_getcapalready covers the dumb buffer API. We just need to expose the limits of the dumb buffer API through it.The 2 that spring to mind are maximum size of individual buffer and maximum size of total dumb buffers.
Will there be question for userspace for this extension or no? AFAIK There is no consumer except IGT.
-Ram
Quoted 4 lines
(The latter may be infinite for
drivers that allow swapping of inactive buffers.) There was a request on irc for something like this as well, but I'm not aware of the context. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Create dumb buffer from LMEM
Quoting Ramalingam C (2019-12-09 11:57:01)
Quoted 19 lines · Chris Wilson
Quoted 18 lines
Quoting Ramalingam C (2019-12-05 13:02:40)
Quoted 7 lines · Chris Wilson
Quoted 6 lines
Quoting Matthew Auld (2019-12-05 12:12:19)
Quoted 4 lines
We would still need to clear the
object(maybe I915_BO_ALLOC_CLEARED?)in order to pass the IGTs. We also need to adjustdumb_buffer.c, since that usesget_avail_ram_mb()foralways_clear, but maybe we need the query region uapi for that?Quoted 5 lines
Quoted 3 lines
Hmm. Questions over the maximum size for dumb buffer, maximum number of dumb buffers, etc, should be addressed to the dumb API. So some form of
drmGetCap()?Chris, Is this suggestion to add this capability probing through a new IOCTL for dumb APIs? Please clarify.
I don't think we need a new ioctl, as
drm_getcapalready covers the dumb buffer API. We just need to expose the limits of the dumb buffer API through it.
Quoted 5 lines
Quoted 2 lines
The 2 that spring to mind are maximum size of individual buffer and maximum size of total dumb buffers.
Will there be question for userspace for this extension or no? AFAIK There is no consumer except IGT.
There was someone else asking for maximum dumb buffer size on irc from an application perspective.
But I strongly believe that discoverability and testability of an API should be a central tenet of API design. :)
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Create dumb buffer from LMEM
Quoted 23 lines · Chris Wilson
Quoting Ramalingam C (2019-12-09 11:57:01)
Quoted 22 lines · Chris Wilson
Quoted 20 lines
Quoting Ramalingam C (2019-12-05 13:02:40)
Quoted 7 lines · Chris Wilson
Quoted 6 lines
Quoting Matthew Auld (2019-12-05 12:12:19)
Quoted 4 lines
We would still need to clear the
object(maybe I915_BO_ALLOC_CLEARED?)in order to pass the IGTs. We also need to adjustdumb_buffer.c, since that usesget_avail_ram_mb()foralways_clear, but maybe we need the query region uapi for that?Quoted 5 lines
Quoted 3 lines
Hmm. Questions over the maximum size for dumb buffer, maximum number of dumb buffers, etc, should be addressed to the dumb API. So some form of
drmGetCap()?Chris, Is this suggestion to add this capability probing through a new IOCTL for dumb APIs? Please clarify.
I don't think we need a new ioctl, as
drm_getcapalready covers the dumb buffer API. We just need to expose the limits of the dumb buffer API through it.The 2 that spring to mind are maximum size of individual buffer and maximum size of total dumb buffers.
Quoted 8 lines
Quoted 2 lines
Will there be question for userspace for this extension or no? AFAIK There is no consumer except IGT.
There was someone else asking for maximum dumb buffer size on irc from an application perspective.
But I strongly believe that discoverability and testability of an API should be a central tenet of API design. :)
So can i take it for "No userspace is required for this uAPI extension as this helps the testing" ?
-Ram
Quoted 1 line
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Create dumb buffer from LMEM
In reply to Matthew AuldQuoted 47 lines · Matthew Auld
Quoted 37 lines · Ramalingam C
When LMEM is supported, dumb buffer preferred to be created from LMEM.
v2:
Parameters are reshuffled. [Chris]
v3:
s/region_id/mem_type
v4:
use thei915_gem_object_create_region[chris]Signed-off-by Ramalingam C <[email protected]>cc Matthew Auld <[email protected]>--- drivers/gpu/drm/i915/i915_gem.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_gem.c +2
-0@@ -44,6 +44,7 @@#include "gem/i915_gem_clflush.h" #include "gem/i915_gem_context.h" #include "gem/i915_gem_ioctls.h" +#include "gem/i915_gem_region.h" #include "gem/i915_gem_pm.h" #include "gt/intel_context.h" #include "gt/intel_engine_user.h" @@ -176,6 +177,7 @@ i915_gem_phys_pwrite(struct drm_i915_gem_object *obj,static int i915_gem_create (struct drm_file *file,struct drm_i915_private *dev_priv, +enum intel_memory_type mem_type,u64 *size_p,u32 *handle_p) {drivers/gpu/drm/i915/i915_gem.c i915_gem_create(struct drm_file *file, · line 195
Quoted 6 lines
drivers/gpu/drm/i915/i915_gem.c +2
-1@@ -189,7 +191,8 @@ i915_gem_create(struct drm_file *file,return -EINVAL ;/* Allocate the new object */ - obj =i915_gem_object_create_shmem (dev_priv, size); + obj =i915_gem_object_create_region (intel_memory_region_lookup (dev_priv, + mem_type), size,0 );Reviewed-by Matthew Auld <[email protected]>
Quoted 4 lines
But how should we go about testing this?
We would still need to clear the
object(maybe I915_BO_ALLOC_CLEARED?)in order to pass the IGTs.
Is this not cleared now? Tested this always clear on system memory not yet on LMEM. Yes. we need to adjust the dumb buffer IGT to check whether LMEM is supported? if so what is the max size that we could allocate as dumb buffer etc.
-Ram.
Quoted 37 lines
We also need to adjust
dumb_buffer.c, since
that usesget_avail_ram_mb()foralways_clear, but maybe we need the query region uapi for that?Quoted 33 lines
drivers/gpu/drm/i915/i915_gem.c +7
-2if (IS_ERR (obj))return PTR_ERR (obj);@@ -209,6 +212,7 @@ i915_gem_dumb_create(struct drm_file *file,struct drm_device *dev, struct drm_mode_create_dumb *args) { + enum intel_memory_type mem_type = INTEL_MEMORY_SYSTEM;int cpp =DIV_ROUND_UP (args->bpp,8 );u32 format;@@ -235,7 +239,11 @@ i915_gem_dumb_create(struct drm_file *file, args->pitch =ALIGN (args->pitch,4096 ); args->size = args->pitch * args->height; -return i915_gem_create (file,to_i915 (dev), + +if (HAS_LMEM (to_i915 (dev))) + mem_type =INTEL_MEMORY_LOCAL ; + +return i915_gem_create (file,to_i915 (dev), mem_type, &args->size, &args->handle); }@@ -254,7 +262,7 @@ i915_gem_create_ioctl(struct drm_device *dev, void *data,i915_gem_flush_free_objects (dev_priv); -return i915_gem_create (file, dev_priv, +return i915_gem_create (file, dev_priv,INTEL_MEMORY_SYSTEM , &args->size, &args->handle); }
Quoted 7 lines
Quoted 7 lines
--
2.20.1_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/2] drm/i915: lookup for mem_region of a mem_type
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: series starting with [v4,1/2] drm/i915: lookup for mem_region of a mem_type
URL : https://patchwork.freedesktop.org/series/70271/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 2ee9f8e9b658 drm/i915: lookup for mem_region of a mem_type 1172ee9d724f drm/i915: Create dumb buffer from LMEM -:44: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #44: FILE: drivers/gpu/drm/i915/i915_gem.c:195: + obj = i915_gem_object_create_region(intel_memory_region_lookup(dev_priv, + mem_type), size, 0);
total: 0 errors, 0 warnings, 1 checks, 50 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [v4,1/2] drm/i915: lookup for mem_region of a mem_type
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: series starting with [v4,1/2] drm/i915: lookup for mem_region of a mem_type
URL : https://patchwork.freedesktop.org/series/70271/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7458 -> Patchwork_15532
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15532 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_15532, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15532/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15532:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@reload:
- fi-bwr-2160: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7458/fi-bwr-2160/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15532/fi-bwr-2160/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_15532 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-skl-lmem: [PASS][3] -> [INCOMPLETE][4] ([i915#424])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7458/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15532/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-icl-u3: [DMESG-WARN][5] ([i915#592]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7458/fi-icl-u3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15532/fi-icl-u3/igt@[email protected]
* igt@i915_selftest@live_gem_contexts:
- fi-hsw-peppy: [INCOMPLETE][7] -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7458/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15532/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
#### Warnings ####
* igt@i915_module_load@reload:
- fi-icl-u2: [DMESG-WARN][9] ([i915#289]) -> [DMESG-WARN][10] ([i915#109] / [i915#289])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7458/fi-icl-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15532/fi-icl-u2/igt@[email protected]
* igt@kms_busy@basic-flip-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#62] / [i915#92]) +6 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7458/fi-kbl-x1275/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15532/fi-kbl-x1275/igt@[email protected]
* igt@kms_busy@basic-flip-pipe-b:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7458/fi-kbl-x1275/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15532/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#243]: https://gitlab.freedesktop.org/drm/intel/issues/243
[i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#592]: https://gitlab.freedesktop.org/drm/intel/issues/592
[i915#609]: https://gitlab.freedesktop.org/drm/intel/issues/609
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (50 -> 44)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7458 -> Patchwork_15532
CI-20190529: 20190529
CI_DRM_7458: 25263c754b3969b8554842bbe362c0a2fb214c42 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5320: 06833ffeaf7621c3fef097166539bbe999a33e9c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15532: 1172ee9d724f374af75ba72961ad2bf462cd654a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1172ee9d724f drm/i915: Create dumb buffer from LMEM 2ee9f8e9b658 drm/i915: lookup for mem_region of a mem_type
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15532/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 17 lines · Ramalingam C
Lookup function to retrieve the pointer to a memory region of a
mem_type.Signed-off-by Ramalingam C <[email protected]>cc Matthew Auld <[email protected]>--- drivers/gpu/drm/i915/intel_memory_region.c | 12 ++++++++++++ drivers/gpu/drm/i915/intel_memory_region.h | 3 +++ 2 files changed, 15 insertions(+)drivers/gpu/drm/i915/intel_memory_region.c +0
-0@@ -16,6 +16,18 @@ const u32 intel_region_map[] = { [INTEL_REGION_STOLEN] = REGION_MAP(INTEL_MEMORY_STOLEN, 0),
drivers/gpu/drm/i915/intel_memory_region.c const u32 intel_region_map[] = { · line 26
Quoted 10 lines
drivers/gpu/drm/i915/intel_memory_region.c +8
-0}; +struct intel_memory_region * +intel_memory_region_lookup (struct drm_i915_private *i915, +enum intel_memory_type mem_type) +{ +enum intel_region_id id; + +for (id =INTEL_REGION_SMEM ; id <INTEL_REGION_UNKNOWN ; id++) +if (i915->mm.regions[id]->type == mem_type)
Is it not worth doing:
if (region && region->type == mem_type)
?
I guess we can always extend and improve upon this later.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx