Skip to contentSkip to conversation

xen/arm: Basic support for sunxi/sun50i h6 platform.

PATCH In review Yangtao Li 3 participants 6 messages Dec 2, 2019 – Dec 17, 2019 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 xen/arm: Basic support for sunxi/sun50i h6 platform.

adding compatible strings for h6 SoCs, Specifically orangepi3.

---
 xen/arch/arm/platforms/sunxi.c | 1 +
 1 file changed, 1 insertion(+)
xen/arch/arm/platforms/sunxi.c +1 -0
index 55705b15b2..e8e4d88bef 100644
@@ -119,6 +119,7 @@ static const char * const sunxi_v8_dt_compat[] __initconst =
 {
     "allwinner,sun50i-a64",
     "allwinner,sun50i-h5",
+    "allwinner,sun50i-h6",
     NULL
 };
 
Signature · 7 lines
2.17.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw

(+Andre)

Hi,

@Andre, IIRC you originally added the support for sunxi in Xen. Could you have a look at this patch?

Cheers,

Quoted 19 lines · Yangtao Li

adding compatible strings for h6 SoCs, Specifically orangepi3.

--- > xen/arch/arm/platforms/sunxi.c | 1 +

  1 file changed, 1 insertion(+)
xen/arch/arm/platforms/sunxi.c +1 -0
index 55705b15b2..e8e4d88bef 100644
@@ -119,6 +119,7 @@ static const char * const sunxi_v8_dt_compat[] __initconst =
  {
      "allwinner,sun50i-a64",
      "allwinner,sun50i-h5",
+    "allwinner,sun50i-h6",
      NULL
  };
 
Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by
#2 lore raw

On Tue, 3 Dec 2019 11:39:58 +0000
Julien Grall <[email protected]> wrote:

Hi,

Quoted 6 lines

(+Andre)

Hi,

@Andre, IIRC you originally added the support for sunxi in Xen. Could you have a look at this patch?

Looks alright, and indeed the H6 needs it. Even though Allwinner totally re-arranged the memory map, they missed the opportunity to put each device at least in their own 4K page.

If you can wait till this evening, I can even test it.

It's actually a shame that we need this enumeration, when all we are after is an answer to the question: Does a device used by Xen share a 4K page with a device handed off to Dom0? It sounds like a nice rainy afternoon exercise to scan the DT to find those devices automatically and mask them (on the A64 for instance UART4 is on a different page).

Cheers,
Andre

Quoted 7 lines · Yangtao Li
Quoted 6 lines

adding compatible strings for h6 SoCs, Specifically orangepi3.

--- > xen/arch/arm/platforms/sunxi.c | 1 +

  1 file changed, 1 insertion(+)
Quoted 14 lines

xen/arch/arm/platforms/sunxi.c static const char * const sunxi_v8_dt_compat[] __initconst = · line 125

Quoted 13 lines
xen/arch/arm/platforms/sunxi.c +1 -0
index 55705b15b2..e8e4d88bef 100644
@@ -119,6 +119,7 @@ static const char * const sunxi_v8_dt_compat[] __initconst =
  {
      "allwinner,sun50i-a64",
      "allwinner,sun50i-h5",
+    "allwinner,sun50i-h6",
      NULL
  };
 

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
Quoted 7 lines · Andre Przywara

On Tue, 3 Dec 2019 11:39:58 +0000
Julien Grall <[email protected]> wrote:

Hi,

Quoted 2 lines

(+Andre)

Quoted 8 lines
Quoted 4 lines

Hi,

@Andre, IIRC you originally added the support for sunxi in Xen. Could you have a look at this patch?

Looks alright, and indeed the H6 needs it. Even though Allwinner totally re-arranged the memory map, they missed the opportunity to put each device at least in their own 4K page.

Thank you for the review!

Quoted 2 lines

If you can wait till this evening, I can even test it.

I can wait until tomorrow before comitting the patch.

Quoted 2 lines

It's actually a shame that we need this enumeration, when all we are after is an answer to the question: Does a device used by Xen share a 4K page with a device handed off to Dom0? It sounds

like a nice rainy afternoon exercise to scan the DT to find those devices automatically and mask them (on the A64 for instance UART4 is on a different page).

I agree and I think we discussed about it before :). I would welcome such improvement in Xen, this would actually allow us to drop sunxi.c completely.

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Tested-by
#4 lore raw

On Tue, 3 Dec 2019 16:52:45 +0000
Julien Grall <[email protected]> wrote:

Hi,

Quoted 15 lines · Andre Przywara
Quoted 14 lines

On Tue, 3 Dec 2019 11:39:58 +0000
Julien Grall <[email protected]> wrote:

Hi,

Quoted 6 lines

(+Andre)

Hi,

@Andre, IIRC you originally added the support for sunxi in Xen. Could you have a look at this patch?

Looks alright, and indeed the H6 needs it. Even though Allwinner totally re-arranged the memory map, they missed the opportunity to put each device at least in their own 4K page.

Quoted 8 lines
Quoted 1 line

Thank you for the review!

Quoted 2 lines

If you can wait till this evening, I can even test it.

I can wait until tomorrow before comitting the patch.

I booted Xen 4.12.1 to the Dom0 prompt on the Pine H64, and saw all the serial devices in /sys/firmware/devicetree/base/soc. Then I applied the patch, and the serial devices were gone. And yes, all the four main serial ports share one 4K page on the H6.

Cheers,
Andre.

Quoted 11 lines
Quoted 1 line

It's actually a shame that we need this enumeration, when all we are after is an answer to the question: Does a device used by Xen share a 4K page with a device handed off to Dom0? It sounds

like a nice rainy afternoon exercise to scan the DT to find those devices automatically and mask them (on the A64 for instance UART4 is on a different page).

I agree and I think we discussed about it before :). I would welcome such improvement in Xen, this would actually allow us to drop sunxi.c completely.

Cheers,

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Acked-by
#5 lore raw

Hi,

Quoted 25 lines · Andre Przywara

On Tue, 3 Dec 2019 16:52:45 +0000
Julien Grall <[email protected]> wrote:

Hi,

Quoted 20 lines · Andre Przywara
Quoted 7 lines

On Tue, 3 Dec 2019 11:39:58 +0000
Julien Grall <[email protected]> wrote:

Hi,

Quoted 2 lines

(+Andre)

Quoted 8 lines
Quoted 4 lines

Hi,

@Andre, IIRC you originally added the support for sunxi in Xen. Could you have a look at this patch?

Looks alright, and indeed the H6 needs it. Even though Allwinner totally re-arranged the memory map, they missed the opportunity to put each device at least in their own 4K page.

Thank you for the review!

Quoted 1 line
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

If you can wait till this evening, I can even test it.

I can wait until tomorrow before comitting the patch.

I booted Xen 4.12.1 to the Dom0 prompt on the Pine H64, and saw all the serial devices in /sys/firmware/devicetree/base/soc. Then I applied the patch, and the serial devices were gone. And yes, all the four main serial ports share one 4K page on the H6.

Thank you for the testing!

I have also committed it.

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel