lib: fix unnecessary boolean casts
PATCH 1/1 lib: fix unnecessary boolean casts
The values already boolean types, so the use of !! is unnecessary as it is used to convert to boolean.
--- lib/librte_mbuf/rte_mbuf.h | 2 +- lib/librte_mempool/rte_mempool.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
lib/librte_mbuf/rte_mbuf.h +1 -1
@@ -1535,7 +1535,7 @@ static inline int rte_pktmbuf_trim(struct rte_mbuf *m, uint16_t len)static inline int rte_pktmbuf_is_contiguous (const struct rte_mbuf *m) {__rte_mbuf_sanity_check (m,1 ); -return !!(m->nb_segs ==1 ); +return m->nb_segs ==1 ; }/**
lib/librte_mempool/rte_mempool.h +2 -2
@@ -1653,7 +1653,7 @@ rte_mempool_in_use_count(const struct rte_mempool *mp);static inline int rte_mempool_full (const struct rte_mempool *mp) { -return !!(rte_mempool_avail_count (mp) == mp->size); +return rte_mempool_avail_count (mp) == mp->size; }/**
@@ -1672,7 +1672,7 @@ rte_mempool_full(const struct rte_mempool *mp)static inline int rte_mempool_empty (const struct rte_mempool *mp) { -return !!(rte_mempool_avail_count (mp) ==0 ); +return rte_mempool_avail_count (mp) ==0 ; }/**
Signature · 1 line
2.17.1
Quoted 10 lines · Ciara Power
The values already boolean types, so the use of !! is unnecessary as it is used to convert to boolean.
Fixes ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure")Fixes a0fd91cefcc0 ("mempool: rename functions with confusing names")Signed-off-by Ciara Power <[email protected]>
Quoted 10 lines · Ciara Power
The values already boolean types, so the use of !! is unnecessary as it is used to convert to boolean.
Fixes ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure")Fixes a0fd91cefcc0 ("mempool: rename functions with confusing names")Signed-off-by Ciara Power <[email protected]>
Thanks
PATCH v2 1/1 lib: fix unnecessary double negation
In reply to Ciara PowerAn equality expression already returns either 0 or 1. There is no need to use double negation for these cases.
---
V2:
- Rebased onto master
- Changed commit subject and description
--- lib/librte_mbuf/rte_mbuf.h | 2 +- lib/librte_mempool/rte_mempool.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
lib/librte_mbuf/rte_mbuf.h +1 -1
@@ -1535,7 +1535,7 @@ static inline int rte_pktmbuf_trim(struct rte_mbuf *m, uint16_t len)static inline int rte_pktmbuf_is_contiguous (const struct rte_mbuf *m) {__rte_mbuf_sanity_check (m,1 ); -return !!(m->nb_segs ==1 ); +return m->nb_segs ==1 ; }/**
lib/librte_mempool/rte_mempool.h +2 -2
@@ -1653,7 +1653,7 @@ rte_mempool_in_use_count(const struct rte_mempool *mp);static inline int rte_mempool_full (const struct rte_mempool *mp) { -return !!(rte_mempool_avail_count (mp) == mp->size); +return rte_mempool_avail_count (mp) == mp->size; }/**
@@ -1672,7 +1672,7 @@ rte_mempool_full(const struct rte_mempool *mp)static inline int rte_mempool_empty (const struct rte_mempool *mp) { -return !!(rte_mempool_avail_count (mp) ==0 ); +return rte_mempool_avail_count (mp) ==0 ; }/**
Signature · 1 line
2.17.1
David Marchand
AppliedRe: [dpdk-dev] [PATCH v2] lib: fix unnecessary double negation
Quoted 11 lines · Ciara Power
An equality expression already returns either 0 or 1. There is no need to use double negation for these cases.
Fixes ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure")Fixes a0fd91cefcc0 ("mempool: rename functions with confusing names")Signed-off-by Ciara Power <[email protected]>Acked-by Olivier Matz <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>
Applied, thanks.
--
David Marchand