Skip to contentSkip to conversation

virtio-gpu: some edid clarifications

PATCH In review Gerd Hoffmann 2 participants 4 messages Nov 28, 2019 – Feb 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-gpu: some edid clarifications

Add some notes about fetching the EDID information.

---
 virtio-gpu.tex | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
virtio-gpu.tex +9 -4
index af4ca610d235..15dbf9f2ec82 100644
@@ -70,16 +70,21 @@ \subsubsection{Events}
 \begin{description}
 \item[VIRTIO_GPU_EVENT_DISPLAY] Display configuration has changed.
   The driver SHOULD use the VIRTIO_GPU_CMD_GET_DISPLAY_INFO command to
-  fetch the information from the device.
+  fetch the information from the device.  In case EDID support is
+  negotiated (VIRTIO_GPU_F_EDID feature flag) the device SHOULD also
+  fetch the updated EDID blobs using the VIRTIO_GPU_CMD_GET_EDID
+  command.
 \end{description}
 
 \devicenormative{\subsection}{Device Initialization}{Device Types / GPU Device / Device Initialization}
 
 The driver SHOULD query the display information from the device using
 the VIRTIO_GPU_CMD_GET_DISPLAY_INFO command and use that information
-for the initial scanout setup.  In case no information is available or
-all displays are disabled the driver MAY choose to use a fallback,
-such as 1024x768 at display 0.
+for the initial scanout setup.  In case EDID support is negotiated
+(VIRTIO_GPU_F_EDID feature flag) the device SHOULD also fetch the EDID
+information using the VIRTIO_GPU_CMD_GET_EDID command.  If no
+information is available or all displays are disabled the driver MAY
+choose to use a fallback, such as 1024x768 at display 0.
 
 \subsection{Device Operation}\label{sec:Device Types / GPU Device / Device Operation}
 
Signature · 6 lines
2.18.1


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
#1 lore raw
Quoted 3 lines · Gerd Hoffmann

Add some notes about fetching the EDID information.

As a minor nit, it is preferable to send spec patches on virtio-comment.

virtio-dev is for code patches (implementation development).

Quoted 41 lines
---
 virtio-gpu.tex | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
virtio-gpu.tex +9 -4
index af4ca610d235..15dbf9f2ec82 100644
@@ -70,16 +70,21 @@ \subsubsection{Events}
 \begin{description}
 \item[VIRTIO_GPU_EVENT_DISPLAY] Display configuration has changed.
   The driver SHOULD use the VIRTIO_GPU_CMD_GET_DISPLAY_INFO command to
-  fetch the information from the device.
+  fetch the information from the device.  In case EDID support is
+  negotiated (VIRTIO_GPU_F_EDID feature flag) the device SHOULD also
+  fetch the updated EDID blobs using the VIRTIO_GPU_CMD_GET_EDID
+  command.
 \end{description}
 
 \devicenormative{\subsection}{Device Initialization}{Device Types / GPU Device / Device Initialization}
 
 The driver SHOULD query the display information from the device using
 the VIRTIO_GPU_CMD_GET_DISPLAY_INFO command and use that information
-for the initial scanout setup.  In case no information is available or
-all displays are disabled the driver MAY choose to use a fallback,
-such as 1024x768 at display 0.
+for the initial scanout setup.  In case EDID support is negotiated
+(VIRTIO_GPU_F_EDID feature flag) the device SHOULD also fetch the EDID
+information using the VIRTIO_GPU_CMD_GET_EDID command.  If no
+information is available or all displays are disabled the driver MAY
+choose to use a fallback, such as 1024x768 at display 0.
 
 \subsection{Device Operation}\label{sec:Device Types / GPU Device / Device Operation}
 
Signature · 6 lines
2.18.1


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

#3 lore raw
Quoted 7 lines · Gerd Hoffmann
Quoted 1 line · Gerd Hoffmann

Add some notes about fetching the EDID information.

https://github.com/oasis-tcs/virtio-spec/issues/64

cheers,
Gerd

I pushed it now but it all needed a bunch of manual tweaking. Gerd I'd appreciate it if you follow the process described in README.md section "Use of github issues" in the future. Thanks!

Quoted 4 lines

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]