Skip to contentSkip to conversation

drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n

PATCH In review Guenter Roeck 4 participants 5 messages Dec 2, 2019 – Dec 3, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n

On systems with STACKTRACE_SUPPORT=n, we get:

WARNING: unmet direct dependencies detected for STACKTRACE
Depends on [n]: STACKTRACE_SUPPORT
Selected by [y]:
- STACKDEPOT [=y]

and build errors such as:

m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
(.text+0x11c): undefined reference to `save_stack_trace'

Add the missing deendency on STACKTRACE_SUPPORT.

Fixes 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for debugging")
Cc Lyude Paul <[email protected]>
Cc Sean Paul <[email protected]>
---
 drivers/gpu/drm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/Kconfig +1 -0
index 1168351267fd..bfdadc3667e0 100644
@@ -95,6 +95,7 @@ config DRM_KMS_FB_HELPER
 
 config DRM_DEBUG_DP_MST_TOPOLOGY_REFS
         bool "Enable refcount backtrace history in the DP MST helpers"
+	depends on STACKTRACE_SUPPORT
         select STACKDEPOT
         depends on DRM_KMS_HELPER
         depends on DEBUG_KERNEL
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Guenter Roeck

On systems with STACKTRACE_SUPPORT=n, we get:

WARNING: unmet direct dependencies detected for STACKTRACE
Depends on [n]: STACKTRACE_SUPPORT
Selected by [y]:
- STACKDEPOT [=y]

and build errors such as:

m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
(.text+0x11c): undefined reference to `save_stack_trace'

Quoted 6 lines

Add the missing deendency on STACKTRACE_SUPPORT.

Fixes 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for debugging")
Cc Lyude Paul <[email protected]>
Cc Sean Paul <[email protected]>

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Reviewed-by
#2 lore raw

I'll go ahead and push this to drm-misc-next, thanks!

Quoted 27 lines · Geert Uytterhoeven
Quoted 12 lines · Guenter Roeck

On systems with STACKTRACE_SUPPORT=n, we get:

WARNING: unmet direct dependencies detected for STACKTRACE
Depends on [n]: STACKTRACE_SUPPORT
Selected by [y]:
- STACKDEPOT [=y]

and build errors such as:

m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
(.text+0x11c): undefined reference to `save_stack_trace'

Quoted 7 lines

Add the missing deendency on STACKTRACE_SUPPORT.

Fixes 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for

debugging")

Gr{oetje,eeting}s,

Geert

Signature · 2 lines
Cheers,
	Lyude Paul
#3 lore raw
Quoted 3 lines · Lyude Paul

I'll go ahead and push this to drm-misc-next, thanks!

drm-misc-next-fixes since it's in the merge window. drm-misc-next is for 5.6 already.
-Daniel

Quoted 33 lines · Geert Uytterhoeven
Quoted 27 lines · Guenter Roeck
Quoted 12 lines

On systems with STACKTRACE_SUPPORT=n, we get:

WARNING: unmet direct dependencies detected for STACKTRACE
Depends on [n]: STACKTRACE_SUPPORT
Selected by [y]:
- STACKDEPOT [=y]

and build errors such as:

m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
(.text+0x11c): undefined reference to `save_stack_trace'

Quoted 7 lines

Add the missing deendency on STACKTRACE_SUPPORT.

Fixes 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for

debugging")

Gr{oetje,eeting}s,

Geert

Signature · 2 lines
Cheers,
	Lyude Paul
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw
Quoted 8 lines · Daniel Vetter
Quoted 3 lines · Lyude Paul

I'll go ahead and push this to drm-misc-next, thanks!

drm-misc-next-fixes since it's in the merge window. drm-misc-next is for 5.6 already.
-Daniel

Ahh, that explains things :). Pushed, thanks for the patches!

Quoted 34 lines
Quoted 34 lines · Geert Uytterhoeven
Quoted 28 lines · Guenter Roeck
Quoted 12 lines

On systems with STACKTRACE_SUPPORT=n, we get:

WARNING: unmet direct dependencies detected for STACKTRACE
Depends on [n]: STACKTRACE_SUPPORT
Selected by [y]:
- STACKDEPOT [=y]

and build errors such as:

m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
(.text+0x11c): undefined reference to `save_stack_trace'

Quoted 8 lines

Add the missing deendency on STACKTRACE_SUPPORT.

Fixes 12a280c72868 ("drm/dp_mst: Add topology ref history tracking

for
debugging")

Gr{oetje,eeting}s,

Geert

Signature · 2 lines
Cheers,
	Lyude Paul
Signature · 7 lines
Cheers,
	Lyude Paul

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel