Skip to contentSkip to conversation

i915: Expose panel power cycle delay to i915_panel_timings

PATCH In review Anshuman Gupta 3 participants 5 messages Nov 18, 2019 – Dec 3, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i915: Expose panel power cycle delay to i915_panel_timings

Putting down the AUX power domain reference count in edp vdd off async sequence takes too much of time (relative to panel power cycle delay) therefore it make sense to expose the panel power cycle delay to i915_panel_timings along with other delays.
It can be use by DC state IGT to wait for strict power cycle delay in order to check for various DC state counters.

---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +2 -0
index cab632791f73..c075cc2b7bb5 100644
@@ -4436,6 +4436,8 @@ static int i915_panel_show(struct seq_file *m, void *data)
 		   intel_dp->panel_power_up_delay);
 	seq_printf(m, "Panel power down delay: %d\n",
 		   intel_dp->panel_power_down_delay);
+	seq_printf(m, "Panel power cycle delay: %d\n",
+		   intel_dp->panel_power_cycle_delay);
 	seq_printf(m, "Backlight on delay: %d\n",
 		   intel_dp->backlight_on_delay);
 	seq_printf(m, "Backlight off delay: %d\n",
Signature · 6 lines
2.24.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for i915: Expose panel power cycle delay to i915_panel_timings

== Series Details ==

== Series Details ==

Series: i915: Expose panel power cycle delay to i915_panel_timings
URL : https://patchwork.freedesktop.org/series/69633/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7365 -> Patchwork_15316
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_15316 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_15316, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15316/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_15316:

### IGT changes ###

#### Possible regressions ####

* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-6770hq: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7365/fi-skl-6770hq/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15316/fi-skl-6770hq/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_15316 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_hangcheck:
- fi-hsw-4770r: [PASS][3] -> [DMESG-FAIL][4] ([fdo#111991])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7365/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15316/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html

#### Possible fixes ####

* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [DMESG-WARN][5] ([fdo#112261]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7365/fi-skl-lmem/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15316/fi-skl-lmem/igt@[email protected]

* igt@i915_selftest@live_gem_contexts:
- fi-bsw-nick: [INCOMPLETE][7] ([fdo# 111542]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7365/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15316/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][9] ([fdo#111045] / [fdo#111096]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7365/fi-kbl-7500u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15316/fi-kbl-7500u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298

Participating hosts (50 -> 44)
------------------------------

Missing (6): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7365 -> Patchwork_15316

CI-20190529: 20190529
CI_DRM_7365: ae28c3736610ca3c242ea9d0af8cbc767a0ddeba @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5292: ea9cd47fdb72c16d5ec84c04a85122c451c30025 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15316: 6a11f70287e214fcfe486b81ddd21f1dfaaed91d @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

6a11f70287e2 i915: Expose panel power cycle delay to i915_panel_timings

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15316/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#2 lore raw
In reply to Anshuman Gupta
Quoted 7 lines · Anshuman Gupta

Putting down the AUX power domain reference count in edp vdd off async sequence takes too much of time (relative to panel power cycle delay) therefore it make sense to expose the panel power cycle delay to i915_panel_timings along with other delays.
It can be use by DC state IGT to wait for strict power cycle delay in order to check for various DC state counters.

Catching up on review, are you suggesting to look at this kind of debugfs files for tests? Please find another way.

I don't mind having the debugfs info per se.

BR,
Jani.

Quoted 20 lines
---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +2 -0
index cab632791f73..c075cc2b7bb5 100644
@@ -4436,6 +4436,8 @@ static int i915_panel_show(struct seq_file *m, void *data)
 		   intel_dp->panel_power_up_delay);
 	seq_printf(m, "Panel power down delay: %d\n",
 		   intel_dp->panel_power_down_delay);
+	seq_printf(m, "Panel power cycle delay: %d\n",
+		   intel_dp->panel_power_cycle_delay);
 	seq_printf(m, "Backlight on delay: %d\n",
 		   intel_dp->backlight_on_delay);
 	seq_printf(m, "Backlight off delay: %d\n",
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 11 lines · Jani Nikula
Quoted 7 lines · Anshuman Gupta

Putting down the AUX power domain reference count in edp vdd off async sequence takes too much of time (relative to panel power cycle delay) therefore it make sense to expose the panel power cycle delay to i915_panel_timings along with other delays.
It can be use by DC state IGT to wait for strict power cycle delay in order to check for various DC state counters.

Catching up on review, are you suggesting to look at this kind of debugfs files for tests? Please find another way.

Actually on few panels power cycle delay is too much that it is required to wait for 6 seconds in igt for an timeout, but this could really affect CI execution time on panel with lesser power cycle delay.
(https://patchwork.freedesktop.org/series/68478/)
For this specific reason i thought it may be good to expose panel power cycle delay with other panel delay and use that in igt.
Thanks ,
Anshuman.

Quoted 13 lines

I don't mind having the debugfs info per se.

BR,
Jani.

Quoted 7 lines
---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
 1 file changed, 2 insertions(+)
Quoted 16 lines
Quoted 13 lines
drivers/gpu/drm/i915/i915_debugfs.c +2 -0
index cab632791f73..c075cc2b7bb5 100644
@@ -4436,6 +4436,8 @@ static int i915_panel_show(struct seq_file *m, void *data)
 		   intel_dp->panel_power_up_delay);
 	seq_printf(m, "Panel power down delay: %d\n",
 		   intel_dp->panel_power_down_delay);
+	seq_printf(m, "Panel power cycle delay: %d\n",
+		   intel_dp->panel_power_cycle_delay);
 	seq_printf(m, "Backlight on delay: %d\n",
 		   intel_dp->backlight_on_delay);
 	seq_printf(m, "Backlight off delay: %d\n",
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#4 lore raw
Quoted 12 lines · Anshuamn Gupta
Quoted 11 lines · Jani Nikula
Quoted 7 lines · Anshuman Gupta

Putting down the AUX power domain reference count in edp vdd off async sequence takes too much of time (relative to panel power cycle delay) therefore it make sense to expose the panel power cycle delay to i915_panel_timings along with other delays.
It can be use by DC state IGT to wait for strict power cycle delay in order to check for various DC state counters.

Catching up on review, are you suggesting to look at this kind of debugfs files for tests? Please find another way.

Quoted 7 lines

Actually on few panels power cycle delay is too much that it is required to wait for 6 seconds in igt for an timeout, but this could really affect CI execution time on panel with lesser power cycle delay.
(https://patchwork.freedesktop.org/series/68478/)
For this specific reason i thought it may be good to expose panel power cycle delay with other panel delay and use that in igt.

Fix the kernel driver to DTRT instead of exposing the guts and having igt work around it.

BR,
Jani.

Quoted 31 lines

Thanks ,
Anshuman.

Quoted 29 lines

I don't mind having the debugfs info per se.

BR,
Jani.

Quoted 20 lines
---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +2 -0
index cab632791f73..c075cc2b7bb5 100644
@@ -4436,6 +4436,8 @@ static int i915_panel_show(struct seq_file *m, void *data)
 		   intel_dp->panel_power_up_delay);
 	seq_printf(m, "Panel power down delay: %d\n",
 		   intel_dp->panel_power_down_delay);
+	seq_printf(m, "Panel power cycle delay: %d\n",
+		   intel_dp->panel_power_cycle_delay);
 	seq_printf(m, "Backlight on delay: %d\n",
 		   intel_dp->backlight_on_delay);
 	seq_printf(m, "Backlight off delay: %d\n",
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx