Skip to contentSkip to conversation

scsi: smartpqi: add missed free_irq in suspend

PATCH RESEND NAK Chuhong Yuan 3 participants 3 messages Dec 3, 2019 – Jan 20, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 scsi: smartpqi: add missed free_irq in suspend

The driver calls request_irq in resume but does not call free_irq in suspend.
Add the missed call to fix it.

---
 drivers/scsi/smartpqi/smartpqi_init.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/scsi/smartpqi/smartpqi_init.c +2 -0
index 7b7ef3acb504..2251c39afb1b 100644
@@ -8078,6 +8078,8 @@ static __maybe_unused int pqi_suspend(struct pci_dev *pci_dev, pm_message_t stat
 	pqi_ctrl_wait_for_pending_io(ctrl_info, NO_TIMEOUT);
 	pqi_stop_heartbeat_timer(ctrl_info);
 
+	free_irq(pci_irq_vector(pci_dev, 0), &ctrl_info->queue_groups[0]);
+
 	if (state.event == PM_EVENT_FREEZE)
 		return 0;
 
Signature · 1 line
2.24.0
#1 lore raw
Quoted 4 lines

The driver calls request_irq in resume but does not call free_irq in suspend.
Add the missed call to fix it.

Microsemi: Please review!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
maintainer NAK
#2 lore raw
In reply to Chuhong Yuan

-----Original Message-----

The driver calls request_irq in resume but does not call free_irq in suspend. Add the missed call to fix it.

NAK: free_irq is called in pqi_resume after checking for correct power state change. (in pqi_free_interrupts())

Thanks for your review,
Don

---
 drivers/scsi/smartpqi/smartpqi_init.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/scsi/smartpqi/smartpqi_init.c +3 -0
index 7b7ef3acb504..2251c39afb1b 100644
@@ -8078,6 +8078,8 @@ static __maybe_unused int pqi_suspend(struct pci_dev *pci_dev, pm_message_t stat
        pqi_ctrl_wait_for_pending_io(ctrl_info, NO_TIMEOUT);
        pqi_stop_heartbeat_timer(ctrl_info);
 
+       free_irq(pci_irq_vector(pci_dev, 0), 
+ &ctrl_info->queue_groups[0]);
+
        if (state.event == PM_EVENT_FREEZE)
                return 0;

--
2.24.0