Skip to contentSkip to conversation

media: v4l2: Fix fourcc names for BAYER12P

PATCH In review Daniel Gomez 2 participants 3 messages Dec 3, 2019 – Dec 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: v4l2: Fix fourcc names for BAYER12P

Fix documentation fourcc names for the 12-bit packed Bayer formats.

---
 Documentation/media/uapi/v4l/pixfmt-srggb12p.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/media/uapi/v4l/pixfmt-srggb12p.rst +1 -1
index 960851275f23..7060a4ffad08 100644
@@ -13,7 +13,7 @@
 .. _v4l2-pix-fmt-sgrbg12p:
 
 *******************************************************************************************************************************
-V4L2_PIX_FMT_SRGGB12P ('pRAA'), V4L2_PIX_FMT_SGRBG12P ('pgAA'), V4L2_PIX_FMT_SGBRG12P ('pGAA'), V4L2_PIX_FMT_SBGGR12P ('pBAA'),
+V4L2_PIX_FMT_SRGGB12P ('pBCC'), V4L2_PIX_FMT_SGRBG12P ('pgCC'), V4L2_PIX_FMT_SGBRG12P ('pGCC'), V4L2_PIX_FMT_SBGGR12P ('pBCC'),
 *******************************************************************************************************************************
 
 
Signature · 1 line
2.24.0.rc1
#1 lore raw

Hi Daniel,

Quoted 12 lines · Daniel Gomez

Fix documentation fourcc names for the 12-bit packed Bayer formats.

---
 Documentation/media/uapi/v4l/pixfmt-srggb12p.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/media/uapi/v4l/pixfmt-srggb12p.rst +0 -0
index 960851275f23..7060a4ffad08 100644

Documentation/media/uapi/v4l/pixfmt-srggb12p.rst line 17

Quoted 6 lines
Documentation/media/uapi/v4l/pixfmt-srggb12p.rst +1 -1
@@ -13,7 +13,7 @@
 .. _v4l2-pix-fmt-sgrbg12p:
 
 *******************************************************************************************************************************
-V4L2_PIX_FMT_SRGGB12P ('pRAA'), V4L2_PIX_FMT_SGRBG12P ('pgAA'), V4L2_PIX_FMT_SGBRG12P ('pGAA'), V4L2_PIX_FMT_SBGGR12P ('pBAA'),
+V4L2_PIX_FMT_SRGGB12P ('pBCC'), V4L2_PIX_FMT_SGRBG12P ('pgCC'), V4L2_PIX_FMT_SGBRG12P ('pGCC'), V4L2_PIX_FMT_SBGGR12P ('pBCC'),
 *******************************************************************************************************************************

Thanks for the patch.

There's a bug there, but this doesn't still seem entirely correct. For instance, V4L2_PIX_FMT_SRGGB12P is defined as follows in videodev2.h:

#define V4L2_PIX_FMT_SRGGB12P v4l2_fourcc('p', 'R', 'C', 'C')

Could you fix that, and check the rest?

Please also set the To: header to a valid value; not setting it sometimes ends up replies being only sent to the original sender of the patch, omitting the list and others cc'd.

Signature · 3 lines
Kind regards,

Sakari Ailus
#2 lore raw

Hi Sakari,

Quoted 25 lines · Sakari Ailus

Hi Daniel,

Quoted 12 lines · Daniel Gomez

Fix documentation fourcc names for the 12-bit packed Bayer formats.

---
 Documentation/media/uapi/v4l/pixfmt-srggb12p.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/media/uapi/v4l/pixfmt-srggb12p.rst +0 -0
index 960851275f23..7060a4ffad08 100644

Documentation/media/uapi/v4l/pixfmt-srggb12p.rst line 17

Quoted 6 lines
Documentation/media/uapi/v4l/pixfmt-srggb12p.rst +1 -1
@@ -13,7 +13,7 @@
 .. _v4l2-pix-fmt-sgrbg12p:
 
 *******************************************************************************************************************************
-V4L2_PIX_FMT_SRGGB12P ('pRAA'), V4L2_PIX_FMT_SGRBG12P ('pgAA'), V4L2_PIX_FMT_SGBRG12P ('pGAA'), V4L2_PIX_FMT_SBGGR12P ('pBAA'),
+V4L2_PIX_FMT_SRGGB12P ('pBCC'), V4L2_PIX_FMT_SGRBG12P ('pgCC'), V4L2_PIX_FMT_SGBRG12P ('pGCC'), V4L2_PIX_FMT_SBGGR12P ('pBCC'),
 *******************************************************************************************************************************

Thanks for the patch.

Quoted 6 lines

There's a bug there, but this doesn't still seem entirely correct. For instance, V4L2_PIX_FMT_SRGGB12P is defined as follows in videodev2.h:

#define V4L2_PIX_FMT_SRGGB12P v4l2_fourcc('p', 'R', 'C', 'C')

Could you fix that, and check the rest?

Thanks for the review.
I'll send a new patch with the proper names:
include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SBGGR12P v4l2_fourcc('p', 'B', 'C', 'C') include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SGBRG12P v4l2_fourcc('p', 'G', 'C', 'C') include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SGRBG12P v4l2_fourcc('p', 'g', 'C', 'C') include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SRGGB12P v4l2_fourcc('p', 'R', 'C', 'C')

Quoted 5 lines

Please also set the To: header to a valid value; not setting it sometimes ends up replies being only sent to the original sender of the patch, omitting the list and others cc'd.

okay.

Quoted 4 lines

--
Kind regards,

Sakari Ailus