drivers: Fix boot problem on SuperH
Subsystems (2)
PATCH v2 1/1 drivers: Fix boot problem on SuperH
SuperH images crash too eearly to display any console output. Bisect points to commit 507fd01d5333 ("drivers: move the early platform device support to arch/sh"). An analysis of that patch suggests that early_platform_cleanup() is now called at the wrong time. Restoring its call point fixes the problem.
Cc Bartosz Golaszewski <[email protected]>
Fixes 507fd01d5333 ("drivers: move the early platform device support to arch/sh")
Tested-by Geert Uytterhoeven <[email protected]>
Signed-off-by Guenter Roeck <[email protected]>
---
v2: Use __init annotation for early_platform_cleanup()
arch/sh/drivers/platform_early.c | 11 ++--------- drivers/base/platform.c | 4 ++++ 2 files changed, 6 insertions(+), 9 deletions(-)
arch/sh/drivers/platform_early.c +2 -9
@@ -325,9 +325,9 @@ int __init sh_early_platform_driver_probe(char *class_str, }/** -* sh_early_platform_cleanup - clean up early platform code +* early_platform_cleanup - clean up early platform code */ -static int __init sh_early_platform_cleanup (void ) +void __init early_platform_cleanup (void ) {struct platform_device *pd, *pd2;
@@ -337,11 +337,4 @@ static int __init sh_early_platform_cleanup(void)list_del (&pd->dev.devres_head);memset (&pd->dev.devres_head,0 ,sizeof (pd->dev.devres_head)); } - -return 0 ; } -/* -* This must happen once after all early devices are probed but before probing -* real platform devices. -*/ -subsys_initcall (sh_early_platform_cleanup);
drivers/base/platform.c +4 -0
@@ -1325,10 +1325,14 @@ struct device *platform_find_device_by_driver(struct device *start, }EXPORT_SYMBOL_GPL (platform_find_device_by_driver); +void __weak __init early_platform_cleanup (void ) { } +int __init platform_bus_init (void ) {int error; +early_platform_cleanup (); + error =device_register (&platform_bus);if (error) {put_device (&platform_bus);
Signature · 1 line
2.17.1
Quoted 10 lines · Guenter Roeck
SuperH images crash too eearly to display any console output. Bisect points to commit
507fd01d5333("drivers: move the early platform device support toarch/sh"). An analysis of that patch suggests thatearly_platform_cleanup()is now called at the wrong time. Restoring its call point fixes the problem.Cc Bartosz Golaszewski <[email protected]>Fixes 507fd01d5333 ("drivers: move the early platform device support to arch/sh")Tested-by Geert Uytterhoeven <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Yup, I need this too.
Acked-by Rob Landley <[email protected]>
Rob