dt-bindings: arm: rockchip: Add libretech for roc-pc binding
Subsystems (2)
PATCH v2 1/2 dt-bindings: arm: rockchip: Add libretech for roc-pc binding
Though the ROC-PC is manufactured by firefly, it is co-designed by libretch like other Libretech computer boards from allwinner, amlogic does.
It is always meaningful to keep maintain those vendors who are part of design participation, so add libretech roc-pc compatible with existing binding.
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +1 -0
@@ -100,6 +100,7 @@ properties: - description: Firefly ROC-RK3399-PC items: - enum: + - libretech,roc-rk3399-pc - firefly,roc-rk3399-pc - firefly,roc-rk3399-pc-mezzanine - const: rockchip,rk3399
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v2 2/2 arm64: dts: rockchip: Add libretech compatible for ROC-PC
Though the ROC-PC is manufactured by firefly, it is co-designed by libretch like other Libretech computer boards from allwinner, amlogic does.
So, it is always meaningful to keep maintain those vendors who are part of design participation so append the compatible "libretech,roc-rk3399-pc" to existing roc-pc dts file.
--- arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts +2 -1
@@ -8,5 +8,6 @@ / { model = "Firefly ROC-RK3399-PC Board"; - compatible = "firefly,roc-rk3399-pc", "rockchip,rk3399"; + compatible = "libretech,roc-rk3399-pc", "firefly,roc-rk3399-pc", + "rockchip,rk3399"; };
Signature · 1 line
2.18.0.321.gffc6fa0e3
Rob Herring
maintainerQuoted 7 lines · Jagan Teki
Though the ROC-PC is manufactured by firefly, it is co-designed by libretch like other Libretech computer boards from allwinner, amlogic does.
It is always meaningful to keep maintain those vendors who are part of design participation, so add libretech roc-pc compatible with existing binding.
Maybe so, but this is pretty pointless if it's not different h/w. Compatible strings are simply a h/w identifier.
Quoted 10 lines
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/arm/rockchip.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0
Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 105
Quoted 6 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +1
-0@@ -100,6 +100,7 @@ properties: - description: Firefly ROC-RK3399-PC items: - enum: + - libretech,roc-rk3399-pc - firefly,roc-rk3399-pc - firefly,roc-rk3399-pc-mezzanine
This doesn't match your change in the dts. file. The schema says there are 2 strings with the first one being 1 of these 3.
Quoted 4 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0- const: rockchip,rk3399Signature · 1 line
2.18.0.321.gffc6fa0e3