Skip to contentSkip to conversation

HID: uhid: Fix returning EPOLLOUT from uhid_char_poll

PATCH Applied Marcel Holtmann 2 participants 2 messages Dec 4, 2019 – Dec 9, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: uhid: Fix returning EPOLLOUT from uhid_char_poll

Always return EPOLLOUT from uhid_char_poll to allow polling /dev/uhid for writable state.

Fixes 1f9dec1e0164 ("HID: uhid: allow poll()'ing on uhid devices")
---
 drivers/hid/uhid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/uhid.c +1 -1
index fa0cc0899827..935c3d0a3b63 100644
@@ -772,7 +772,7 @@ static __poll_t uhid_char_poll(struct file *file, poll_table *wait)
 	if (uhid->head != uhid->tail)
 		return EPOLLIN | EPOLLRDNORM;
 
-	return 0;
+	return EPOLLOUT | EPOLLWRNORM;
 }
 
 static const struct file_operations uhid_fops = {
Signature · 1 line
2.23.0
maintainer Applied
#1 lore raw
Quoted 6 lines · Marcel Holtmann

Always return EPOLLOUT from uhid_char_poll to allow polling /dev/uhid for writable state.

Fixes 1f9dec1e0164 ("HID: uhid: allow poll()'ing on uhid devices")

Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs