Skip to contentSkip to conversation

Kconfig: disambiguate config names for tiny printf

PATCH New Thomas Hebb 2 participants 5 messages Nov 10, 2019 – Dec 4, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Kconfig: disambiguate config names for tiny printf

27084c03d36a ("spl: Allow tiny printf() to be controlled in SPL and TPL") split this option in two for TPL and SPL, but didn't change the Kconfig names, making them hard to set quickly.

---
 lib/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/Kconfig +2 -2
index b8a8509d72..55dedcbcdd 100644
@@ -96,7 +96,7 @@ config SYS_HZ
 	  set to 1000.
 
 config SPL_USE_TINY_PRINTF
-	bool "Enable tiny printf() version"
+	bool "Enable tiny printf() version in SPL"
 	depends on SPL
 	default y
 	help
@@ -108,7 +108,7 @@ config SPL_USE_TINY_PRINTF
 	  The supported format specifiers are %c, %s, %u/%d and %x.
 
 config TPL_USE_TINY_PRINTF
-	bool "Enable tiny printf() version"
+	bool "Enable tiny printf() version in TPL"
 	depends on TPL
 	default y if SPL_USE_TINY_PRINTF
 	help
Signature · 1 line
2.23.0
#1 lore raw

PATCH 2/3 Kconfig: add description for TPL_ROCKCHIP_COMMON_BOARD

SPL_ROCKCHIP_COMMON_BOARD, an almost identical option, has a title but this one doesn't for some reason. Add a description to make the menu easier to read.

---
 arch/arm/mach-rockchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-rockchip/Kconfig +1 -1
index f5a80b4f0c..5e5f910b9a 100644
@@ -259,7 +259,7 @@ config SPL_ROCKCHIP_COMMON_BOARD
 	  no TPL for the board.
 
 config TPL_ROCKCHIP_COMMON_BOARD
-	bool ""
+	bool "Rockchip TPL common board file"
 	depends on TPL
 	help
 	  Rockchip SoCs have similar boot process, prefer to use TPL for DRAM
Signature · 1 line
2.23.0
#2 lore raw

PATCH 3/3 Kconfig: make TPL_DM_SERIAL depend on TPL_DM

In reply to Thomas Hebb

This missing dependency seems like an oversight, since all other TPL_DM_* options have it.

---
 drivers/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/Kconfig +1 -1
index d36a0108ea..ece7d87d4c 100644
@@ -145,7 +145,7 @@ config SPL_DM_SERIAL
 
 config TPL_DM_SERIAL
 	bool "Enable Driver Model for serial drivers in TPL"
-	depends on DM_SERIAL
+	depends on DM_SERIAL && TPL_DM
 	default y if TPL && DM_SERIAL
 	help
 	  Enable driver model for serial in TPL. This replaces
Signature · 1 line
2.23.0
#3 lore raw

PATCH 3/3 Kconfig: make TPL_DM_SERIAL depend on TPL_DM

Quoted 4 lines · Thomas Hebb

This missing dependency seems like an oversight, since all other TPL_DM_* options have it.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191203/399134fa/attachment.sig>
#4 lore raw

PATCH 1/3 Kconfig: disambiguate config names for tiny printf

In reply to Thomas Hebb
Quoted 5 lines · Thomas Hebb

27084c03d36a ("spl: Allow tiny printf() to be controlled in SPL and TPL") split this option in two for TPL and SPL, but didn't change the Kconfig names, making them hard to set quickly.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191203/478ea108/attachment.sig>