Skip to contentSkip to conversation

media: ov5640: Fix check for PLL1 exceeding max allowed rate

PATCH Superseded Adam Ford 3 participants 4 messages Dec 4, 2019

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH v2 1/1 media: ov5640: Fix check for PLL1 exceeding max allowed rate

The PLL calculation routine checks the wrong variable name 'rate' when it should be called '_rate' when checking to see whether or not the PLL1 output frequency exceeds 1GHz.

This patch changes it to the correct variable '_rate'

---
V2: No code change. Only change commit description to be less confusing.

drivers/media/i2c/ov5640.c +1 -1
index 5e495c833d32..bb968e764f31 100644
@@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
 			 * We have reached the maximum allowed PLL1 output,
 			 * increase sysdiv.
 			 */
-			if (!rate)
+			if (!_rate)
 				break;
 
 			/*
Signature · 1 line
2.20.1
#1 lore raw

Hi Adam,

Quoted 9 lines · Adam Ford

The PLL calculation routine checks the wrong variable name 'rate' when it should be called '_rate' when checking to see whether or not the PLL1 output frequency exceeds 1GHz.

This patch changes it to the correct variable '_rate'

Maybe add a Fixes tag too?

#2 lore raw
In reply to Adam Ford

Hi Adam,

Quoted 8 lines · Adam Ford

The PLL calculation routine checks the wrong variable name 'rate' when it should be called '_rate' when checking to see whether or not the PLL1 output frequency exceeds 1GHz.

This patch changes it to the correct variable '_rate'

Why have you dropped the fixes tag you had in v1?

Fixes aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate")

I'm not the one who collects patches, so maybe wait for Sakari or Hans to tell you if you need to resend or not :)

Thanks
j

Quoted 19 lines

---
V2: No code change. Only change commit description to be less confusing.

drivers/media/i2c/ov5640.c +1 -2
index 5e495c833d32..bb968e764f31 100644
@@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
 			 * We have reached the maximum allowed PLL1 output,
 			 * increase sysdiv.
 			 */
-			if (!rate)
+			if (!_rate)
 				break;
 
 			/*
--

2.20.1

author
#3 lore raw
Quoted 13 lines · Jacopo Mondi

Hi Adam,

Quoted 8 lines · Adam Ford

The PLL calculation routine checks the wrong variable name 'rate' when it should be called '_rate' when checking to see whether or not the PLL1 output frequency exceeds 1GHz.

This patch changes it to the correct variable '_rate'

Quoted 6 lines

Why have you dropped the fixes tag you had in v1?

Fixes aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate")

I'm not the one who collects patches, so maybe wait for Sakari or Hans to tell you if you need to resend or not :)

It wasn't intentional. I couldn't find the original patch nor could I find it in patchwork, so I re-did it from scratch and forgot. (I have too many different computers)

I already sent a V3 before I read your e-mail. Sorry about that.

adam

Quoted 23 lines

Thanks
j

Quoted 19 lines

---
V2: No code change. Only change commit description to be less confusing.

drivers/media/i2c/ov5640.c +1 -2
index 5e495c833d32..bb968e764f31 100644
@@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
                       * We have reached the maximum allowed PLL1 output,
                       * increase sysdiv.
                       */
-                     if (!rate)
+                     if (!_rate)
                              break;
 
                      /*
--

2.20.1