media: ov5640: Fix check for PLL1 exceeding max allowed rate
PATCH v2 1/1 media: ov5640: Fix check for PLL1 exceeding max allowed rate
The PLL calculation routine checks the wrong variable name 'rate' when it should be called '_rate' when checking to see whether or not the PLL1 output frequency exceeds 1GHz.
This patch changes it to the correct variable '_rate'
---
V2: No code change. Only change commit description to be less confusing.
drivers/media/i2c/ov5640.c +1 -1
@@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,* We have reached the maximum allowed PLL1 output, * increase sysdiv. */ -if (!rate) +if (!_rate)break ;/*
Signature · 1 line
2.20.1
Hi Adam,
Quoted 9 lines · Adam Ford
The PLL calculation routine checks the wrong variable name 'rate' when it should be called '
_rate' when checking to see whether or not the PLL1 output frequency exceeds 1GHz.This patch changes it to the correct variable '
_rate'Acked-by Jacopo Mondi <[email protected]>Signed-off-by Adam Ford <[email protected]>
Maybe add a Fixes tag too?
Hi Adam,
Quoted 8 lines · Adam Ford
The PLL calculation routine checks the wrong variable name 'rate' when it should be called '
_rate' when checking to see whether or not the PLL1 output frequency exceeds 1GHz.This patch changes it to the correct variable '
_rate'Acked-by Jacopo Mondi <[email protected]>Signed-off-by Adam Ford <[email protected]>
Why have you dropped the fixes tag you had in v1?
I'm not the one who collects patches, so maybe wait for Sakari or Hans to tell you if you need to resend or not :)
Thanks
j
Quoted 19 lines
---
V2: No code change. Only change commit description to be less confusing.drivers/media/i2c/ov5640.c +1
-2@@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,* We have reached the maximum allowed PLL1 output, * increase sysdiv. */ -if (!rate) +if (!_rate)break ;/* -- 2.20.1
Quoted 13 lines · Jacopo Mondi
Hi Adam,
Quoted 8 lines · Adam Ford
The PLL calculation routine checks the wrong variable name 'rate' when it should be called '
_rate' when checking to see whether or not the PLL1 output frequency exceeds 1GHz.This patch changes it to the correct variable '
_rate'Acked-by Jacopo Mondi <[email protected]>Signed-off-by Adam Ford <[email protected]>
Quoted 6 lines
Why have you dropped the fixes tag you had in v1?
Fixes aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate")I'm not the one who collects patches, so maybe wait for Sakari or Hans to tell you if you need to resend or not :)
It wasn't intentional. I couldn't find the original patch nor could I find it in patchwork, so I re-did it from scratch and forgot. (I have too many different computers)
I already sent a V3 before I read your e-mail. Sorry about that.
adam
Quoted 23 lines
Thanks
jQuoted 19 lines
---
V2: No code change. Only change commit description to be less confusing.drivers/media/i2c/ov5640.c +1
-2@@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,* We have reached the maximum allowed PLL1 output, * increase sysdiv. */ -if (!rate) +if (!_rate)break ;/* -- 2.20.1