Skip to contentSkip to conversation

hexagon: io: Define ioremap_uc to fix build error

PATCH In review Guenter Roeck 3 participants 5 messages Dec 4, 2019 – Dec 10, 2019 Qualcomm hexagon architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hexagon: io: Define ioremap_uc to fix build error

ioremap_uc is now mandatory.

lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'

Fixes e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
Cc Tuowen Zhao <[email protected]>
Cc Mika Westerberg <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Luis Chamberlain <[email protected]>
Cc Lee Jones <[email protected]>
---
 arch/hexagon/include/asm/io.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/hexagon/include/asm/io.h +1 -1
index 539e3efcf39c..39e5605c5d42 100644
@@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
 
 void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
 #define ioremap_nocache ioremap
-
+#define ioremap_uc ioremap
 
 #define __raw_writel writel
 
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Guenter Roeck

ioremap_uc is now mandatory.

lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'

Thanks for a fix!

Quoted 28 lines
Fixes e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
Cc Tuowen Zhao <[email protected]>
Cc Mika Westerberg <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Luis Chamberlain <[email protected]>
Cc Lee Jones <[email protected]>
---
 arch/hexagon/include/asm/io.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/hexagon/include/asm/io.h +1 -1
index 539e3efcf39c..39e5605c5d42 100644
@@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
 
 void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
 #define ioremap_nocache ioremap
-
+#define ioremap_uc ioremap
 
 #define __raw_writel writel
 
Signature · 1 line
2.17.1
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
In reply to Guenter Roeck
Quoted 20 lines · Guenter Roeck

ioremap_uc is now mandatory.

lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'

Fixes e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
Cc Tuowen Zhao <[email protected]>
Cc Mika Westerberg <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Luis Chamberlain <[email protected]>
Cc Lee Jones <[email protected]>
---
 arch/hexagon/include/asm/io.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/hexagon/include/asm/io.h +0 -0
index 539e3efcf39c..39e5605c5d42 100644

arch/hexagon/include/asm/io.h static inline void writel(u32 data, volatile void __iomem *addr) · line 178

Quoted 7 lines
arch/hexagon/include/asm/io.h +1 -1
@@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
 
 void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
 #define ioremap_nocache ioremap
-
+#define ioremap_uc ioremap
 
 #define __raw_writel writel

Do we really need this? There is only one user of ioremap_uc(), which Christoph is trying hard to get rid of, and the new devres helper that triggers all of this :-(
https://lore.kernel.org/dri-devel/[email protected]/

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#3 lore raw
Quoted 27 lines · Geert Uytterhoeven
Quoted 26 lines · Guenter Roeck

ioremap_uc is now mandatory.

lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'

Fixes e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
Cc Tuowen Zhao <[email protected]>
Cc Mika Westerberg <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Luis Chamberlain <[email protected]>
Cc Lee Jones <[email protected]>
---
  arch/hexagon/include/asm/io.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/hexagon/include/asm/io.h +1 -1
index 539e3efcf39c..39e5605c5d42 100644
@@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
 
  void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
  #define ioremap_nocache ioremap
-
+#define ioremap_uc ioremap
 
Quoted 7 lines

arch/hexagon/include/asm/io.h static inline void writel(u32 data, volatile void __iomem *addr) · line 178

Quoted 1 line
arch/hexagon/include/asm/io.h +0 -0
  #define __raw_writel writel

Do we really need this? There is only one user of ioremap_uc(), which Christoph is trying hard to get rid of, and the new devres helper that triggers all of this :-(
https://lore.kernel.org/dri-devel/[email protected]/

One may ask why we needed a devres helper in the first place if there is indeed just one user.

Either case, I don't really care, as long as the problem is fixed.

Guenter

#4 lore raw

Hi Günter,

Quoted 35 lines · Guenter Roeck
Quoted 27 lines · Geert Uytterhoeven
Quoted 26 lines · Guenter Roeck

ioremap_uc is now mandatory.

lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'

Fixes e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
Cc Tuowen Zhao <[email protected]>
Cc Mika Westerberg <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Luis Chamberlain <[email protected]>
Cc Lee Jones <[email protected]>
---
  arch/hexagon/include/asm/io.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/hexagon/include/asm/io.h +1 -1
index 539e3efcf39c..39e5605c5d42 100644
@@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
 
  void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
  #define ioremap_nocache ioremap
-
+#define ioremap_uc ioremap
 
Quoted 6 lines

arch/hexagon/include/asm/io.h static inline void writel(u32 data, volatile void __iomem *addr) · line 178

Quoted 1 line
arch/hexagon/include/asm/io.h +0 -0
  #define __raw_writel writel

Do we really need this? There is only one user of ioremap_uc(), which Christoph is trying hard to get rid of, and the new devres helper that triggers all of this :-(
https://lore.kernel.org/dri-devel/[email protected]/

Quoted 2 lines

One may ask why we needed a devres helper in the first place if there is indeed just one user.

Because of the new second user, which jumped on the devres train... a8ff78f7f773142e ("mfd: intel-lpss: Use devm_ioremap_uc for MMIO").

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds