thermal/drivers/Kconfig: Convert the CPU cooling device to a choice
Subsystems (6)
PATCH v4 1/4 thermal/drivers/Kconfig: Convert the CPU cooling device to a choice
The next changes will add a new way to cool down a CPU by injecting idle cycles. With the current configuration, a CPU cooling device is the cpufreq cooling device. As we want to add a new CPU cooling device, let's convert the CPU cooling to a choice giving a list of CPU cooling devices. At this point, there is obviously only one CPU cooling device.
There is no functional changes.
---
V2:
- Default CPU_FREQ_COOLING when CPU_THERMAL is set (Viresh Kumar)
--- drivers/thermal/Kconfig | 14 ++++++++++++-- drivers/thermal/Makefile | 2 +- include/linux/cpu_cooling.h | 6 +++--- 3 files changed, 16 insertions(+), 6 deletions(-)
drivers/thermal/Kconfig +12 -2
@@ -150,8 +150,18 @@ config THERMAL_GOV_POWER_ALLOCATOR config CPU_THERMAL bool "Generic cpu cooling support" - depends on CPU_FREQ depends on THERMAL_OF + help + Enable the CPU cooling features. If the system has no active + cooling device available, this option allows to use the CPU + as a cooling device. + +if CPU_THERMAL + +config CPU_FREQ_THERMAL + bool "CPU frequency cooling device" + depends on CPU_FREQ + default y help This implements the generic cpu cooling mechanism through frequency reduction. An ACPI version of this already exists
@@ -159,7 +169,7 @@ config CPU_THERMAL This will be useful for platforms using the generic thermal interface and not the ACPI interface. - If you want this support, you should say Y here. +endif config CLOCK_THERMAL bool "Generic clock cooling support"
drivers/thermal/Makefile +1 -1
@@ -19,7 +19,7 @@ thermal_sys-$(CONFIG_THERMAL_GOV_USER_SPACE) += user_space.o thermal_sys-$(CONFIG_THERMAL_GOV_POWER_ALLOCATOR) += power_allocator.o # cpufreq cooling -thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o +thermal_sys-$(CONFIG_CPU_FREQ_THERMAL) += cpu_cooling.o # clock cooling thermal_sys-$(CONFIG_CLOCK_THERMAL) += clock_cooling.o
include/linux/cpu_cooling.h +3 -3
@@ -19,7 +19,7 @@struct cpufreq_policy ; -#ifdef CONFIG_CPU_THERMAL +#ifdef CONFIG_CPU_FREQ_THERMAL /** * cpufreq_cooling_register - function to create cpufreq cooling device. * @policy: cpufreq policy.
@@ -40,7 +40,7 @@ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev);struct thermal_cooling_device *of_cpufreq_cooling_register (struct cpufreq_policy *policy); -#else /* !CONFIG_CPU_THERMAL */ +#else /* !CONFIG_CPU_FREQ_THERMAL */ static inline struct thermal_cooling_device *cpufreq_cooling_register (struct cpufreq_policy *policy) {
@@ -58,6 +58,6 @@ of_cpufreq_cooling_register(struct cpufreq_policy *policy) {return NULL ; } -#endif /* CONFIG_CPU_THERMAL */ +#endif /* CONFIG_CPU_FREQ_THERMAL */ #endif /* __CPU_COOLING_H__ */
Signature · 1 line
2.17.1
PATCH v4 2/4 thermal/drivers/cpu_cooling: Add idle cooling device documentation
Provide some documentation for the idle injection cooling effect in order to let people to understand the rational of the approach for the idle injection CPU cooling device.
---
V4:
- Fixed typos, replaced 'period' per 'duty cycles', clarified some wording (Amit Kucheria)
--- .../driver-api/thermal/cpu-idle-cooling.rst | 189 ++++++++++++++++++ 1 file changed, 189 insertions(+) create mode 100644 Documentation/driver-api/thermal/cpu-idle-cooling.rst
Documentation/driver-api/thermal/cpu-idle-cooling.rst new file +189 -0
@@ -0,0 +1,189 @@ + +Situation: +---------- + +Under certain circumstances a SoC can reach a critical temperature +limit and is unable to stabilize the temperature around a temperature +control. When the SoC has to stabilize the temperature, the kernel can +act on a cooling device to mitigate the dissipated power. When the +critical temperature is reached, a decision must be taken to reduce +the temperature, that, in turn impacts performance. + +Another situation is when the silicon temperature continues to +increase even after the dynamic leakage is reduced to its minimum by +clock gating the component. This runaway phenomenon can continue due +to the static leakage. The only solution is to power down the +component, thus dropping the dynamic and static leakage that will +allow the component to cool down. + +Last but not least, the system can ask for a specific power budget but +because of the OPP density, we can only choose an OPP with a power +budget lower than the requested one and under-utilize the CPU, thus +losing performance. In other words, one OPP under-utilizes the CPU +with a power less than the requested power budget and the next OPP +exceeds the power budget. An intermediate OPP could have been used if +it were present. + +Solutions: +---------- + +If we can remove the static and the dynamic leakage for a specific +duration in a controlled period, the SoC temperature will +decrease. Acting on the idle state duration or the idle cycle +injection period, we can mitigate the temperature by modulating the +power budget. + +The Operating Performance Point (OPP) density has a great influence on +the control precision of cpufreq, however different vendors have a +plethora of OPP density, and some have large power gap between OPPs, +that will result in loss of performance during thermal control and +loss of power in other scenarios. + +At a specific OPP, we can assume that injecting idle cycle on all CPUs +belong to the same cluster, with a duration greater than the cluster +idle state target residency, we lead to dropping the static and the +dynamic leakage for this period (modulo the energy needed to enter +this state). So the sustainable power with idle cycles has a linear +relation with the OPP’s sustainable power and can be computed with a +coefficient similar to: + + Power(IdleCycle) = Coef x Power(OPP) + +Idle Injection: +--------------- + +The base concept of the idle injection is to force the CPU to go to an +idle state for a specified time each control cycle, it provides +another way to control CPU power and heat in addition to +cpufreq. Ideally, if all CPUs belonging to the same cluster, inject +their idle cycles synchronously, the cluster can reach its power down +state with a minimum power consumption and reduce the static leakage +to almost zero. However, these idle cycles injection will add extra +latencies as the CPUs will have to wakeup from a deep sleep state. + +We use a fixed duration of idle injection that gives an acceptable +performance penalty and a fixed latency. Mitigation can be increased +or decreased by modulating the duty cycle of the idle injection. + + ^ + | + | + |------- ------- + |_______|_______________________|_______|___________ + + <------> + idle <----------------------> + running + + <-----------------------------> + duty cycle 25% + + +The implementation of the cooling device bases the number of states on +the duty cycle percentage. When no mitigation is happening the cooling +device state is zero, meaning the duty cycle is 0%. + +When the mitigation begins, depending on the governor's policy, a +starting state is selected. With a fixed idle duration and the duty +cycle (aka the cooling device state), the running duration can be +computed. + +The governor will change the cooling device state thus the duty cycle +and this variation will modulate the cooling effect. + + ^ + | + | + |------- ------- + |_______|_______________|_______|___________ + + <------> + idle <--------------> + running + + <-----------------------------> + duty cycle 33% + + + ^ + | + | + |------- ------- + |_______|_______|_______|___________ + + <------> + idle <------> + running + + <-------------> + duty cycle 50% + +The idle injection duration value must comply with the constraints: + +- It is less than or equal to the latency we tolerate when the + mitigation begins. It is platform dependent and will depend on the + user experience, reactivity vs performance trade off we want. This + value should be specified. + +- It is greater than the idle state’s target residency we want to go + for thermal mitigation, otherwise we end up consuming more energy. + +Power considerations +-------------------- + +When we reach the thermal trip point, we have to sustain a specified +power for a specific temperature but at this time we consume: + + Power = Capacitance x Voltage^2 x Frequency x Utilisation + +... which is more than the sustainable power (or there is something +wrong in the system setup). The ‘Capacitance’ and ‘Utilisation’ are a +fixed value, ‘Voltage’ and the ‘Frequency’ are fixed artificially +because we don’t want to change the OPP. We can group the +‘Capacitance’ and the ‘Utilisation’ into a single term which is the +‘Dynamic Power Coefficient (Cdyn)’ Simplifying the above, we have: + + Pdyn = Cdyn x Voltage^2 x Frequency + +The power allocator governor will ask us somehow to reduce our power +in order to target the sustainable power defined in the device +tree. So with the idle injection mechanism, we want an average power +(Ptarget) resulting in an amount of time running at full power on a +specific OPP and idle another amount of time. That could be put in a +equation: + + P(opp)target = ((Trunning x (P(opp)running) + (Tidle x P(opp)idle)) / + (Trunning + Tidle) + ... + + Tidle = Trunning x ((P(opp)running / P(opp)target) - 1) + +At this point if we know the running period for the CPU, that gives us +the idle injection we need. Alternatively if we have the idle +injection duration, we can compute the running duration with: + + Trunning = Tidle / ((P(opp)running / P(opp)target) - 1) + +Practically, if the running power is less than the targeted power, we +end up with a negative time value, so obviously the equation usage is +bound to a power reduction, hence a higher OPP is needed to have the +running power greater than the targeted power. + +However, in this demonstration we ignore three aspects: + + * The static leakage is not defined here, we can introduce it in the + equation but assuming it will be zero most of the time as it is + difficult to get the values from the SoC vendors + + * The idle state wake up latency (or entry + exit latency) is not + taken into account, it must be added in the equation in order to + rigorously compute the idle injection + + * The injected idle duration must be greater than the idle state + target residency, otherwise we end up consuming more energy and + potentially invert the mitigation effect + +So the final equation is: + + Trunning = (Tidle - Twakeup ) x + (((P(opp)dyn + P(opp)static ) - P(opp)target) / P(opp)target )
Signature · 1 line
2.17.1
PATCH v4 3/4 thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver
In reply to Daniel LezcanoThe cpu idle cooling device offers a new method to cool down a CPU by injecting idle cycles at runtime.
It has some similarities with the intel power clamp driver but it is actually designed to be more generic and relying on the idle injection powercap framework.
The idle injection duration is fixed while the running duration is variable. That allows to have control on the device reactivity for the user experience.
An idle state powering down the CPU or the cluster will allow to drop the static leakage, thus restoring the heat capacity of the SoC. It can be set with a trip point between the hot and the critical points, giving the opportunity to prevent a hard reset of the system when the cpufreq cooling fails to cool down the CPU.
With more sophisticated boards having a per core sensor, the idle cooling device allows to cool down a single core without throttling the compute capacity of several cpus belonging to the same clock line, so it could be used in collaboration with the cpufreq cooling device.
---
V4:
- Fixed typos in the kernel-doc and clarified the changelog (Amit Kucheria)
V3:
- Add missing parameter documentation (Viresh Kumar)
- Fixed function description (Viresh Kumar)
- Add entry in MAINTAINER file
V2:
- Remove idle_duration_us field and use idle_inject API instead (Viresh Kumar)
- Fixed function definition wheh CPU_IDLE_COOLING is not set
- Inverted the initialization in the init function (Viresh Kumar)
--- MAINTAINERS | 3 + drivers/thermal/Kconfig | 7 + drivers/thermal/Makefile | 1 + drivers/thermal/cpuidle_cooling.c | 234 ++++++++++++++++++++++++++++++ include/linux/cpu_cooling.h | 22 +++ 5 files changed, 267 insertions(+) create mode 100644 drivers/thermal/cpuidle_cooling.c
MAINTAINERS +3 -0
@@ -16187,12 +16187,15 @@ F: Documentation/devicetree/bindings/thermal/ THERMAL/CPU_COOLING M: Amit Daniel Kachhap <[email protected]> +M: Daniel Lezcano <[email protected]> M: Viresh Kumar <[email protected]> M: Javi Merino <[email protected]> L: [email protected] S: Supported F: Documentation/driver-api/thermal/cpu-cooling-api.rst +F: Documentation/driver-api/thermal/cpu-idle-cooling.rst F: drivers/thermal/cpu_cooling.c +F: drivers/thermal/cpuidle_cooling.c F: include/linux/cpu_cooling.h THINKPAD ACPI EXTRAS DRIVER
drivers/thermal/Kconfig +7 -0
@@ -169,6 +169,13 @@ config CPU_FREQ_THERMAL This will be useful for platforms using the generic thermal interface and not the ACPI interface. +config CPU_IDLE_THERMAL + bool "CPU idle cooling device" + depends on IDLE_INJECT + help + This implements the CPU cooling mechanism through + idle injection. This will throttle the CPU by injecting + idle cycle. endif config CLOCK_THERMAL
drivers/thermal/Makefile +1 -0
@@ -20,6 +20,7 @@ thermal_sys-$(CONFIG_THERMAL_GOV_POWER_ALLOCATOR) += power_allocator.o # cpufreq cooling thermal_sys-$(CONFIG_CPU_FREQ_THERMAL) += cpu_cooling.o +thermal_sys-$(CONFIG_CPU_IDLE_THERMAL) += cpuidle_cooling.o # clock cooling thermal_sys-$(CONFIG_CLOCK_THERMAL) += clock_cooling.o
drivers/thermal/cpuidle_cooling.c new file +234 -0
234 lines not on this page · raw message
include/linux/cpu_cooling.h +22 -0
@@ -60,4 +60,26 @@ of_cpufreq_cooling_register(struct cpufreq_policy *policy) }#endif /* CONFIG_CPU_FREQ_THERMAL */ +struct cpuidle_driver ; + +#ifdef CONFIG_CPU_IDLE_THERMAL +extern struct thermal_cooling_device * +__init cpuidle_cooling_register (struct cpuidle_driver *drv); +extern struct thermal_cooling_device * +__init cpuidle_of_cooling_register (struct device_node *np, +struct cpuidle_driver *drv); +#else /* CONFIG_CPU_IDLE_THERMAL */ +static inline struct thermal_cooling_device * +__init cpuidle_cooling_register (struct cpuidle_driver *drv) +{ +return ERR_PTR (-EINVAL ); +} +static inline struct thermal_cooling_device * +__init cpuidle_of_cooling_register (struct device_node *np, +struct cpuidle_driver *drv) +{ +return ERR_PTR (-EINVAL ); +} +#endif /* CONFIG_CPU_IDLE_THERMAL */ +#endif /* __CPU_COOLING_H__ */
Signature · 1 line
2.17.1
PATCH v4 4/4 thermal/drivers/cpu_cooling: Rename to cpufreq_cooling
In reply to Daniel LezcanoAs we introduced the idle injection cooling device called cpuidle_cooling, let's be consistent and rename the cpu_cooling to cpufreq_cooling as this one mitigates with OPPs changes.
---
V4:
- Added Acked-by and Reviewed-by
V3:
- Fix missing name conversion (Viresh Kumar)
---
Documentation/driver-api/thermal/exynos_thermal.rst | 2 +-
MAINTAINERS | 2 +-
drivers/thermal/Makefile | 2 +-
drivers/thermal/clock_cooling.c | 2 +-
drivers/thermal/{cpu_cooling.c => cpufreq_cooling.c} | 6 +++---
include/linux/clock_cooling.h | 2 +-
6 files changed, 8 insertions(+), 8 deletions(-)
rename drivers/thermal/{cpu_cooling.c => cpufreq_cooling.c} (99%)Documentation/driver-api/thermal/exynos_thermal.rst +1 -1
@@ -67,7 +67,7 @@ TMU driver description: The exynos thermal driver is structured as:: Kernel Core thermal framework - (thermal_core.c, step_wise.c, cpu_cooling.c) + (thermal_core.c, step_wise.c, cpufreq_cooling.c) ^ | |
MAINTAINERS +1 -1
@@ -16194,7 +16194,7 @@ L: [email protected] S: Supported F: Documentation/driver-api/thermal/cpu-cooling-api.rst F: Documentation/driver-api/thermal/cpu-idle-cooling.rst -F: drivers/thermal/cpu_cooling.c +F: drivers/thermal/cpufreq_cooling.c F: drivers/thermal/cpuidle_cooling.c F: include/linux/cpu_cooling.h
drivers/thermal/Makefile +1 -1
@@ -19,7 +19,7 @@ thermal_sys-$(CONFIG_THERMAL_GOV_USER_SPACE) += user_space.o thermal_sys-$(CONFIG_THERMAL_GOV_POWER_ALLOCATOR) += power_allocator.o # cpufreq cooling -thermal_sys-$(CONFIG_CPU_FREQ_THERMAL) += cpu_cooling.o +thermal_sys-$(CONFIG_CPU_FREQ_THERMAL) += cpufreq_cooling.o thermal_sys-$(CONFIG_CPU_IDLE_THERMAL) += cpuidle_cooling.o # clock cooling
drivers/thermal/clock_cooling.c +1 -1
@@ -7,7 +7,7 @@* Copyright (C) 2013 Texas Instruments Inc. * Contact: Eduardo Valentin <[email protected]> * -* Highly based on cpu_cooling.c. +* Highly based on cpufreq_cooling.c. * Copyright (C) 2012 Samsung Electronics Co., Ltd(http://www.samsung.com) * Copyright (C) 2012 Amit Daniel <[email protected]> */
drivers/thermal/cpufreq_cooling.c renamed from drivers/thermal/cpu_cooling.c +3 -3
@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* -* linux/drivers/thermal/cpu_cooling.c +* linux/drivers/thermal/cpufreq_cooling.c * * Copyright (C) 2012 Samsung Electronics Co., Ltd(http://www.samsung.com) *
@@ -694,7 +694,7 @@ of_cpufreq_cooling_register(struct cpufreq_policy *policy)u32 capacitance =0 ;if (!np) { -pr_err ("cpu_cooling: OF node not available for cpu%d\n" , +pr_err ("cpufreq_cooling: OF node not available for cpu%d\n" , policy->cpu);return NULL ; }
@@ -705,7 +705,7 @@ of_cpufreq_cooling_register(struct cpufreq_policy *policy) cdev =__cpufreq_cooling_register (np, policy, capacitance);if (IS_ERR (cdev)) { -pr_err ("cpu_cooling: cpu%d failed to register as cooling device: %ld\n" , +pr_err ("cpufreq_cooling: cpu%d failed to register as cooling device: %ld\n" , policy->cpu,PTR_ERR (cdev)); cdev =NULL ; }
include/linux/clock_cooling.h +1 -1
@@ -7,7 +7,7 @@* Copyright (C) 2013 Texas Instruments Inc. * Contact: Eduardo Valentin <[email protected]> * -* Highly based on cpu_cooling.c. +* Highly based on cpufreq_cooling.c. * Copyright (C) 2012 Samsung Electronics Co., Ltd(http://www.samsung.com) * Copyright (C) 2012 Amit Daniel <[email protected]> */
Signature · 1 line
2.17.1
Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling
I tested this on the librem5-devkit and see the
cooling devices in sysfs. I configure ARM_PSCI_CPUIDLE, not ARM_CPUIDLE and add the patch below in register the cooling device there. "psci_idle" is listed as the cpuidle_driver.
That's what I'm running, in case you want to see it all:
https://source.puri.sm/martin.kepplinger/linux-next/commits/next-20191205/librem5_cpuidle_mainline_atf
so I add a trip temperature description like this:
https://source.puri.sm/martin.kepplinger/linux-next/commit/361f49f93ae2c477fd012790831cabd0ed976660
When I let the SoC heat up, cpuidle cooling won't kick it. In sysfs:
catting the relevant files in /sys/class/thermal after heating up, if that makes sense:
87000
85000
85000
thermal-cpufreq-0
1
thermal-idle-0
0
thermal-idle-1
0
thermal-idle-2
0
thermal-idle-3
0
with ARM_CPUIDLE instead of ARM_PSCI_CPUIDLE (and registering the cooling dev during cpuidle-arm.c init) I won't have a cpuidle driver and thus no cpu-sleep state at all.
Can you see where the problem here lies?
thanks!
martin
--- drivers/cpuidle/cpuidle-psci.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/cpuidle/cpuidle-psci.c +3 -0
@@ -8,6 +8,7 @@#define pr_fmt (fmt) "CPUidle PSCI: " fmt +#include <linux/cpu_cooling.h> #include <linux/cpuidle.h> #include <linux/cpumask.h> #include <linux/cpu_pm.h>
@@ -195,6 +196,8 @@ static int __init psci_idle_init_cpu(int cpu)if (ret) goto out_kfree_drv; +cpuidle_cooling_register (drv); +return 0 ; out_kfree_drv:
Signature · 1 line
2.20.1
Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling
Quoted 30 lines · Martin Kepplinger
I tested this on the librem5-devkit and see the
cooling devices in sysfs. I configureARM_PSCI_CPUIDLE, notARM_CPUIDLEand add the patch below in register the cooling device there. "psci_idle" is listed as thecpuidle_driver.That's what I'm running, in case you want to see it all:
https://source.puri.sm/martin.kepplinger/linux-next/commits/next-20191205/librem5_cpuidle_mainline_atfso I add a trip temperature description like this:
https://source.puri.sm/martin.kepplinger/linux-next/commit/361f49f93ae2c477fd012790831cabd0ed976660When I let the SoC heat up, cpuidle cooling won't kick it. In sysfs:
catting the relevant files in
/sys/class/thermalafter heating up, if that makes sense:87000
85000
85000
thermal-cpufreq-0
1
thermal-idle-0
0
thermal-idle-1
0
thermal-idle-2
0
thermal-idle-3
0
Quoted 5 lines
with
ARM_CPUIDLEinstead ofARM_PSCI_CPUIDLE(and registering the cooling dev duringcpuidle-arm.cinit) I won't have a cpuidle driver and thus no cpu-sleep state at all.Can you see where the problem here lies?
Yes, I removed the registration via the DT.
Can you try the following:
(quoted diff) +0 -0
b/drivers/cpuidle/dt_idle_states.c
index d06d21a9525d..01367ddec49a 100644
drivers/cpuidle/dt_idle_states.c +4 -0
@@ -13,6 +13,7 @@#include <linux/errno.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/cpu_cooling.h> #include <linux/of.h> #include <linux/of_device.h>
@@ -205,6 +206,9 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, err = -EINVAL ;break ; } + +cpuidle_of_cooling_register (state_node, drv); +of_node_put (state_node); }
That's a hack for the moment.
Quoted 26 lines
--- drivers/cpuidle/cpuidle-psci.c | 3 +++ 1 file changed, 3 insertions(+)drivers/cpuidle/cpuidle-psci.c +3
-0@@ -8,6 +8,7 @@#define pr_fmt (fmt) "CPUidle PSCI: " fmt +#include <linux/cpu_cooling.h> #include <linux/cpuidle.h> #include <linux/cpumask.h> #include <linux/cpu_pm.h> @@ -195,6 +196,8 @@ static int __init psci_idle_init_cpu(int cpu)if (ret) goto out_kfree_drv; +cpuidle_cooling_register (drv); +return 0 ; out_kfree_drv:
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling
Quoted 64 lines · Daniel Lezcano
Quoted 30 lines · Martin Kepplinger
I tested this on the librem5-devkit and see the
cooling devices in sysfs. I configureARM_PSCI_CPUIDLE, notARM_CPUIDLEand add the patch below in register the cooling device there. "psci_idle" is listed as thecpuidle_driver.That's what I'm running, in case you want to see it all:
https://source.puri.sm/martin.kepplinger/linux-next/commits/next-20191205/librem5_cpuidle_mainline_atfso I add a trip temperature description like this:
https://source.puri.sm/martin.kepplinger/linux-next/commit/361f49f93ae2c477fd012790831cabd0ed976660When I let the SoC heat up, cpuidle cooling won't kick it. In sysfs:
catting the relevant files in
/sys/class/thermalafter heating up, if that makes sense:87000
85000
85000
thermal-cpufreq-0
1
thermal-idle-0
0
thermal-idle-1
0
thermal-idle-2
0
thermal-idle-3
0Quoted 5 lines
with
ARM_CPUIDLEinstead ofARM_PSCI_CPUIDLE(and registering the cooling dev duringcpuidle-arm.cinit) I won't have a cpuidle driver and thus no cpu-sleep state at all.Can you see where the problem here lies?
Yes, I removed the registration via the DT.
Can you try the following:
drivers/cpuidle/dt_idle_states.c +4
-0@@ -13,6 +13,7 @@#include <linux/errno.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/cpu_cooling.h> #include <linux/of.h> #include <linux/of_device.h> @@ -205,6 +206,9 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, err = -EINVAL ;break ; } + +cpuidle_of_cooling_register (state_node, drv); +of_node_put (state_node); }
Quoted 2 lines
That's a hack for the moment.
thanks. I could test that successfully. The only question would be: Is is intentional how "non-aggressive" the cooling driver cools? I would have expected it to basically inject more idle cycles earlier. I'd set 75 degrees as trip point and at 85 degress is would only inject about 30 (of 100).
You describe the "config values" in question in the documentation, but I'm not sure what's the correct way to change them.
thanks,
martin
Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling
Quoted 76 lines · Martin Kepplinger
Quoted 64 lines · Daniel Lezcano
Quoted 30 lines · Martin Kepplinger
I tested this on the librem5-devkit and see the
cooling devices in sysfs. I configureARM_PSCI_CPUIDLE, notARM_CPUIDLEand add the patch below in register the cooling device there. "psci_idle" is listed as thecpuidle_driver.That's what I'm running, in case you want to see it all:
https://source.puri.sm/martin.kepplinger/linux-next/commits/next-20191205/librem5_cpuidle_mainline_atfso I add a trip temperature description like this:
https://source.puri.sm/martin.kepplinger/linux-next/commit/361f49f93ae2c477fd012790831cabd0ed976660When I let the SoC heat up, cpuidle cooling won't kick it. In sysfs:
catting the relevant files in
/sys/class/thermalafter heating up, if that makes sense:87000
85000
85000
thermal-cpufreq-0
1
thermal-idle-0
0
thermal-idle-1
0
thermal-idle-2
0
thermal-idle-3
0Quoted 5 lines
with
ARM_CPUIDLEinstead ofARM_PSCI_CPUIDLE(and registering the cooling dev duringcpuidle-arm.cinit) I won't have a cpuidle driver and thus no cpu-sleep state at all.Can you see where the problem here lies?
Yes, I removed the registration via the DT.
Can you try the following:
drivers/cpuidle/dt_idle_states.c +4
-0@@ -13,6 +13,7 @@#include <linux/errno.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/cpu_cooling.h> #include <linux/of.h> #include <linux/of_device.h> @@ -205,6 +206,9 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, err = -EINVAL ;break ; } + +cpuidle_of_cooling_register (state_node, drv); +of_node_put (state_node); }Quoted 2 lines
That's a hack for the moment.
thanks. I could test that successfully. The only question would be: Is is intentional how "non-aggressive" the cooling driver cools? I would have expected it to basically inject more idle cycles earlier. I'd set 75 degrees as trip point and at 85 degress is would only inject about 30 (of 100).
Quoted 2 lines
You describe the "config values" in question in the documentation, but I'm not sure what's the correct way to change them.
That is difficult to say without knowing the board behavior. Are you able to profile the temperature with the load? How fast the temperature increases? The aggressive behavior of the cooling device will depend on the governor which depends on the slope of the temperature increase and the sampling.
Can you give the pointer to the git tree with the DT definition of your board?
You can try by changing the idle duration to 10ms instead of the default 4ms.
You can also change the cooling states in the DT <&state 20 70>, so it will begin to mitigate at state 20. But I wouldn't recommend that.
Do you have the energy power model, so we can try with the IPA governor?
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling
Quoted 68 lines · Daniel Lezcano
Quoted 67 lines · Martin Kepplinger
Quoted 64 lines · Daniel Lezcano
Quoted 30 lines · Martin Kepplinger
I tested this on the librem5-devkit and see the
cooling devices in sysfs. I configureARM_PSCI_CPUIDLE, notARM_CPUIDLEand add the patch below in register the cooling device there. "psci_idle" is listed as thecpuidle_driver.That's what I'm running, in case you want to see it all:
https://source.puri.sm/martin.kepplinger/linux-next/commits/next-20191205/librem5_cpuidle_mainline_atfso I add a trip temperature description like this:
https://source.puri.sm/martin.kepplinger/linux-next/commit/361f49f93ae2c477fd012790831cabd0ed976660When I let the SoC heat up, cpuidle cooling won't kick it. In sysfs:
catting the relevant files in
/sys/class/thermalafter heating up, if that makes sense:87000
85000
85000
thermal-cpufreq-0
1
thermal-idle-0
0
thermal-idle-1
0
thermal-idle-2
0
thermal-idle-3
0Quoted 5 lines
with
ARM_CPUIDLEinstead ofARM_PSCI_CPUIDLE(and registering the cooling dev duringcpuidle-arm.cinit) I won't have a cpuidle driver and thus no cpu-sleep state at all.Can you see where the problem here lies?
Yes, I removed the registration via the DT.
Can you try the following:
drivers/cpuidle/dt_idle_states.c +4
-0@@ -13,6 +13,7 @@#include <linux/errno.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/cpu_cooling.h> #include <linux/of.h> #include <linux/of_device.h> @@ -205,6 +206,9 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, err = -EINVAL ;break ; } + +cpuidle_of_cooling_register (state_node, drv); +of_node_put (state_node); }
Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
That's a hack for the moment.
thanks. I could test that successfully. The only question would be: Is is intentional how "non-aggressive" the cooling driver cools? I would have expected it to basically inject more idle cycles earlier. I'd set 75 degrees as trip point and at 85 degress is would only inject about 30 (of 100).
By the way, how many CPUs are injecting idle cycle when the mitigation happens ?
Quoted 22 lines
Quoted 2 lines
You describe the "config values" in question in the documentation, but I'm not sure what's the correct way to change them.
That is difficult to say without knowing the board behavior. Are you able to profile the temperature with the load? How fast the temperature increases? The aggressive behavior of the cooling device will depend on the governor which depends on the slope of the temperature increase and the sampling.
Can you give the pointer to the git tree with the DT definition of your board?
You can try by changing the idle duration to 10ms instead of the default 4ms.
You can also change the cooling states in the DT <&state 20 70>, so it will begin to mitigate at state 20. But I wouldn't recommend that.
Do you have the energy power model, so we can try with the IPA governor?
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling
Quoted 78 lines · Daniel Lezcano
Quoted 68 lines · Daniel Lezcano
Quoted 67 lines · Martin Kepplinger
Quoted 64 lines · Daniel Lezcano
Quoted 30 lines · Martin Kepplinger
I tested this on the librem5-devkit and see the
cooling devices in sysfs. I configureARM_PSCI_CPUIDLE, notARM_CPUIDLEand add the patch below in register the cooling device there. "psci_idle" is listed as thecpuidle_driver.That's what I'm running, in case you want to see it all:
https://source.puri.sm/martin.kepplinger/linux-next/commits/next-20191205/librem5_cpuidle_mainline_atfso I add a trip temperature description like this:
https://source.puri.sm/martin.kepplinger/linux-next/commit/361f49f93ae2c477fd012790831cabd0ed976660When I let the SoC heat up, cpuidle cooling won't kick it. In sysfs:
catting the relevant files in
/sys/class/thermalafter heating up, if that makes sense:87000
85000
85000
thermal-cpufreq-0
1
thermal-idle-0
0
thermal-idle-1
0
thermal-idle-2
0
thermal-idle-3
0Quoted 5 lines
with
ARM_CPUIDLEinstead ofARM_PSCI_CPUIDLE(and registering the cooling dev duringcpuidle-arm.cinit) I won't have a cpuidle driver and thus no cpu-sleep state at all.Can you see where the problem here lies?
Yes, I removed the registration via the DT.
Can you try the following:
drivers/cpuidle/dt_idle_states.c +4
-0@@ -13,6 +13,7 @@#include <linux/errno.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/cpu_cooling.h> #include <linux/of.h> #include <linux/of_device.h> @@ -205,6 +206,9 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, err = -EINVAL ;break ; } + +cpuidle_of_cooling_register (state_node, drv); +of_node_put (state_node); }Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
That's a hack for the moment.
thanks. I could test that successfully. The only question would be: Is is intentional how "non-aggressive" the cooling driver cools? I would have expected it to basically inject more idle cycles earlier. I'd set 75 degrees as trip point and at 85 degress is would only inject about 30 (of 100).
Quoted 2 lines
By the way, how many CPUs are injecting idle cycle when the mitigation happens ?
all 4 are injecting the same.
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
You describe the "config values" in question in the documentation, but I'm not sure what's the correct way to change them.
Quoted 8 lines
Quoted 8 lines
That is difficult to say without knowing the board behavior. Are you able to profile the temperature with the load? How fast the temperature increases? The aggressive behavior of the cooling device will depend on the governor which depends on the slope of the temperature increase and the sampling.
Can you give the pointer to the git tree with the DT definition of your board?
you can browse in that branch.
Quoted 3 lines
Quoted 3 lines
You can try by changing the idle duration to 10ms instead of the default 4ms.
where is that set?
Quoted 3 lines
Quoted 3 lines
You can also change the cooling states in the DT <&state 20 70>, so it will begin to mitigate at state 20. But I wouldn't recommend that.
where would we assign that? I'm not sure who reads that -.- it's still something to consider, but a longer idle duration makes more sense, yes.
Quoted 4 lines
Quoted 4 lines
Do you have the energy power model, so we can try with the IPA governor?
thanks for the reminder. I'd look at that later.
martin
Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling
Quoted 101 lines · Martin Kepplinger
Quoted 78 lines · Daniel Lezcano
Quoted 68 lines · Daniel Lezcano
Quoted 67 lines · Martin Kepplinger
Quoted 64 lines · Daniel Lezcano
Quoted 30 lines · Martin Kepplinger
I tested this on the librem5-devkit and see the
cooling devices in sysfs. I configureARM_PSCI_CPUIDLE, notARM_CPUIDLEand add the patch below in register the cooling device there. "psci_idle" is listed as thecpuidle_driver.That's what I'm running, in case you want to see it all:
https://source.puri.sm/martin.kepplinger/linux-next/commits/next-20191205/librem5_cpuidle_mainline_atfso I add a trip temperature description like this:
https://source.puri.sm/martin.kepplinger/linux-next/commit/361f49f93ae2c477fd012790831cabd0ed976660When I let the SoC heat up, cpuidle cooling won't kick it. In sysfs:
catting the relevant files in
/sys/class/thermalafter heating up, if that makes sense:87000
85000
85000
thermal-cpufreq-0
1
thermal-idle-0
0
thermal-idle-1
0
thermal-idle-2
0
thermal-idle-3
0Quoted 5 lines
with
ARM_CPUIDLEinstead ofARM_PSCI_CPUIDLE(and registering the cooling dev duringcpuidle-arm.cinit) I won't have a cpuidle driver and thus no cpu-sleep state at all.Can you see where the problem here lies?
Yes, I removed the registration via the DT.
Can you try the following:
drivers/cpuidle/dt_idle_states.c +4
-0@@ -13,6 +13,7 @@#include <linux/errno.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/cpu_cooling.h> #include <linux/of.h> #include <linux/of_device.h> @@ -205,6 +206,9 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, err = -EINVAL ;break ; } + +cpuidle_of_cooling_register (state_node, drv); +of_node_put (state_node); }Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
That's a hack for the moment.
thanks. I could test that successfully. The only question would be: Is is intentional how "non-aggressive" the cooling driver cools? I would have expected it to basically inject more idle cycles earlier. I'd set 75 degrees as trip point and at 85 degress is would only inject about 30 (of 100).
Quoted 2 lines
By the way, how many CPUs are injecting idle cycle when the mitigation happens ?
all 4 are injecting the same.
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
You describe the "config values" in question in the documentation, but I'm not sure what's the correct way to change them.
Quoted 8 lines
Quoted 8 lines
That is difficult to say without knowing the board behavior. Are you able to profile the temperature with the load? How fast the temperature increases? The aggressive behavior of the cooling device will depend on the governor which depends on the slope of the temperature increase and the sampling.
Can you give the pointer to the git tree with the DT definition of your board?
Quoted 7 lines
you can browse in that branch.
Quoted 3 lines
Quoted 3 lines
You can try by changing the idle duration to 10ms instead of the default 4ms.
where is that set?
(quoted diff) +0 -0
b/drivers/thermal/cpuidle_cooling.c
index 369c5c613f6b..0793e722b2d2 100644
drivers/thermal/cpuidle_cooling.c +0 -0
@@ -192,7 +192,7 @@ __init cpuidle_of_cooling_register(struct
device_node *np,
goto out_id;
}- idle_inject_set_duration(ii_dev, 0, TICK_USEC);
+ idle_inject_set_duration(ii_dev, 0, 10000);
idle_cdev->ii_dev = ii_dev;
Quoted 16 lines
Quoted 3 lines
Quoted 3 lines
You can also change the cooling states in the DT <&state 20 70>, so it will begin to mitigate at state 20. But I wouldn't recommend that.
where would we assign that? I'm not sure who reads that -.-> it's still something to consider, but a longer idle duration makes more sense, yes.
Quoted 4 lines
Quoted 4 lines
Do you have the energy power model, so we can try with the IPA governor?
thanks for the reminder. I'd look at that later.
martin
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling
In reply to Martin KepplingerHi Martin,
I've a bug in the code.
(quoted diff) +0 -0
b/drivers/thermal/cpuidle_cooling.c
index 369c5c613f6b..628ad707f247 100644
drivers/thermal/cpuidle_cooling.c +0 -0
@@ -192,7 +192,7 @@ __init cpuidle_of_cooling_register(struct
device_node *np,
goto out_id;
}- idle_inject_set_duration(ii_dev, 0, TICK_USEC);
+ idle_inject_set_duration(ii_dev, TICK_USEC, TICK_USEC);
idle_cdev->ii_dev = ii_dev;
Let me know if that solves your issue.
-- Daniel
Quoted 126 lines · Martin Kepplinger
Quoted 78 lines · Daniel Lezcano
Quoted 68 lines · Daniel Lezcano
Quoted 67 lines · Martin Kepplinger
Quoted 64 lines · Daniel Lezcano
Quoted 30 lines · Martin Kepplinger
I tested this on the librem5-devkit and see the
cooling devices in sysfs. I configureARM_PSCI_CPUIDLE, notARM_CPUIDLEand add the patch below in register the cooling device there. "psci_idle" is listed as thecpuidle_driver.That's what I'm running, in case you want to see it all:
https://source.puri.sm/martin.kepplinger/linux-next/commits/next-20191205/librem5_cpuidle_mainline_atfso I add a trip temperature description like this:
https://source.puri.sm/martin.kepplinger/linux-next/commit/361f49f93ae2c477fd012790831cabd0ed976660When I let the SoC heat up, cpuidle cooling won't kick it. In sysfs:
catting the relevant files in
/sys/class/thermalafter heating up, if that makes sense:87000
85000
85000
thermal-cpufreq-0
1
thermal-idle-0
0
thermal-idle-1
0
thermal-idle-2
0
thermal-idle-3
0Quoted 5 lines
with
ARM_CPUIDLEinstead ofARM_PSCI_CPUIDLE(and registering the cooling dev duringcpuidle-arm.cinit) I won't have a cpuidle driver and thus no cpu-sleep state at all.Can you see where the problem here lies?
Yes, I removed the registration via the DT.
Can you try the following:
drivers/cpuidle/dt_idle_states.c +4
-0@@ -13,6 +13,7 @@#include <linux/errno.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/cpu_cooling.h> #include <linux/of.h> #include <linux/of_device.h> @@ -205,6 +206,9 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, err = -EINVAL ;break ; } + +cpuidle_of_cooling_register (state_node, drv); +of_node_put (state_node); }Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
That's a hack for the moment.
thanks. I could test that successfully. The only question would be: Is is intentional how "non-aggressive" the cooling driver cools? I would have expected it to basically inject more idle cycles earlier. I'd set 75 degrees as trip point and at 85 degress is would only inject about 30 (of 100).
Quoted 2 lines
By the way, how many CPUs are injecting idle cycle when the mitigation happens ?
all 4 are injecting the same.
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
You describe the "config values" in question in the documentation, but I'm not sure what's the correct way to change them.
Quoted 8 lines
Quoted 8 lines
That is difficult to say without knowing the board behavior. Are you able to profile the temperature with the load? How fast the temperature increases? The aggressive behavior of the cooling device will depend on the governor which depends on the slope of the temperature increase and the sampling.
Can you give the pointer to the git tree with the DT definition of your board?
you can browse in that branch.
Quoted 3 lines
Quoted 3 lines
You can try by changing the idle duration to 10ms instead of the default 4ms.
where is that set?
Quoted 3 lines
Quoted 3 lines
You can also change the cooling states in the DT <&state 20 70>, so it will begin to mitigate at state 20. But I wouldn't recommend that.
where would we assign that? I'm not sure who reads that -.- it's still something to consider, but a longer idle duration makes more sense, yes.
Quoted 4 lines
Quoted 4 lines
Do you have the energy power model, so we can try with the IPA governor?
thanks for the reminder. I'd look at that later.
martin
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling
Quoted 22 lines · Daniel Lezcano
Hi Martin,
I've a bug in the code.
drivers/thermal/cpuidle_cooling.c +1
-1@@ -192,7 +192,7 @@ __init cpuidle_of_cooling_register(structdevice_node *np, goto out_id; } -idle_inject_set_duration (ii_dev,0 ,TICK_USEC ); +idle_inject_set_duration (ii_dev,TICK_USEC ,TICK_USEC ); idle_cdev->ii_dev = ii_dev;
Quoted 2 lines
Let me know if that solves your issue.
It does. I now won't heat up over the hot trip point at all. That's what I was expecting. thanks!
martin